Talk:Memory Leak Fixes

From Valve Developer Community
Jump to: navigation, search

ts - this is based on what we talked about? --Amckern 19:16, 13 Jan 2006 (PST)

sorta no—ts2do talk 19:20, 13 Jan 2006 (PST)

Thanks for this mate! Big help now i understand where your fixes point!

I tested these fixes in Dystopia, after playing for 15 or so minutes we got random crashes when calls where made to create new keyvalues, so I've taken them back out but opted to leave leaktrack in instead to clean up the mess afterwards --Teddy 18:25, 23 Mar 2006 (PST)

Do you know any specifics on the crash?...anyways I'd like to mention that even if your mod didn't have any leaks, the vgui modules (server browser, etc..) create KeyValues leaks—ts2do 18:40, 23 Mar 2006 (PST)

Not part of server.dll

3.2 RecvTable class and 3.3 CSentence class

Those are not part of server.dll - Mrmagu 22:19, 29 Jan 2006 (PST)

Fix fixed—ts2do 05:16, 30 Jan 2006 (PST)

SectionedListPanel class

Deleting this CInlineEditPanel object here causes a crash when you change a key-binding.

Want to test if m_hEditPanel...->MarkForDeletion() works?—ts2do 05:24, 2 Aug 2006 (PDT)
I'm inclined not to delete the m_hEditPanel object in the SectionedListPanel class since it is not created in that class. [Aphromaniac] 14:09, 2 Aug 2006 (GMT)
As far as I can see, m_hEditPanel is only set through EnterEditMode(). Only the VControlsListPanel class calls this method passing in m_pInlineEditPanel which is created in the VControlsListPanel constructor and marked for deletion in the VControlsListPanel destructor. I can't see any memory leak. [Aphromaniac] 14:19, 2 Aug 2006 (GMT)