Memory Leak Fixes: Difference between revisions

From Valve Developer Community
Jump to navigation Jump to search
Line 19: Line 19:
  > kv->deleteThis();
  > kv->deleteThis();
  294a297
  294a297
m_pDirTree->AddItem(kv, parentNodeIndex);
  > kv->deleteThis();
  > kv->deleteThis();
}
  410a414
  410a414
int itemID = m_pDirTree->AddItem(kv, selectedIndex);
  > kv->deleteThis();
  > kv->deleteThis();



Revision as of 21:23, 11 January 2006

On this page goes fixes for memory leaks in the SDK.

bin\client.dll

CPanelMetaClassMgrImp class

src\cl_dll\panelmetaclassmgr.cpp
236a237,241
>	while(m_MetaClassKeyValues.Count()>0)
>	{
>		m_MetaClassKeyValues[0]->deleteThis();
>	}
>	m_MetaClassKeyValues.RemoveAll();

src\lib\vgui_controls.lib

DirectorySelectDialog class

src\vgui2\controls\DirectorySelectDialog.cpp
258c258,260
<	int rootIndex = m_pDirTree->AddItem(new KeyValues("root", "Text", m_szCurrentDrive), -1);
---
>	KeyValues *kv = new KeyValues("root", "Text", m_szCurrentDrive);
>	int rootIndex = m_pDirTree->AddItem(kv, -1);
>	kv->deleteThis();
294a297
				m_pDirTree->AddItem(kv, parentNodeIndex);
>				kv->deleteThis();
			}
410a414
			int itemID = m_pDirTree->AddItem(kv, selectedIndex);
>			kv->deleteThis();

FileOpenDialog class

src\vgui2\controls\FileOpenDialog.cpp
506a507
	int itemID = m_pFileTypeCombo->AddItem(filterName, kv);
>	kv->deleteThis();
	if ( bActive )

ScrollBar class

src\vgui2\controls\ScrollBar.cpp
323c323
<               _button[index]->SetParent((Panel *)NULL);
---
>               _button[index]->DeletePanel();
351c351
<               _slider->SetParent((Panel *)NULL);
---
>               _slider->DeletePanel();