SDK Known Issues List: Difference between revisions

From Valve Developer Community
Jump to navigation Jump to search
mNo edit summary
m (add list cat)
 
(98 intermediate revisions by 21 users not shown)
Line 1: Line 1:
{{note|A lot of this code is for [[HL2:MP]] — yet much is applicable to [[HL2]]. If you can't find the said function, don’t fret, it is not in your SDK version.}}
{{Note|This page is for the SDK code. For the SDK tools, see [[Source SDK Known Issues]]. For the HL2 core, see the [[Core Known Issues List]] or the [http://tinyurl.com/ndfsc HL2 Bugzilla].}} The patches listed here are in unidiff format.
== First pass at compiling server_hl2mp-2005.vcproj under Linux ==


{{Note|This page is for the modcode only. For any problems with the SDK tools, see [[Source SDK Known Issues]]}}
=== Preconditions ===
Setup the SDK as desribed in http://developer.valvesoftware.com/wiki/Compiling_under_Linux but obtained with "Modify Half-Life 2 Multiplayer" instead of "Source code only (advanced users only)". Obtained and compiled as of Sunday, February the 15th, 2009. Using Debian Lenny.


== Usercmd sends unneeded extra data ==
=== Issues ===
The [[usercmd]] sends data many times per sec and some of it don't really seem needed.


=== Impulse commands ===
==== ../dlls/lightglow.cpp:57: error: 'SendProxy_Angles' was not declared in this scope ====
Usercmd sends the impulse commands also every time. Unless the impulse commands change VERY often, this is a bandwidth waste.
Ambiguous function pointer. One probable fix could be to add '0, ' before the inclined call and add an 'extern ' declaration of the inclined function.
It's better to change this to a normal command.


==== cl_dll/in_main.cpp ====
==== /usr/include/c++/3.4/limits:292:22: macro "max" requires 2 arguments, but only 1 given ====
Remove:
In file included from /usr/include/c++/3.4/memory:61, from /usr/include/c++/3.4/string:48, from ../dlls/../public/stdstring.h:26, from ../dlls/ai_playerally.h:18, from ../dlls/npc_talker.h:34, from ../dlls/npc_talker.cpp:10
<pre>static int in_impulse = 0;</pre>
Maybe fixed by commenting out #include <set> in ../dlls/npc_talker.h
<pre>void IN_Impulse (void)
{
in_impulse = atoi( engine->Cmd_Argv(1) );
}</pre>
<pre>// Latch and clear impulse
cmd->impulse = in_impulse;
in_impulse = 0;</pre>
<pre>static ConCommand impulse("impulse", IN_Impulse);</pre>


==== cl_dll/prediction.cpp ====
==== ../game_shared/gamestats/ep1_gamestats.h:14:27: tier1/UtlDict.h: No such file or directory ====
Remove:
In file included from ../dlls/../game_shared/gamestats/ep1_gamestats.cpp:7. Probably because public is not part of the path. Probably also because of case sensitivity.
<pre>move->m_nImpulseCommand = ucmd->impulse;</pre>
Fix:
ln -s ../public/tier1 tier1
ln ../public/tier1/utlbuffer.h tier1/UtlBuffer.h
ln ../public/tier1/utldict.h tier1/UtlDict.h


==== dlls/player.cpp ====
==== ../dlls/episodic/grenade_hopwire.h:14:20: sprite.h: No such file or directory ====
Remove:
In file included from ../dlls/episodic/grenade_hopwire.cpp:8
<pre>DEFINE_FIELD( m_nImpulse, FIELD_INTEGER ),</pre>
Fix:
<pre>ucmd->impulse = 0;</pre>
<pre>cmd.impulse = ucmd->impulse; </pre>
(The last line is in the file twice)


ln ../game_shared/Sprite.h ../game_shared/sprite.h


Change <code>void CBasePlayer::ImpulseCommands( )</code> to <code>void CBasePlayer::ImpulseCommands( int iImpulse ) </code>. Don't forget the header too.
The compile completed after these issues in the first pass.


Add the following code to the top:
== Issues only with SDK 2006-08-04 ==
<pre>// DM: If we are frozen, don't accept impulse-commands
if ( GetFlags() & FL_FROZEN )
return;</pre>
I guess the comment speaks for itself.


Remove in that function also:
=== Assert whenever Gravity Gun is holding a crate/barrel that explodes ===
<pre>int iImpulse = (int)m_nImpulse; </pre>
See bugzilla [http://developer.valvesoftware.com/cgi-bin/bugzilla/show_bug.cgi?id=13].
<pre>m_nImpulse = 0;</pre>


Then look for the function <code>CBasePlayer::ClientCommand()</code> and add the following:
=== Assert: no supported muzzle flash for the type specified ===
<pre>else if( stricmp( cmd, "impulse" ) == 0 && engine->Cmd_Argc() == 2 )
This is apparently a bug in the HL2 model so looks like there's nothing to be done but comment out the assert.
{
ImpulseCommands( atoi(engine->Cmd_Argv( 1 )) );
return true;
}</pre>


Don't forget the HL2DM equivalents.
<pre>
--- src/cl_dll/c_te_legacytempents.cpp      26 Aug 2006 21:24:22 -0000      1.5
+++ src/cl_dll/c_te_legacytempents.cpp      27 Aug 2006 19:31:35 -0000
@@ -1676,7 +1676,7 @@


==== dlls/player.h ====
        default:
Remove:
                // There's no supported muzzle flash for the type specified!
<pre>int            GetImpulse( void ) const { return m_nImpulse; } </pre>
-              Assert(0);
<pre>int                                            m_nImpulse; </pre>
+              // Assert(0);
                break;
        }


==== dlls/player_command.cpp ====
</pre>
Remove:
<pre>move->m_nImpulseCommand        = ucmd->impulse;</pre>
<pre>if ( ucmd->impulse )
{
// Discard impulse commands unless the vehicle allows them.
// FIXME: UsingStandardWeapons seems like a bad filter for this. The flashlight is an impulse command, for example.
if ( !pVehicle || player->UsingStandardWeaponsInVehicle() )
{
player->m_nImpulse = ucmd->impulse;
}
}</pre>


==== game_shared/igamemovement.h ====
=== Assert( i >= 0 && i < GetNumSeq() ) ===  
Remove:
Once again this is apparently a bug in the HL2 model so looks like there's nothing to be done but comment out the assert.
<pre>int                            m_nImpulseCommand;      // Impulse command issued. </pre>


==== game_shared/usercmd.cpp ====
<pre>
Remove:
--- src/public/studio.cpp 26 Aug 2006 21:24:47 -0000      1.3
<pre>if ( to->impulse != from->impulse )
+++ src/public/studio.cpp 27 Aug 2006 19:44:53 -0000
{
@@ -783,7 +783,7 @@
                buf->WriteOneBit( 1 );
            buf->WriteUBitLong( to->impulse, 8 );
        }
        else
        {
                buf->WriteOneBit( 0 );
        } </pre>


<pre>if ( buf->ReadOneBit() )
mstudioseqdesc_t &CStudioHdr::pSeqdesc( int i ) const
        {  
{
                move->impulse = buf->ReadUBitLong( 8 );  
-       Assert( i >= 0 && i < GetNumSeq() );
        } </pre>
+      // Assert( i >= 0 && i < GetNumSeq() );
==== cl_dll/c_baseplayer.cpp ====
Remove:
<pre>DEFINE_PRED_FIELD( m_nImpulse, FIELD_INTEGER, FTYPEDESC_INSENDTABLE ), </pre>
<pre>DEFINE_FIELD( m_nImpulse, FIELD_INTEGER ), </pre>


==== cl_dll/c_baseplayer.h ====
        if (m_pVModel == NULL)
Remove:
        {
<pre>int                            m_nImpulse;</pre>
 
</pre>
 
 
=== dm_powerhouse lamps lay on the ground ===
This was first reported on the [http://forums.steampowered.com/forums/showthread.php?postid=5119212&perpage=1 Steam Forums HL2 bug list], including [http://img391.imageshack.us/my.php?image=dmpowerhouse0000dt1.jpg this screenshot].
 
Since updating the SDK the bug now occurs in my mod.


=== entitygroundcontact ===
It's been obvious for a long time that the dm_powerhouse map was broken (see [[#dm_powerhouse_lights_never_slow_down]]).  Looks like Valve was attempting to out-think broken maps, but only made things worse.  See the [[#dm_powerhouse_lights_never_slow_down]] KI for the real dm_powerhouse bug fix.  Meanwhile here's the bugfix to undo the latest SDK breakage:
It also seems that the code lets every client on the server calculate the minimum and maximum height of each animating entity and sends it to the server, while the server doesn't really need it. Each client calculates the same so it's waste of bandwidth.
<pre>
--- src/dlls/physconstraint.cpp 26 Aug 2006 21:24:31 -0000      1.4
+++ src/dlls/physconstraint.cpp 2 Sep 2006 22:50:09 -0000
@@ -437,8 +437,6 @@
                if ( Q_strlen(STRING(m_nameAttach1)) )
                {
                        Warning("Bogus constraint %s (attaches %s to %s)\n", GetDebugName(), STRING(m_nameAttach1), STRING(m_nameAttach2));
-                      info.pObjects[0] = info.pObjects[1] = NULL;
-                      return;
                }
                info.pObjects[0] = g_PhysWorldObject;
                info.massScale[0] = info.massScale[1] = 1.0f; // no mass scale on world constraint
@@ -448,8 +446,6 @@
                if ( Q_strlen(STRING(m_nameAttach2)) )
                {
                        Warning("Bogus constraint %s (attaches %s to %s)\n", GetDebugName(), STRING(m_nameAttach1), STRING(m_nameAttach2));
-                      info.pObjects[0] = info.pObjects[1] = NULL;
-                      return;
                }
                info.pObjects[1] = info.pObjects[0];
                info.pObjects[0] = g_PhysWorldObject;          // Try to make the world object consistently object0 for ease of implementation
</pre>


It's better to test these changes very good because it's possible it may break something.
=== IsFrameLocking assert ===
If you commented out the <code>AssertOnce( pModelCache->IsFrameLocking() );</code> asserts, uncommented them.  According to Jay at Valve the core is allowed to delete a GetModelPtr() pointer at any time unless you're inside the lock, therefore all of these fixes below are potential crashers.


==== game_shared/usercmd.cpp ====
<pre>
Remove:
--- mod/src/cl_dll/prediction.cpp      3 Sep 2006 01:31:56 -0000      1.5
<pre>#if defined( HL2_CLIENT_DLL )
+++ mod/src/cl_dll/prediction.cpp       16 Sep 2006 18:56:39 -0000
if ( to->entitygroundcontact.Count() != 0 )
@@ -212,6 +212,8 @@
{
void CPrediction::ShutdownPredictables( void )
buf->WriteOneBit( 1 );
{
buf->WriteShort( to->entitygroundcontact.Count() );
#if !defined( NO_ENTITY_PREDICTION )
int i;
+    MDLCACHE_CRITICAL_SECTION();
for (i = 0; i < to->entitygroundcontact.Count(); i++)
+
{
        // Transfer intermediate data from other predictables
buf->WriteUBitLong( to->entitygroundcontact[i].entindex, MAX_EDICT_BITS );
        int c = predictables->GetPredictableCount();
buf->WriteBitCoord( to->entitygroundcontact[i].minheight );
        int i;
buf->WriteBitCoord( to->entitygroundcontact[i].maxheight );
</pre>
}
 
to->entitygroundcontact.RemoveAll();
and...
}
 
else
<pre>
{
--- src/game_shared/baseplayer_shared.cpp      26 Aug 2006 21:24:36 -0000      1.28
buf->WriteOneBit( 0 );
+++ src/game_shared/baseplayer_shared.cpp      4 Sep 2006 18:53:21 -0000
}
@@ -749,6 +749,8 @@
#endif</pre>
//-----------------------------------------------------------------------------
<pre>#if defined( HL2_DLL )
bool CBasePlayer::Weapon_Switch( CBaseCombatWeapon *pWeapon, int viewmodelindex /*=0*/ )
if ( buf->ReadOneBit() )
{
{
+    MDLCACHE_CRITICAL_SECTION();
// DM: Fix negative entitygroundcontact crash, from the VDC
+
int count = buf->ReadShort();
        CBaseCombatWeapon *pLastWeapon = GetActiveWeapon();
        if ( count < 0 || count > 140 ) {
            Msg( "Ignoring strange entitygroundcontact count: %d\n", count );
        if ( BaseClass::Weapon_Switch( pWeapon, viewmodelindex ))
            return; // why can this be less than 0, Valve? change to ReadWord()???
        }
move->entitygroundcontact.SetCount( count );
 
--- src/cl_dll/c_baseanimating.cpp 2 Sep 2006 23:11:26 -0000 1.9
+++ src/cl_dll/c_baseanimating.cpp 3 Sep 2006 01:00:52 -0000
@@ -3919,6 +3919,8 @@
{
VPROF( "C_BaseAnimating::TestCollision" );
+    MDLCACHE_CRITICAL_SECTION();
+
CStudioHdr *pStudioHdr = GetModelPtr();
if (!pStudioHdr)
return false;


int i;
for (i = 0; i < move->entitygroundcontact.Count(); i++)
{
move->entitygroundcontact[i].entindex = buf->ReadUBitLong( MAX_EDICT_BITS );
move->entitygroundcontact[i].minheight = buf->ReadBitCoord( );
move->entitygroundcontact[i].maxheight = buf->ReadBitCoord( );
}
}
#endif</pre>


==== game_shared/usercmd.h ====
--- src/cl_dll/prediction.cpp 26 Aug 2006 21:24:24 -0000 1.4
Remove:
+++ src/cl_dll/prediction.cpp 3 Sep 2006 01:00:52 -0000
<pre>class CEntityGroundContact
@@ -19,6 +19,7 @@
{
#include "in_buttons.h"
public:
#include "con_nprint.h"
int entindex;
#include "hud_pdump.h"
float minheight;
+#include "datacache/imdlcache.h"
float maxheight;
};</pre>
#ifdef HL2_CLIENT_DLL
<pre>#if defined( HL2_DLL ) || defined( HL2_CLIENT_DLL )
#include "c_basehlplayer.h"
entitygroundcontact.RemoveAll();
@@ -1484,6 +1484,9 @@
#endif</pre>
//}
<pre>#if defined( HL2_DLL ) || defined( HL2_CLIENT_DLL )
entitygroundcontact = src.entitygroundcontact;
Assert( i >= 1 );
#endif</pre>
+
<pre>#if defined( HL2_DLL ) || defined( HL2_CLIENT_DLL )
+    MDLCACHE_CRITICAL_SECTION();
CUtlVector< CEntityGroundContact > entitygroundcontact;
+
#endif</pre>
while ( true )
{
// Incoming_acknowledged is the last usercmd the server acknowledged having acted upon


==== dlls/player_command.cpp ====
Remove:
<pre>#if defined (HL2_DLL)
// pull out backchannel data and move this out


int i;
--- src/dlls/player_command.cpp 26 Aug 2006 21:24:31 -0000 1.5
for (i = 0; i < cmd->entitygroundcontact.Count(); i++)
+++ src/dlls/player_command.cpp 3 Sep 2006 01:00:54 -0000
{
@@ -14,6 +14,7 @@
int entindex = cmd->entitygroundcontact[i].entindex;
#include "movehelper_server.h"
CBaseEntity *pEntity = CBaseEntity::Instance( engine->PEntityOfEntIndex( entindex) );
#include "iservervehicle.h"
if (pEntity)
#include "tier0/vprof.h"
{
+#include "datacache/imdlcache.h"
CBaseAnimating *pAnimating = pEntity->GetBaseAnimating();
if (pAnimating)
// memdbgon must be the last include file in a .cpp file!!!
{
#include "tier0/memdbgon.h"
pAnimating->SetIKGroundContactInfo( cmd->entitygroundcontact[i].minheight, cmd->entitygroundcontact[i].maxheight );
@@ -306,6 +307,8 @@
}
  //-----------------------------------------------------------------------------
}
void CPlayerMove::RunCommand ( CBasePlayer *player, CUserCmd *ucmd, IMoveHelper *moveHelper )
}
{
+    MDLCACHE_CRITICAL_SECTION();
+
StartCommand( player, ucmd );
// Set globals appropriately


#endif</pre>


==== cl_dll/input.h ====
--- src/dlls/hl2mp_dll/hl2mp_player.cpp 26 Aug 2006 21:24:35 -0000 1.43
Remove:<pre>#if defined( HL2_CLIENT_DLL )  
+++ src/dlls/hl2mp_dll/hl2mp_player.cpp 3 Sep 2006 01:00:54 -0000
        CUtlVector< CEntityGroundContact > m_EntityGroundContact;  
@@ -18,6 +18,7 @@
#endif</pre>
#include "weapon_hl2mpbase.h"
#include "grenade_satchel.h"
#include "eventqueue.h"
+#include "datacache/imdlcache.h"
#include "engine/IEngineSound.h"
#include "SoundEmitterSystem/isoundemittersystembase.h"
@@ -504,6 +505,8 @@
{
if ( IsAlive() )
{
+        MDLCACHE_CRITICAL_SECTION();
+
SetSequence ( -1 );
SetActivity( ACT_INVALID );


==== cl_dll/in_main.cpp ====
Comment out the entire function <code>CInput::AddIKGroundContactInfo</code>


== Assert ''iAddBucket >= 0 && iAddBucket < NUM_BUCKETS'' ==
--- src/game_shared/basecombatweapon_shared.cpp 26 Aug 2006 21:24:35 -0000 1.9
{{Note|This issue is fixed in the August 2006 SDK update}}
+++ src/game_shared/basecombatweapon_shared.cpp 3 Sep 2006 01:00:54 -0000
Add after <code>float flPercent = (zCoords[iCurParticle] - minZ) / (maxZ - minZ);</code>:
@@ -1287,6 +1287,7 @@
<pre>
float flSequenceDuration = 0;
// DM: WTF happens here?
if ( GetActivity() == ACT_VM_HOLSTER )
if ( (maxZ - minZ) == 0 || flPercent < 0 )
{
flPercent = 0.0f;
+        MDLCACHE_CRITICAL_SECTION();
flSequenceDuration = SequenceDuration();
}
 
 
</pre>
</pre>


== Resizing game window glitches HUD elements ==
=== AI_Activity.cpp assert on startup ===
'''Fix:'''
Just before the "// Multiplayer" line, add the following:
 
<pre>
<pre>
--- mod/src/cl_dll/game_controls/vgui_TeamFortressViewport.cpp  21 Feb 2006 01:58:36 -0000      1.6
ADD_ACTIVITY_TO_SR( ACT_MP_STAND_IDLE_PORTALGUN );
+++ mod/src/cl_dll/game_controls/vgui_TeamFortressViewport.cpp  16 Jul 2006 20:52:44 -0000
ADD_ACTIVITY_TO_SR( ACT_MP_RUN_IDLE_PORTALGUN );
@@ -152,6 +152,9 @@
ADD_ACTIVITY_TO_SR( ACT_MP_CROUCH_IDLE_PORTALGUN );
        m_pBackGround->SetZPos( -20 ); // send it to the back
ADD_ACTIVITY_TO_SR( ACT_MP_WALK_CROUCH_PORTALGUN );
        m_pBackGround->SetVisible( false );
ADD_ACTIVITY_TO_SR( ACT_MP_GESTURE_RANGE_ATTACK_PORTALGUN );
        CreateDefaultPanels();
ADD_ACTIVITY_TO_SR( ACT_MP_GESTURE_RELOAD_PORTALGUN );
+
ADD_ACTIVITY_TO_SR( ACT_MP_JUMP_PORTALGUN );
+      // reload again... this fixes the ammo display etc
+      ReloadScheme( NULL );
}
</pre>
</pre>


== Mod fails to compile with gcc 4.x ==
===  Will not compile on Linux ===
Note even if you apply these fixes, gcc 4 still won't work.  However both of these fixes seem reasonable on 3.x as well.
 
This was partially moved to [[Source SDK Known Issues#Linux_Support]]


'''Fix:''' First pass problem is a code bug - not sure if this would've shown up in gcc 3.x if Valve didn't use the horribly evil -w option, but it certainly looks like invalid code to reference a friend function without a declaration.
Here's a better fix for the Linux build breaking without -O.  Apparently using always_inline without -O intentionally breaks on GCC.  There's no real need for this though - you're better off letting the compiler optimize at will anyway.


<pre>
<pre>
--- mod/src/dlls/baseentity.h   2005/08/29 00:14:40    1.3
--- src/public/tier0/platform.h 26 Aug 2006 21:24:48 -0000      1.5
+++ mod/src/dlls/baseentity.h   2006/06/07 02:17:03
+++ src/public/tier0/platform.h 28 Aug 2006 03:20:52 -0000
@@ -325,6 +325,9 @@
@@ -310,7 +310,7 @@
  #define CREATE_PREDICTED_ENTITY( className )   \
  #else
         CBaseEntity::CreatePredictedEntityByName( className, __FUNCTION__, __LINE__ );
        #define  STDCALL
        #define  FASTCALL
-      #define FORCEINLINE                    __attribute__ ((always_inline))
+      #define  FORCEINLINE                    inline
        // GCC 3.4.1 has a bug in supporting forced inline of templated functions
        // this macro lets us not force inlining in that case
         #define  FORCEINLINE_TEMPLATE
</pre>
 
And some other issues...


+void SendProxy_Origin( const SendProp *pProp, const void *pStruct, const void *pData, DVariant *pOut, int iElement, int objectID );
<pre>
+void SendProxy_Angles( const SendProp *pProp, const void *pStruct, const void *pData, DVariant *pOut, int iElement, int objectID );
--- src/dlls/episodic/grenade_hopwire.h 2006-08-05 10:58:48.278875000 -0500
+
+++ src/dlls/episodic/grenade_hopwire.h 2006-08-13 23:09:41.000000000 -0500
//
@@ -11,7 +11,7 @@
// Base Entity. All entity types derive from this
  #endif
  //
</pre>


Looks like the only other issue was this asm change. Apparently gcc did something slightly backwards incompatible in 4.x.
#include "basegrenade_shared.h"
-#include "sprite.h"
+#include "Sprite.h"


<pre>
extern ConVar hopwire_trap;
--- src/public/mathlib.cpp      18 Feb 2005 04:45:56 -0000      1.1.1.1
+++ src/public/mathlib.cpp      11 Jun 2006 19:45:34 -0000
@@ -436,7 +436,6 @@
                "movss %%xmm0, %0 \n\t"
                : "=m" (x)
                : "m" (rroot)
-              : "%xmm0"
        );
#else
#error
</pre>
</pre>


== Case changes in player names cause chat truncation ==
<pre>
<pre>
--- mod/src/cl_dll/hl2mp/hl2mp_hud_chat.cpp     2006/02/21 01:58:38    1.3
--- src/game_shared/gamestats/ep1_gamestats.cpp 2006-08-05 10:59:06.075750000 -0500
+++ mod/src/cl_dll/hl2mp/hl2mp_hud_chat.cpp     2006/03/28 03:11:13
+++ src/game_shared/gamestats/ep1_gamestats.cpp 2006-08-13 16:10:42.000000000 -0500
@@ -422,8 +422,9 @@
@@ -5,7 +5,7 @@
        else
//=============================================================================
                line->InsertColorChange( Color( g_ColorYellow[0], g_ColorYellow[1], g_ColorYellow[2], 255 ) );


-      char *buf = static_cast<char *>( stackalloc( strlen( pmsg ) + 1 ) );
  #include "gamestats/ep1_gamestats.h"
-       wchar_t *wbuf = static_cast<wchar_t *>( stackalloc( (strlen( pmsg ) + 1 ) * sizeof(wchar_t) ) );
-#include "tier1/UtlBuffer.h"
+       char buf[4096];
+#include "tier1/utlbuffer.h"
+      wchar_t wbuf[4096];
+      Assert(strlen(pmsg) < sizeof(buf)); // otherwise message truncation will occur
        if ( buf )
        {
                float *flColor = GetClientColor( iPlayerIndex );
@@ -435,10 +436,10 @@
                buf[ min( iNameLength, MAX_PLAYER_NAME_LENGTH+31) ] = 0;
                line->InsertColorChange( Color( flColor[0], flColor[1], flColor[2], 255 ) );
                line->InsertString( buf );
-              Q_strncpy( buf, pmsg + iNameLength, strlen( pmsg ));
+              Q_strncpy(buf, pmsg + iNameLength, sizeof(buf));
                buf[ strlen( pmsg + iNameLength ) ] = '\0';
                line->InsertColorChange( Color( g_ColorYellow[0], g_ColorYellow[1], g_ColorYellow[2], 255 ) );
-              vgui::localize()->ConvertANSIToUnicode( buf, wbuf, strlen(pmsg)*sizeof(wchar_t));
+              vgui::localize()->ConvertANSIToUnicode( buf, wbuf, sizeof(wbuf));
                line->InsertString( wbuf );
                line->SetVisible( true );
                line->SetNameLength( iNameLength );


--- mod/src/tier1/stringpool.cpp        2005/02/18 04:45:59    1.1.1.1
static int g_nParseVersion = -1;
+++ mod/src/tier1/stringpool.cpp        2006/03/28 03:25:05
 
@@ -22,7 +22,7 @@
@@ -194,4 +194,4 @@
                m_nDXLevel = (int)buf.GetShort();
        }
        return bret;
-}
\ No newline at end of file
+}
</pre>
 
<pre>
--- src/game_shared/gamestats/ep1_gamestats.h    2006-08-05 10:59:06.091375000 -0500
+++ src/game_shared/gamestats/ep1_gamestats.h    2006-08-13 16:10:52.000000000 -0500
@@ -11,7 +11,7 @@
#endif
 
class CUtlBuffer;
-#include "tier1/UtlDict.h"
+#include "tier1/utldict.h"
 
#define GAMESTATS_FILE_VERSION_OLD            001
#define GAMESTATS_FILE_VERSION_OLD2            002
</pre>
 
That's all the compile bugs I encountered.  Granted I was using my mod as a basis, so there might be other compile bugs I didn't see thanks to other fixes in my mod.  If anyone else can confirm that's the complete list of fixes for a fresh SDK checkout, please do so.


  bool StrLess( const char * const &pszLeft, const char * const &pszRight )
=== Will not link fully on Linux ===
{
-      return ( Q_stricmp( pszLeft, pszRight) < 0 );
+      return ( Q_strcmp( pszLeft, pszRight) < 0 );
}


//-----------------------------------------------------------------------------
The lack of mathlib results in "undefined symbol: _Z9AngleDiffff" at runtime. There used to be a file called public/mathlib.cpp that exported that symbol, however that file is now complete gone and seemingly has no replacement. (There is a mathlib.lib which is of course useless for non-MSVC.)
--- mod/src/cl_dll/sdk/sdk_hud_chat.cpp 2006/02/21 01:58:38 1.3
+++ mod/src/cl_dll/sdk/sdk_hud_chat.cpp 2006/03/28 03:34:35
@@ -422,8 +422,9 @@
else
line->InsertColorChange( Color( g_ColorYellow[0], g_ColorYellow[1], g_ColorYellow[2], 255 ) );
   
- char *buf = static_cast<char *>( stackalloc( strlen( pmsg ) + 1  ) );
- wchar_t *wbuf = static_cast<wchar_t *>( stackalloc( (strlen( pmsg ) + 1 ) * sizeof(wchar_t) ) );
+ char buf[4096];
+ wchar_t wbuf[4096];
+    assert(strlen(pmsg) < sizeof(buf)); // otherwise message truncation will occur
if ( buf )
{
float *flColor = GetClientColor( iPlayerIndex );
@@ -435,10 +436,10 @@
buf[ min( iNameLength, MAX_PLAYER_NAME_LENGTH+31) ] = 0;
line->InsertColorChange( Color( flColor[0], flColor[1], flColor[2], 255 ) );
line->InsertString( buf );
- Q_strncpy( buf, pmsg + iNameLength, strlen( pmsg ));
+ Q_strncpy(buf, pmsg + iNameLength, sizeof(buf));
buf[ strlen( pmsg + iNameLength ) ] = '\0';
line->InsertColorChange( Color( g_ColorYellow[0], g_ColorYellow[1], g_ColorYellow[2], 255 ) );
- vgui::localize()->ConvertANSIToUnicode( buf, wbuf, strlen(pmsg)*sizeof(wchar_t));
+ vgui::localize()->ConvertANSIToUnicode( buf, wbuf, sizeof(wbuf));
line->InsertString( wbuf );
line->SetVisible( true );
line->SetNameLength( iNameLength );
</pre>


{{note|I've never actually tested the patch to sdk_hud_chat.cpp, but the code is identical to hl2mp_hud_chat.cpp so it should work.}}
Update: this was apparently an oversight - Valve intended to switch everything to libs...


== dm_powerhouse lights never slow down ==
'''Fix:'''
'''Workaround:''' Really this should be fixed in the map, but good luck waiting on that to happen. In the mean time here's a code patch for any such mapping errors:
Download these [http://www.fileplanet.com/hosteddl.aspx?/hst/b/l/bloodyk0/linuxlibs.zip linuxlibs] that [[User:Mdurand | Mike Durand]] provided (careful not to overwrite your existing Makefile), and apply [http://developer.valvesoftware.com/cgi-bin/bugzilla/attachment.cgi?id=1&action=view this patch].


<pre>
=== GameInfo.txt issues ===
--- mod/src/dlls/physconstraint.cpp    2005/03/26 17:44:28    1.2
+++ mod/src/dlls/physconstraint.cpp    2006/03/06 02:45:47
@@ -727,6 +727,16 @@
                for ( int i = 0; i < 2; i++ )
                {
                        info.pObjects[i]->WorldToLocal( &ballsocket.constraintPosition[i], GetAbsOrigin() );
+            // HACKHACK - the mapper forgot to put in some sane physics damping (dm_powerhouse)
+            float damping, adamping;
+            info.pObjects[i]->GetDamping(&damping, &adamping);
+            if (damping < .2f) {
+                damping = .2f;
+            }
+            if (adamping < .2f) {
+                adamping = .2f;
+            }
+            info.pObjects[i]->SetDamping(&damping, &damping);
                }
                GetBreakParams( ballsocket.constraint, info );
                ballsocket.constraint.torqueLimit = 0;
</pre>


== Wall Boosting Exploit ==
This was moved to [[Source SDK Known Issues#SDK_Launcher_Issues]]


Hi, everyone would of no doubt noticed that running against a wall(strafing and moving forward works best) makes you run really fast. If anyone has played kreedz climbing yet(I used to code for it) you might of noticed moving against walls is jerky. I think when I was adding some things to the movement I made the server and client disagree on what speed the player is moving at. Has anyone sound why players in source do this? where the boost might be clamped to normal levels? If so I'd love to know, and it would be good to know for bg2 as well, people who play it complain a lot of it
=== Animations are jittery ===
as well(just the boost, not client prediction jerks).
Open <code>cl_dll/c_baseentity.cpp</code> and remove the following code:
<pre>if ( !IsSelfAnimating() )
{
        m_flAnimTime = engine->GetLastTimeStamp();     
}</pre>


'''Fix Provided by [[User:Omega|Tony "omega" Sergi]]'''
=== HL2Gamerules() ===
 
When you are running a multiplayer mod, a call to <code>HL2Gamerules()</code>, without checking if the object valid, will probably crash. This happens because the function tries to static_cast <code>g_pGamerules</code> to the class <code>CHalfLife2</code>. However the gamerules of multiplay_gamerules.cpp or hl2dm_gamerules.cpp is used. As a result the casting fails and any calls to it crash. To fix this, you need to add a check to every call to this function.
mod/game_shared/gamemovement.cpp
Line 1374


=== Bullet impact sounds do not play to clients ===
In the <code>PlayImpactSound</code> function in <code>cl_dll/fx_impact.cpp</code>, replace:
<pre>
C_BaseEntity::EmitSound( filter, NULL, pbulletImpactSoundName, pdata->soundhandles.bulletImpact, &vecOrigin );
</pre>
with:
<pre>
<pre>
void CGameMovement::Accelerate( Vector& wishdir, float wishspeed, float
C_BaseEntity::EmitSound( filter, NULL, pbulletImpactSoundName, &vecOrigin );
accel )
</pre>
{
This can also be observed as hearing the <code>WateryDeath.Warn</code> soundscript entry played while shooting at models with the "Weapon" surfaceprop when hosting a listen server in a map using level-specific soundscripts.
int i;
float addspeed, accelspeed, currentspeed;


// This gets overridden because some games (CSPort) want to allow dead (observer) players
=== use of non-standard _stricmp in portable code block ===
// to be able to move around.
if ( !CanAccelerate() )
return;


//omega; WALLSTRAFE FIX
Can someone confirm whether this patch works with a fresh SDK?  I've removed Valve's inappropriate Makefile defines (see -Wall section) which may be what revealed this, or it might just be another Linux compilation DOA.
:This stuffs up vc2003 again, and chucks up 1000's of warnings if you #ifdef WIN32 or #ifdef LINUX - only use this fix if you are in need of it! --[[User:Amckern|Amckern]] 23:22, 2 Oct 2006 (PDT)


// See if we are changing direction a bit
<pre>
// currentspeed = mv->m_vecVelocity.Dot(wishdir);
--- public/tier1/strtools.h    26 Aug 2006 21:30:57 -0000      1.1
+++ public/tier1/strtools.h    27 Aug 2006 03:33:54 -0000
@@ -98,7 +98,7 @@
inline char*  V_strrchr  ( const char *s,    char c            ) { return strrchr( s, c );      }
inline int    V_strcmp  ( const char *s1,    const char *s2    ) { return strcmp( s1, s2 );    }
inline int    V_wcscmp  ( const wchar_t *s1, const wchar_t *s2  ) { return wcscmp( s1, s2 );    }
-inline int    V_stricmp  ( const char *s1,    const char *s2    ) { return _stricmp( s1, s2 );  }
+inline int    V_stricmp  ( const char *s1,    const char *s2    ) { return strcasecmp( s1, s2 ); }
inline char*  V_strstr  ( const char *s1,    const char *search ) { return strstr( s1, search ); }
inline char*  V_strupr  ( char *start )                          { return strupr( start );      }
inline char*  V_strlower ( char *start )                          { return strlwr( start );     }
</pre>


currentspeed = sqrt( DotProduct(mv->m_vecVelocity, mv->m_vecVelocity) );
== Missing activity ACT_HL2MP_GESTURE_RELOAD_CROSSBOW ==
//omega; END WALLSTRAFE FIX
This error happens because Valve never made crossbow reload animations for
the playermodels, but told it to use ACT_HL2MP_GESTURE_RELOAD_CROSSBOW in
the acttable anyway.


// Reduce wishspeed by the amount of veer.
<pre>--- sourcecode/trunk/game_shared/hl2mp/weapon_crossbow.cpp (revision 336)
</pre>
+++ sourcecode/trunk/game_shared/hl2mp/weapon_crossbow.cpp (revision 357)
@@ -485,5 +485,5 @@
{ ACT_HL2MP_WALK_CROUCH,          ACT_HL2MP_WALK_CROUCH_CROSSBOW,          false },
{ ACT_HL2MP_GESTURE_RANGE_ATTACK, ACT_HL2MP_GESTURE_RANGE_ATTACK_CROSSBOW, false },
- { ACT_HL2MP_GESTURE_RELOAD,      ACT_HL2MP_GESTURE_RELOAD_CROSSBOW,      false },
+ { ACT_HL2MP_GESTURE_RELOAD,      ACT_HL2MP_GESTURE_RELOAD_AR2,            false },
{ ACT_HL2MP_JUMP,                ACT_HL2MP_JUMP_CROSSBOW,                false },
};</pre>


== bin/tier0_i486.so fails to shut down when using threads ==
== "Extra App ID set to 211, but no SteamAppID" while debugging ==
It looks like this would be fixed if Valve would recompile bin/tier0_i486.so with the -fuse-cxa-atexit gcc option. I can't wait for Valve to fix this, so instead:
This issue happens when mounting multiple GCFs. The fix is to mount appid's in the negative. ie: -320 instead of 320.


'''Workaround:'''  In the mean time what I've done with my mod is add an <code>alarm(10);</code> to the bottom of <code>void CServerGameDLL::DLLShutdown(void)</code> so that if bin/tier0_i486.so fails to exit, it will be killed.
== Bot physics/hitbox not accurate ==
<pre>
--- src/dlls/sdk/sdk_bot_temp.cpp      3 Sep 2006 02:18:03 -0000      1.3
+++ src/dlls/sdk/sdk_bot_temp.cpp      3 Sep 2006 02:36:29 -0000
@@ -52,6 +52,13 @@


== GNU crasher for maps with broken ladders ==
        QAngle                  m_ForwardAngle;
'''Fix:''' Valve's code is invalid but compiles on MSVC due to its D.W.I.M. philosophy.  The following patch is required:
        QAngle                  m_LastAngles;
+
+    virtual void PhysicsSimulate() {
+        BaseClass::PhysicsSimulate();
+
+        // Since this isn't called for bots.. call it here
+        UpdateVPhysicsPosition(m_vNewVPhysicsPosition, m_vNewVPhysicsVelocity, gpGlobals->frametime);
+    }
};
 
LINK_ENTITY_TO_CLASS( sdk_bot, CSDKBot );
</pre>
 
Bot physics/hitbox not accurate: '''happens also on HL2MP mod''' with bots. Any fix for this?
 
== Invalid Combine Ball vphysics ==
This is an old bug, but still exists in the new SDK.  This might be the last of the vphysics bugs?


<pre>
<pre>
--- mod/src/game_shared/func_ladder.cpp 2005/06/11 22:14:32    1.2
--- dlls/hl2_dll/prop_combine_ball.h    2006-08-27 18:22:56.255500000 -0500
+++ mod/src/game_shared/func_ladder.cpp 2006/02/12 19:43:25
+++ dlls/hl2_dll/prop_combine_ball.h    2006-08-27 18:22:56.255500000 -0500
@@ -87,7 +87,7 @@
@@ -119,6 +119,8 @@
                                m_vecPlayerMountPositionBottom.GetZ(),
 
                                bottomtrace.m_pEnt
        // Pow!
                                        ?
        void DoExplosion( );
-                                       UTIL_VarArgs( "%s/%s", bottomtrace.m_pEnt->GetClassname(), bottomtrace.m_pEnt->GetEntityName() )
+      void DoExplosion_internal();
+                                       UTIL_VarArgs( "%s/%s", bottomtrace.m_pEnt->GetClassname(), STRING(bottomtrace.m_pEnt->GetEntityName()) )
+    int OnTakeDamage(const CTakeDamageInfo &info);
                                        :
 
                                        "NULL" );
        void StartAnimating( void );
                }
        void StopAnimating( void );
@@ -99,7 +99,7 @@
 
                                m_vecPlayerMountPositionTop.GetZ(),
 
                                toptrace.m_pEnt
 
                                        ?
--- dlls/hl2_dll/prop_combine_ball.cpp  2006-08-27 18:24:17.364875000 -0500
-                                       UTIL_VarArgs( "%s/%s", toptrace.m_pEnt->GetClassname(), toptrace.m_pEnt->GetEntityName() )
+++ dlls/hl2_dll/prop_combine_ball.cpp  2006-08-27 18:24:17.364875000 -0500
+                                       UTIL_VarArgs( "%s/%s", toptrace.m_pEnt->GetClassname(), STRING(toptrace.m_pEnt->GetEntityName()) )
@@ -974,7 +974,18 @@
                                        :
//------------------------------------------------------------------------------
                                        "NULL" );
// Pow!
                }
//------------------------------------------------------------------------------
-void CPropCombineBall::DoExplosion( )
+void CPropCombineBall::DoExplosion() {
+   // don't call DoExplosion() directly since we might be in a vphysics callback
+    TakeDamage(CTakeDamageInfo(this, this, 1, DMG_PREVENT_PHYSICS_FORCE));
+}
+
+int CPropCombineBall::OnTakeDamage(const CTakeDamageInfo &info) {
+    // now we're safely no longer in a vphysics callback
+    DoExplosion_internal();
+    return 0;
+}
+
+void CPropCombineBall::DoExplosion_internal()
{
        // Tell the respawner to make a new one
        if ( GetSpawner() )
</pre>
</pre>


== sdkshaders: fix for spaces in path ==
== Wasted entitygroundcontact ==
Issue: Any attempt to compile the SDK shaders for a mod with spaces in the path name results in failure:
It also seems that the code lets every client on the server calculate the minimum and maximum height of each animating entity and sends it to the server, while the server doesn't really need it. Each client calculates the same so it's waste of bandwidth.


(ie: "C:\Program Files\Steam\SteamApps\SourceMods\MODNAME\src\src\sdkshaders")
It's better to test these changes very good because it's possible it may break something.


This is due to the fact that the perl scripts and bat files have not been properly modified to handle spaces in the path.
Note: Why not instead of compleatly removing it, having only 1 player to calculate it ? (if its a listen server then its the local player, if its a dedicated one what about the player who has been on the most :P/any random player ?) --[[User:Filip|Filip]] 06:43, 6 December 2012 (PST)


==== game_shared/usercmd.cpp ====
Remove:
<pre>#if defined( HL2_CLIENT_DLL )
if ( to->entitygroundcontact.Count() != 0 )
{
buf->WriteOneBit( 1 );
buf->WriteShort( to->entitygroundcontact.Count() );
int i;
for (i = 0; i < to->entitygroundcontact.Count(); i++)
{
buf->WriteUBitLong( to->entitygroundcontact[i].entindex, MAX_EDICT_BITS );
buf->WriteBitCoord( to->entitygroundcontact[i].minheight );
buf->WriteBitCoord( to->entitygroundcontact[i].maxheight );
}
to->entitygroundcontact.RemoveAll();
}
else
{
buf->WriteOneBit( 0 );
}
#endif</pre>
<pre>#if defined( HL2_DLL )
if ( buf->ReadOneBit() )
{
// DM: Fix negative entitygroundcontact crash, from the VDC
int count = buf->ReadShort();
        if ( count < 0 || count > 140 ) {
            Msg( "Ignoring strange entitygroundcontact count: %d\n", count );
            return; // why can this be less than 0, Valve? change to ReadWord()???
        }
move->entitygroundcontact.SetCount( count );


'''Fix:''' [[User:Visualphoenix|Ray "VisualPhoenix" Barbiero]] has provided the following patches:
int i;
 
for (i = 0; i < move->entitygroundcontact.Count(); i++)
{{note|These patches have been tested on paths with and without spaces.}}
{
 
move->entitygroundcontact[i].entindex = buf->ReadUBitLong( MAX_EDICT_BITS );
=== updateshaders.pl ===
move->entitygroundcontact[i].minheight = buf->ReadBitCoord( );
<pre>
move->entitygroundcontact[i].maxheight = buf->ReadBitCoord( );
--- mod/src/devtools/bin/updateshaders.pl 2005-07-14 09:58:54.000000000 -0500
}
+++ mod/src/devtools/bin/updateshaders.pl 2005-10-11 23:42:36.000000000 -0500
}
@@ -105,7 +105,7 @@
#endif</pre>
{
 
$xboxswitch = "-xbox ";
==== game_shared/usercmd.h ====
}
Remove:
- print MAKEFILE "\t$g_SourceDir\\devtools\\bin\\perl.exe $g_SourceDir\\devtools\\bin\\" . $shadertype . "_prep.pl $xboxswitch -shaderoutputdir $shaderoutputdir -source \"$g_SourceDir\" $shadername\n";
<pre>class CEntityGroundContact
+ print MAKEFILE "\t\"$g_SourceDir\\devtools\\bin\\perl.exe\" \"$g_SourceDir\\devtools\\bin\\" . $shadertype . "_prep.pl\" $xboxswitch -shaderoutputdir $shaderoutputdir -source \"$g_SourceDir\" $shadername\n";
{
my $filename;
public:
if( $shadertype eq "fxc" )
int entindex;
{
float minheight;
@@ -199,14 +199,14 @@
float maxheight;
# We only generate inc files for fxc and vsh files.
};</pre>
if( $g_xbox )
<pre>#if defined( HL2_DLL ) || defined( HL2_CLIENT_DLL )
{
entitygroundcontact.RemoveAll();
- print MAKEFILE " $shadertype" . "tmp_xbox\\" . $shaderbase . "\.inc";
#endif</pre>
+ print MAKEFILE " \"$shadertype" . "tmp_xbox\\" . $shaderbase . "\.inc\"";
<pre>#if defined( HL2_DLL ) || defined( HL2_CLIENT_DLL )
}
entitygroundcontact = src.entitygroundcontact;
else
#endif</pre>
{
<pre>#if defined( HL2_DLL ) || defined( HL2_CLIENT_DLL )
- print MAKEFILE " $shadertype" . "tmp9\\" . $shaderbase . "\.inc";
CUtlVector< CEntityGroundContact > entitygroundcontact;
+ print MAKEFILE " \"$shadertype" . "tmp9\\" . $shaderbase . "\.inc\"";
#endif</pre>
}
}
- print MAKEFILE " $shaderoutputdir\\$shadertype\\$shaderbase\.vcs";
+ print MAKEFILE " \"$shaderoutputdir\\$shadertype\\$shaderbase\.vcs\"";
}
print MAKEFILE "\n\n";
@@ -221,11 +221,11 @@
# We only generate inc files for fxc and vsh files.
if( $g_xbox )
{
- print MAKEFILE "\tdel /f /q $shadertype" . "tmp_xbox\\" . $shaderbase . "\.inc\n";
+ print MAKEFILE "\tdel /f /q \"$shadertype" . "tmp_xbox\\" . $shaderbase . "\.inc\"\n";
}
else
{
- print MAKEFILE "\tdel /f /q $shadertype" . "tmp9\\" . $shaderbase . "\.inc\n";
+ print MAKEFILE "\tdel /f /q \"$shadertype" . "tmp9\\" . $shaderbase . "\.inc\"\n";
}
}
print MAKEFILE "\tdel /f /q \"$shaderoutputdir\\$shadertype\\$shaderbase\.vcs\"\n";
</pre>
 
=== buildshaders.bat ===
<pre>
--- mod/src/materialsystem/stdshaders/buildshaders.bat 2005-07-14 10:00:36.000000000 -0500
+++ mod/src/materialsystem/stdshaders/buildshaders.bat 2005-10-11 23:01:08.000000000 -0500
@@ -36,7 +36,7 @@
REM ****************
:set_xbox_args
set xbox_args=-xbox
-set targetdir=%vproject%\shaders_xbox
+set targetdir="%vproject%\shaders_xbox"
goto build_shaders
@@ -45,8 +45,8 @@
REM ****************
:set_mod_args
-if not exist %sourcesdk%\bin\shadercompile.exe goto NoShaderCompile
-set ChangeToDir=%sourcesdk%\bin
+if not exist "%sourcesdk%\bin\shadercompile.exe" goto NoShaderCompile
+set ChangeToDir="%sourcesdk%\bin"
if /i "%4" NEQ "-source" goto NoSourceDirSpecified
set SrcDirBase=%~5
@@ -75,7 +75,7 @@
:NoShaderCompile
echo -
-echo - ERROR: shadercompile.exe doesn't exist in %sourcesdk%\bin
+echo - ERROR: shadercompile.exe doesn't exist in "%sourcesdk%\bin"
echo -
goto end
@@ -129,7 +129,7 @@
REM ****************
REM Execute distributed process on work/build list
REM ****************
-"%SrcDirBase%\devtools\bin\perl" "%SrcDirBase%\materialsystem\stdshaders\runvmpi.pl" %xbox_args% -changetodir "%ChangeToDir%" %SDKArgs%
+"%SrcDirBase%\devtools\bin\perl" "%SrcDirBase%\materialsystem\stdshaders\runvmpi.pl" %xbox_args% -changetodir %ChangeToDir% %SDKArgs%
REM ****************
REM Copy the generated files to the output dir.
</pre>


=== runvmpi.pl ===
==== dlls/player_command.cpp ====
<pre>
Remove:
--- mod/src/materialsystem/stdshaders/runvmpi.pl 2005-07-14 10:00:34.000000000 -0500
<pre>#if defined (HL2_DLL)
+++ mod/src/materialsystem/stdshaders/runvmpi.pl 2005-10-11 22:34:02.000000000 -0500
// pull out backchannel data and move this out
@@ -41,7 +41,7 @@
$shaderpath =~ s,/,\\,g;
chdir $changeToDir;
-$cmdToRun = "shadercompile.exe $noMPI $xboxFlag -shaderpath $shaderpath -mpi_workercount 32 -allowdebug $gameFlag";
+$cmdToRun = "shadercompile.exe $noMPI $xboxFlag -shaderpath \"$shaderpath\" -mpi_workercount 32 -allowdebug $gameFlag";
system $cmdToRun;
# other options..
</pre>


=== build_sample_shaders.bat ===
int i;
<pre>
for (i = 0; i < cmd->entitygroundcontact.Count(); i++)
--- mod/src/sdkshaders/build_sample_shaders.bat 2005-07-14 09:57:02.000000000 -0500
{
+++ mod/src/sdkshaders/build_sample_shaders.bat 2005-10-11 23:38:18.000000000 -0500
int entindex =  cmd->entitygroundcontact[i].entindex;
@@ -9,7 +9,7 @@
CBaseEntity *pEntity = CBaseEntity::Instance( engine->PEntityOfEntIndex( entindex) );
if (pEntity)
{
rem **** Call the batch files to build our stuff.
CBaseAnimating *pAnimating = pEntity->GetBaseAnimating();
-call ..\materialsystem\stdshaders\buildshaders.bat sdk_shaders -game "%__GameDir%" -source ..
if (pAnimating)
+call ..\materialsystem\stdshaders\buildshaders.bat sdk_shaders -game "%__GameDir%" -source .\..
{
goto end
pAnimating->SetIKGroundContactInfo( cmd->entitygroundcontact[i].minheight, cmd->entitygroundcontact[i].maxheight );
</pre>
}
}
}


== vphysics patch from Jay at Valve ==
#endif</pre>
{{Note|This issue has been fixed in the August 2006 SDK}}
In addition to the vphysics bug/feature listed below where ShouldCollide can cause it to engage Physical Mayhem, an additional requirement for vphysics is this - again quoted from [[User:Jay Stelly|Jay]].  Need to figure out where in the code to patch in some docs on this - in the meantime:


<pre>Calling UTIL_Remove() or delete on an entity during a callback may corrupt vphysics.</pre>
==== cl_dll/input.h ====
Remove:<pre>#if defined( HL2_CLIENT_DLL )  
        CUtlVector< CEntityGroundContact > m_EntityGroundContact;
#endif</pre>


The following patch uses an assert to document this requirement from the closed-source side of things:
==== cl_dll/in_main.cpp ====
Comment out the entire function <code>CInput::AddIKGroundContactInfo</code>


== Resizing game window glitches HUD elements ==
'''Fix:'''
<pre>
<pre>
--- mod/src/dlls/physics.cpp   2005/10/16 16:26:25    1.4
--- mod/src/cl_dll/game_controls/vgui_TeamFortressViewport.cpp 21 Feb 2006 01:58:36 -0000      1.6
+++ mod/src/dlls/physics.cpp   2006/05/29 17:39:03
+++ mod/src/cl_dll/game_controls/vgui_TeamFortressViewport.cpp 16 Jul 2006 20:52:44 -0000
@@ -141,6 +141,7 @@
@@ -152,6 +152,9 @@
 
         m_pBackGround->SetZPos( -20 ); // send it to the back
         // IPhysicsCollisionSolver
         m_pBackGround->SetVisible( false );
        int            ShouldCollide( IPhysicsObject *pObj0, IPhysicsObject *pObj1, void *pGameData0, void *pGameData1 );
         CreateDefaultPanels();
+      int            ShouldCollide_Default(IPhysicsObject *pObj0, IPhysicsObject *pObj1, void *pGameData0, void *pGameData1);
         int            ShouldSolvePenetration( IPhysicsObject *pObj0, IPhysicsObject *pObj1, void *pGameData0, void *pGameData1, float dt );
        bool    ShouldFreezeObject( IPhysicsObject *pObject ) { return true; }
         int            AdditionalCollisionChecksThisTick( int currentChecksDone )
@@ -482,6 +483,21 @@
}
 
int CCollisionEvent::ShouldCollide( IPhysicsObject *pObj0, IPhysicsObject *pObj1, void *pGameData0, void *pGameData1 )
+{
+      int x0 = ShouldCollide_Default(pObj0, pObj1, pGameData0, pGameData1);
+#if !defined(NDEBUG)
+      int x1 = ShouldCollide_Default(pObj1, pObj0, pGameData1, pGameData0);
+      if ( x0 != x1 )
+      {
+              Assert(0 && "ShouldCollide must return the same value regardless of the order of the two objects that are passed in");
+              ShouldCollide_Default(pObj0, pObj1, pGameData0, pGameData1);
+              ShouldCollide_Default(pObj1, pObj0, pGameData1, pGameData0);
+      }
+#endif
+      return x0;
+}
+
+
+int CCollisionEvent::ShouldCollide_Default( IPhysicsObject *pObj0, IPhysicsObject *pObj1, void *pGameData0, void *pGameData1 )
+       // reload again... this fixes the ammo display etc
  {
+      ReloadScheme( NULL );
        CallbackContext check(this);
  }
</pre>
</pre>


Here's another for Jay. I haven't tested this yet, but what's the worst that it could do? :)
== Mod fails to compile with gcc 4.x ==
{{Note|Even if you apply these fixes, gcc 4 still won't work. However both of these fixes seem reasonable on 3.x as well.}}
 
'''Fix:''' First pass problem is a code bug - not sure if this would've shown up in gcc 3.x if Valve didn't use the horribly evil -w option, but it certainly looks like invalid code to reference a friend function without a declaration.


<pre>
<pre>
--- ./mod/src/game_shared/physics_main_shared.cpp      2005/02/18 04:45:54     1.1.1.1
--- mod/src/dlls/baseentity.h  2005/08/29 00:14:40     1.3
+++ ./mod/src/game_shared/physics_main_shared.cpp      2005/11/04 02:01:53
+++ mod/src/dlls/baseentity.h  2006/06/07 02:17:03
@@ -371,6 +371,8 @@
@@ -325,6 +325,9 @@
         return link;
#define CREATE_PREDICTED_ENTITY( className )  \
}
         CBaseEntity::CreatePredictedEntityByName( className, __FUNCTION__, __LINE__ );


+static touchlink_t *g_pNextLink = NULL;
+void SendProxy_Origin( const SendProp *pProp, const void *pStruct, const void *pData, DVariant *pOut, int iElement, int objectID );
+void SendProxy_Angles( const SendProp *pProp, const void *pStruct, const void *pData, DVariant *pOut, int iElement, int objectID );
+
+
  //-----------------------------------------------------------------------------
  //
  // Purpose:
  // Base Entity.  All entity types derive from this
// Input  : *link -
  //
@@ -380,6 +382,10 @@
{
        if ( link )
        {
+        if ( link == g_pNextLink )
+        {
+            g_pNextLink = link->nextLink;
+        }
                --linksallocated;
        }
        g_EdictTouchLinks.Free( link );
@@ -442,7 +448,9 @@
  //-----------------------------------------------------------------------------
void CBaseEntity::PhysicsCheckForEntityUntouch( void )
{
-      touchlink_t *link, *nextLink;
+      Assert( g_pNextLink == NULL );
+
+    touchlink_t *link;
 
        touchlink_t *root = ( touchlink_t * )GetDataObject( TOUCHLINK );
        if ( root )
@@ -453,7 +461,7 @@
                link = root->nextLink;
                while ( link != root )
                {
-                      nextLink = link->nextLink;
+                      g_pNextLink = link->nextLink;
 
                        // these touchlinks are not polled. The ents are touching due to an outside
                        // system that will add/delete them as necessary (vphysics in this case)
@@ -476,7 +484,7 @@
                                }
                        }
 
-                      link = nextLink;
+                      link = g_pNextLink;
                }
 
                g_bCleanupDatObject = saveCleanup;
@@ -489,6 +497,8 @@
                }
        }
 
+    g_pNextLink = NULL;
+
        SetCheckUntouch( false );
}
</pre>
</pre>


== Getting the SDK to work under -Wall -Werror ==
Looks like the only other issue was this asm change.  Apparently gcc did something slightly backwards incompatible in 4.x.
If you're a professional programmer with any familiarity with GNU then the first thing you probably did was attempt to compile the SDK with -Wall -Werror, and were then disappointed by all the violations in Valve's code out of the box.  Here's a list of fixes to make this work.  (This list is by no means complete - I fixed many problems before I realized this would be something worth wiki-ing.)


I just noticed Valve uses -fpermissive!  *barf*!  So, if anyone out there had already noticed that, I now have a work in progress to fix all the scary hacks that -fpermissive would normally error on... coming soon. --[[User:Bloodykenny|Bloodykenny]] 20:46, 25 Oct 2005 (PDT)
<pre>
 
--- src/public/mathlib.cpp      18 Feb 2005 04:45:56 -0000      1.1.1.1
=== offsetof errors ===
+++ src/public/mathlib.cpp      11 Jun 2006 19:45:34 -0000
Unfortunately, these are due to a bug in gcc, noted here: [http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16618 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16618].  It was fixed in 3.4.2, but I haven't tried upgrading to 3.4.2 yet, as it is likely to break the linkage to Valve's .so files.
@@ -436,7 +436,6 @@
 
                "movss %%xmm0, %0 \n\t"
Update - I'm now using gcc 3.4.4 and everything seems fine.  I had to rebuild glibc and such in a sandbox, but it was no big deal, and it fixes the offsetof errors.  Will update again if I ever see an issue, but it's been a while now with no problem. --[[User:Bloodykenny|Bloodykenny]] 20:44, 25 Oct 2005 (PDT)
                : "=m" (x)
 
                : "m" (rroot)
=== Downcast explicitly ===
-              : "%xmm0"
 
        );
One should always [http://www.camtp.uni-mb.si/books/Thinking-in-C++/Chapter08.html#Index572 downcast] explicitly.  This squelches useful warnings, and self-documents your intent to downcast.
#else
#error
</pre>


== Case changes in player names cause chat truncation ==
<pre>
<pre>
--- mod/src/public/tier0/fasttimer.h    2005/06/11 22:14:36     1.2
--- mod/src/cl_dll/hl2mp/hl2mp_hud_chat.cpp    2006/02/21 01:58:38     1.3
+++ mod/src/public/tier0/fasttimer.h    2005/09/14 00:25:19
+++ mod/src/cl_dll/hl2mp/hl2mp_hud_chat.cpp    2006/03/28 03:11:13
@@ -253,7 +253,7 @@
@@ -422,8 +422,9 @@
inline void CCycleCount::Init( float initTimeMsec )
{
        if ( g_ClockSpeedMillisecondsMultiplier > 0 )
-              m_Int64 = initTimeMsec / g_ClockSpeedMillisecondsMultiplier;
+              m_Int64 = int64(initTimeMsec / g_ClockSpeedMillisecondsMultiplier);
         else
         else
                 m_Int64 = 0;
                 line->InsertColorChange( Color( g_ColorYellow[0], g_ColorYellow[1], g_ColorYellow[2], 255 ) );
}
</pre>


=== Poor abused templates ===
-      char *buf = static_cast<char *>( stackalloc( strlen( pmsg ) + 1  ) );
* This code fixes some badly used Memory Templates, and provides compatibility with Unix based systems.
-      wchar_t *wbuf = static_cast<wchar_t *>( stackalloc( (strlen( pmsg ) + 1 ) * sizeof(wchar_t) ) );
<pre>
+       char buf[4096];
--- mod/src/public/tier1/utlmemory.h    2005/02/18 04:45:58    1.1.1.1
+       wchar_t wbuf[4096];
+++ mod/src/public/tier1/utlmemory.h    2005/09/14 00:24:15
+       Assert(strlen(pmsg) < sizeof(buf)); // otherwise message truncation will occur
@@ -293,7 +293,7 @@
        if ( buf )
{
        Assert( num > 0 );
 
-      if (IsExternallyAllocated())
+    if (CUtlMemory<T>::IsExternallyAllocated())
         {
         {
                 // Can't grow a buffer whose memory was externally allocated
                 float *flColor = GetClientColor( iPlayerIndex );
                Assert(0);
@@ -435,10 +436,10 @@
@@ -349,7 +349,7 @@
                buf[ min( iNameLength, MAX_PLAYER_NAME_LENGTH+31) ] = 0;
        if (m_nAllocationCount >= num)
                line->InsertColorChange( Color( flColor[0], flColor[1], flColor[2], 255 ) );
                 return;
                line->InsertString( buf );
-              Q_strncpy( buf, pmsg + iNameLength, strlen( pmsg ));
+              Q_strncpy(buf, pmsg + iNameLength, sizeof(buf));
                buf[ strlen( pmsg + iNameLength ) ] = '\0';
                line->InsertColorChange( Color( g_ColorYellow[0], g_ColorYellow[1], g_ColorYellow[2], 255 ) );
-              vgui::localize()->ConvertANSIToUnicode( buf, wbuf, strlen(pmsg)*sizeof(wchar_t));
+              vgui::localize()->ConvertANSIToUnicode( buf, wbuf, sizeof(wbuf));
                line->InsertString( wbuf );
                line->SetVisible( true );
                 line->SetNameLength( iNameLength );
 
--- mod/src/tier1/stringpool.cpp        2005/02/18 04:45:59    1.1.1.1
+++ mod/src/tier1/stringpool.cpp        2006/03/28 03:25:05
@@ -22,7 +22,7 @@


-      if (IsExternallyAllocated())
bool StrLess( const char * const &pszLeft, const char * const &pszRight )
+    if (CUtlMemory<T>::IsExternallyAllocated())
  {
        {
-      return ( Q_stricmp( pszLeft, pszRight) < 0 );
                // Can't grow a buffer whose memory was externally allocated
+       return ( Q_strcmp( pszLeft, pszRight) < 0 );
                Assert(0);
  }
@@ -376,7 +376,7 @@
template< class T >
void CUtlMemory<T>::Purge()
  {
-      if (!IsExternallyAllocated())
+   if (!CUtlMemory<T>::IsExternallyAllocated())
        {
                if (m_pMemory)
                {
@@ -495,7 +495,7 @@
  {
        Assert( num > 0 );


-       if (IsExternallyAllocated())
//-----------------------------------------------------------------------------
+   if (CUtlMemory<T>::IsExternallyAllocated())
--- mod/src/cl_dll/sdk/sdk_hud_chat.cpp 2006/02/21 01:58:38 1.3
        {
+++ mod/src/cl_dll/sdk/sdk_hud_chat.cpp 2006/03/28 03:34:35
                // Can't grow a buffer whose memory was externally allocated
@@ -422,8 +422,9 @@
                Assert(0);
else
@@ -551,7 +551,7 @@
line->InsertColorChange( Color( g_ColorYellow[0], g_ColorYellow[1], g_ColorYellow[2], 255 ) );
        if (CUtlMemory<T>::m_nAllocationCount >= num)
                return;
- char *buf = static_cast<char *>( stackalloc( strlen( pmsg ) + 1  ) );
- wchar_t *wbuf = static_cast<wchar_t *>( stackalloc( (strlen( pmsg ) + 1 ) * sizeof(wchar_t) ) );
+ char buf[4096];
+ wchar_t wbuf[4096];
+    assert(strlen(pmsg) < sizeof(buf)); // otherwise message truncation will occur
if ( buf )
{
float *flColor = GetClientColor( iPlayerIndex );
@@ -435,10 +436,10 @@
buf[ min( iNameLength, MAX_PLAYER_NAME_LENGTH+31) ] = 0;
line->InsertColorChange( Color( flColor[0], flColor[1], flColor[2], 255 ) );
line->InsertString( buf );
- Q_strncpy( buf, pmsg + iNameLength, strlen( pmsg ));
+ Q_strncpy(buf, pmsg + iNameLength, sizeof(buf));
buf[ strlen( pmsg + iNameLength ) ] = '\0';
line->InsertColorChange( Color( g_ColorYellow[0], g_ColorYellow[1], g_ColorYellow[2], 255 ) );
- vgui::localize()->ConvertANSIToUnicode( buf, wbuf, strlen(pmsg)*sizeof(wchar_t));
+ vgui::localize()->ConvertANSIToUnicode( buf, wbuf, sizeof(wbuf));
line->InsertString( wbuf );
line->SetVisible( true );
line->SetNameLength( iNameLength );
</pre>


-      if (IsExternallyAllocated())
{{note|I've never actually tested the patch to sdk_hud_chat.cpp, but the code is identical to hl2mp_hud_chat.cpp so it should work.}}
+    if (CUtlMemory<T>::IsExternallyAllocated())
        {
                // Can't grow a buffer whose memory was externally allocated
                Assert(0);
@@ -579,7 +579,7 @@
template< class T, int nAlignment >
void CUtlMemoryAligned<T, nAlignment>::Purge()
{
-      if (!IsExternallyAllocated())
+    if (!CUtlMemory<T>::IsExternallyAllocated())
        {
                if (m_pMemoryBase)
                {
</pre>


=== Missing EOF linefeeds ===
== dm_powerhouse lights never slow down ==
 
'''Workaround:''' Really this should be fixed in the map, but good luck waiting on that to happen. In the mean time here's a code patch for any such mapping errors:
First you'll need to `cvs rm -f mod/src/dlls/worker_scientist.h` since that file is blank, unused, and will make the script below not run. :)
 
Then run:


<pre>
<pre>
#!/usr/bin/perl -w
--- mod/src/dlls/physconstraint.cpp    2005/03/26 17:44:28    1.2
 
+++ mod/src/dlls/physconstraint.cpp    2006/03/06 02:45:47
use strict;
@@ -727,6 +727,16 @@
foreach (`find mod -name *.cpp -or -name *.h`) {
                for ( int i = 0; i < 2; i++ )
    chomp;
                {
    open(F, "+<", $_) or die "$! on $_";
                        info.pObjects[i]->WorldToLocal( &ballsocket.constraintPosition[i], GetAbsOrigin() );
    seek(F, -1, 2) or die "$! on $_";
+            // HACKHACK - the mapper forgot to put in some sane physics damping (dm_powerhouse)
    my $c;
+           float damping, adamping;
    read(F, $c, 1) or die "$! on $_";
+            info.pObjects[i]->GetDamping(&damping, &adamping);
    if ($c ne "\n") {
+            if (damping < .2f) {
        print "$_\n";
+                damping = .2f;
        print(F "\n");
+            }
    }
+            if (adamping < .2f) {
}
+                adamping = .2f;
</pre>
+            }
+            info.pObjects[i]->SetDamping(&damping, &damping);
                }
                GetBreakParams( ballsocket.constraint, info );
                ballsocket.constraint.torqueLimit = 0;
</pre>


=== Garbage after #endifs ===
== Wall Boosting Exploit ==


A common mistake in the SDK, obviously trivial to fix, but here for your conveniance:
Hi, everyone would of no doubt noticed that running against a wall(strafing and moving forward works best) makes you run really fast. If anyone has played kreedz climbing yet(I used to code for it) you might of noticed moving against walls is jerky. I think when I was adding some things to the movement I made the server and client disagree on what speed the player is moving at. Has anyone sound why players in source do this? where the boost might be clamped to normal levels? If so I'd love to know, and it would be good to know for bg2 as well, people who play it complain a lot of it
as well(just the boost, not client prediction jerks).


<pre>
'''Fix Provided by [[User:Omega|Tony "omega" Sergi]]'''
diff -w -u -r1.3 ai_basenpc.cpp
--- dlls/ai_basenpc.cpp 2005/06/11 22:14:26    1.3
+++ dlls/ai_basenpc.cpp 2005/09/10 18:16:13
@@ -8450,7 +8450,7 @@


        return shotDir;
mod/game_shared/gamemovement.cpp
}
Line 1374
-#endif HL2_DLL
+#endif // HL2_DLL


//-----------------------------------------------------------------------------
<pre>
void CGameMovement::Accelerate( Vector& wishdir, float wishspeed, float
accel )
{
int i;
float addspeed, accelspeed, currentspeed;


// This gets overridden because some games (CSPort) want to allow dead (observer) players
// to be able to move around.
if ( !CanAccelerate() )
return;


//omega; WALLSTRAFE FIX


diff -w -u -r1.1.1.1 npc_BaseZombie.cpp
// See if we are changing direction a bit
--- dlls/hl2_dll/npc_BaseZombie.cpp    2005/02/18 04:45:52    1.1.1.1
// currentspeed = mv->m_vecVelocity.Dot(wishdir);
+++ dlls/hl2_dll/npc_BaseZombie.cpp    2005/09/10 20:57:40
@@ -1582,7 +1582,7 @@


#ifdef DEBUG_ZOMBIES
currentspeed = sqrt( DotProduct(mv->m_vecVelocity, mv->m_vecVelocity) );
                        DevMsg("Wandering\n");
//omega; END WALLSTRAFE FIX
-#endif+
+#endif


                        // Just lost track of our enemy.
// Reduce wishspeed by the amount of veer.
                        // Wander around a bit so we don't look like a dingus.
</pre>






diff -w -u -r1.2 memalloc.h
== GNU crasher for maps with broken ladders ==
--- public/tier0/memalloc.h    2005/02/19 18:24:26    1.2
'''Fix:''' Valve's code is invalid but compiles on MSVC due to its D.W.I.M. philosophy.  The following patch is required:
+++ public/tier0/memalloc.h    2005/09/10 05:12:39
@@ -133,6 +133,6 @@
#define MEM_ALLOC_CREDIT_CLASS()
  #define MEM_ALLOC_CLASSNAME(type) NULL
 
-#endif !STEAM && NO_MALLOC_OVERRIDE
+#endif // !STEAM && NO_MALLOC_OVERRIDE
 
#endif /* TIER0_MEMALLOC_H */
 
 
 
</pre>
 
 
=== snprintf strangeness ===
 
There are several conflicting snprintf defines and other snprintf porting bugs in the SDK, which need to be fixed for Werror compatibility:


<pre>
<pre>
diff -w -u -r1.1.1.1 interface.h
--- mod/src/game_shared/func_ladder.cpp 2005/06/11 22:14:32     1.2
--- public/tier1/interface.h    2005/02/18 04:45:58     1.1.1.1
+++ mod/src/game_shared/func_ladder.cpp 2006/02/12 19:43:25
+++ public/tier1/interface.h    2005/09/10 06:09:25
@@ -87,7 +87,7 @@
@@ -33,8 +33,6 @@
                                m_vecPlayerMountPositionBottom.GetZ(),
                                bottomtrace.m_pEnt
                                        ?
-                                      UTIL_VarArgs( "%s/%s", bottomtrace.m_pEnt->GetClassname(), bottomtrace.m_pEnt->GetEntityName() )
+                                      UTIL_VarArgs( "%s/%s", bottomtrace.m_pEnt->GetClassname(), STRING(bottomtrace.m_pEnt->GetEntityName()) )
                                        :
                                        "NULL" );
                }
@@ -99,7 +99,7 @@
                                m_vecPlayerMountPositionTop.GetZ(),
                                toptrace.m_pEnt
                                        ?
-                                      UTIL_VarArgs( "%s/%s", toptrace.m_pEnt->GetClassname(), toptrace.m_pEnt->GetEntityName() )
+                                      UTIL_VarArgs( "%s/%s", toptrace.m_pEnt->GetClassname(), STRING(toptrace.m_pEnt->GetEntityName()) )
                                        :
                                        "NULL" );
                }
</pre>


#define HMODULE void *
== sdkshaders: fix for spaces in path ==
#define GetProcAddress dlsym
Issue: Any attempt to compile the SDK shaders for a mod with spaces in the path name results in failure:
-
-#define _snprintf snprintf
#endif


// TODO: move interface.cpp into tier0 library.
(ie: "C:\Program Files\Steam\SteamApps\SourceMods\MODNAME\src\src\sdkshaders")


This is due to the fact that the perl scripts and bat files have not been properly modified to handle spaces in the path.




diff -w -u -r1.1.1.1 interface.cpp
'''Fix:''' [[User:Visualphoenix|Ray "VisualPhoenix" Barbiero]] has provided the following patches:
--- tier1/interface.cpp 2005/02/18 04:45:59    1.1.1.1
+++ tier1/interface.cpp 2005/09/10 21:18:20
@@ -191,7 +191,7 @@
                Q_snprintf( str, sizeof(str), "%s.dll", szAbsoluteModuleName );
                hDLL = LoadLibrary( str );
#elif _LINUX
-              _snprintf( str, sizeof(str), "%s_i486.so", szAbsoluteModuleName );
+              Q_snprintf( str, sizeof(str), "%s_i486.so", szAbsoluteModuleName );
                hDLL = dlopen(str, RTLD_NOW);
#endif
</pre>


=== Broken comments ===
{{note|These patches have been tested on paths with and without spaces.}}
 
Ending a // comment with \ is just begging for trouble...


=== updateshaders.pl ===
<pre>
<pre>
diff -w -u -r1.1.1.1 collisionutils.cpp
--- mod/src/devtools/bin/updateshaders.pl 2005-07-14 09:58:54.000000000 -0500
--- public/collisionutils.cpp  2005/02/18 04:45:56    1.1.1.1
+++ mod/src/devtools/bin/updateshaders.pl 2005-10-11 23:42:36.000000000 -0500
+++ public/collisionutils.cpp  2005/09/10 23:59:09
@@ -105,7 +105,7 @@
@@ -2299,7 +2299,7 @@
{
 
$xboxswitch = "-xbox ";
        return true;
}
}
- print MAKEFILE "\t$g_SourceDir\\devtools\\bin\\perl.exe $g_SourceDir\\devtools\\bin\\" . $shadertype . "_prep.pl $xboxswitch -shaderoutputdir $shaderoutputdir -source \"$g_SourceDir\" $shadername\n";
-
+ print MAKEFILE "\t\"$g_SourceDir\\devtools\\bin\\perl.exe\" \"$g_SourceDir\\devtools\\bin\\" . $shadertype . "_prep.pl\" $xboxswitch -shaderoutputdir $shaderoutputdir -source \"$g_SourceDir\" $shadername\n";
+/*
my $filename;
//--------------------------------------------------------------------------
if( $shadertype eq "fxc" )
// Purpose:
{
//
@@ -199,14 +199,14 @@
@@ -2314,7 +2314,7 @@
# We only generate inc files for fxc and vsh files.
//    0-----2
if( $g_xbox )
//
{
//--------------------------------------------------------------------------
- print MAKEFILE " $shadertype" . "tmp_xbox\\" . $shaderbase . "\.inc";
-
+ print MAKEFILE " \"$shadertype" . "tmp_xbox\\" . $shaderbase . "\.inc\"";
+*/
}
  //-----------------------------------------------------------------------------
else
  // Purpose: find the minima and maxima of the 3 given values
{
  //-----------------------------------------------------------------------------
- print MAKEFILE " $shadertype" . "tmp9\\" . $shaderbase . "\.inc";
</pre>
+ print MAKEFILE " \"$shadertype" . "tmp9\\" . $shaderbase . "\.inc\"";
 
}
=== First big pass at -Wall and consistent code ===
}
Convert stricmp, _alloca etc to Q_stricmp, stackalloc versions. Fix basetype declarations like 0 to 0.0f when appropriate. Comply with STL min/max. Comply with POSIX/BSD naming inline (and appropriate #ifdefing) in all cases where a cross-platform compatibility utility function does not yet exist.
- print MAKEFILE " $shaderoutputdir\\$shadertype\\$shaderbase\.vcs";
 
+ print MAKEFILE " \"$shaderoutputdir\\$shadertype\\$shaderbase\.vcs\"";
You'll need to remove the inappropriate -D defines in the Makefile for the str/printf/alloc things. Those are now fixed by using the correct functions in the code to begin with, however I don't have a patch for the Makefile included in the file below.
  }
 
  print MAKEFILE "\n\n";
I have uploaded this file for BloodKenny at -
   
@@ -221,11 +221,11 @@
# We only generate inc files for fxc and vsh files.
if( $g_xbox )
{
- print MAKEFILE "\tdel /f /q $shadertype" . "tmp_xbox\\" . $shaderbase . "\.inc\n";
+ print MAKEFILE "\tdel /f /q \"$shadertype" . "tmp_xbox\\" . $shaderbase . "\.inc\"\n";
}
else
{
- print MAKEFILE "\tdel /f /q $shadertype" . "tmp9\\" . $shaderbase . "\.inc\n";
+ print MAKEFILE "\tdel /f /q \"$shadertype" . "tmp9\\" . $shaderbase . "\.inc\"\n";
}
}
print MAKEFILE "\tdel /f /q \"$shaderoutputdir\\$shadertype\\$shaderbase\.vcs\"\n";
</pre>


http://www.nigredostudios.com/temp/patch_hl2_sdk_wall_sanity.txt
=== buildshaders.bat ===
 
<pre>
http://www.noballs.org/downloads/patch_hl2_sdk_wall_sanity.txt
--- mod/src/materialsystem/stdshaders/buildshaders.bat 2005-07-14 10:00:36.000000000 -0500
 
+++ mod/src/materialsystem/stdshaders/buildshaders.bat 2005-10-11 23:01:08.000000000 -0500
http://www.ammahls.com/downloads/patch_hl2_sdk_wall_sanity.txt
@@ -36,7 +36,7 @@
 
REM ****************
Right click save as - amckern
:set_xbox_args
 
set xbox_args=-xbox
Second pass - fix unreliable and error/warning prone min/max/clamp macros with STL calls and normal templatization:
-set targetdir=%vproject%\shaders_xbox
 
+set targetdir="%vproject%\shaders_xbox"
http://aoa.gamemod.net/patch-warning-minmax.txt
goto build_shaders
 
== BotPutInServer linker failures ==
'''Fix:''' This is fixed in the latest (February 12th or later) SDK from Valve by adding the files to the build:
@@ -45,8 +45,8 @@
 
REM ****************
<pre>
:set_mod_args
--- mod/src/dlls/hl_sdk.vcproj  2005-08-04 17:01:08.000000000 -0500
+++ mod/src/dlls/hl_sdk.vcproj  2006-02-12 13:52:33.000000000 -0600
-if not exist %sourcesdk%\bin\shadercompile.exe goto NoShaderCompile
@@ -3374,6 +3375,12 @@
-set ChangeToDir=%sourcesdk%\bin
                                Name="HL2MP"
+if not exist "%sourcesdk%\bin\shadercompile.exe" goto NoShaderCompile
                                Filter="">
+set ChangeToDir="%sourcesdk%\bin"
                                <File
+                                       RelativePath=".\hl2mp_dll\hl2mp_bot_temp.cpp">
if /i "%4" NEQ "-source" goto NoSourceDirSpecified
+                              </File>
set SrcDirBase=%~5
+                               <File
@@ -75,7 +75,7 @@
+                                      RelativePath=".\hl2mp_dll\hl2mp_bot_temp.h">
+                              </File>
:NoShaderCompile
+                               <File
echo -
                                        RelativePath=".\hl2mp_dll\hl2mp_client.cpp">
-echo - ERROR: shadercompile.exe doesn't exist in %sourcesdk%\bin
                                </File>
+echo - ERROR: shadercompile.exe doesn't exist in "%sourcesdk%\bin"
                                <File
  echo -
</pre>
  goto end
 
== Server: Host_Error: SV_PackEntity: SendTable_Encode returned false (ent %d). ==
@@ -129,7 +129,7 @@
Here %d will be replaced by whatever the entity number is that caused the error. No single entity is allowed to write more than 2KB to the network stream. This error happens when an entity overflows that buffer.
REM ****************
 
REM Execute distributed process on work/build list
'''Fix:'''  If you need an entity to occasionally transmit more than 2K of data, you will need to split it up into multiple entities, each transmitting part of the data. You should ensure of course that no entity -consistently- transmits 2K of data, as it would bog down your network.  Some entities might want to send a large amount on map initialization etc, however. Another possible workaround for some situations (may not always be possible), is to update data a little bit each frame, so that no one frame has a big change.
  REM ****************
-"%SrcDirBase%\devtools\bin\perl" "%SrcDirBase%\materialsystem\stdshaders\runvmpi.pl" %xbox_args% -changetodir "%ChangeToDir%" %SDKArgs%
+"%SrcDirBase%\devtools\bin\perl" "%SrcDirBase%\materialsystem\stdshaders\runvmpi.pl" %xbox_args% -changetodir %ChangeToDir% %SDKArgs%
   
REM ****************
  REM Copy the generated files to the output dir.
</pre>


== Server: The client's health variable is pointlessly sent across the wire twice. ==
=== runvmpi.pl ===
 
<pre>
'''Fix:''' [[Diff And Patch]]
--- mod/src/materialsystem/stdshaders/runvmpi.pl 2005-07-14 10:00:34.000000000 -0500
 
+++ mod/src/materialsystem/stdshaders/runvmpi.pl 2005-10-11 22:34:02.000000000 -0500
* There is no line 1888 within c_baseplayer.cpp in the stock MP, or SP SDK's - do i just tack the code onto the end (The BaseClass::SetGroundEntity(ground); is also not there) --[[User:Amckern|Amckern]] 22:46, 5 Nov 2005 (PST)
@@ -41,7 +41,7 @@
 
$shaderpath =~ s,/,\\,g;
Ah, sorry. That patch was against an already-modified file, not a fresh SDK. The SetGroundEntity is part of my mod. :) Yes tack it onto the end. After you do so, post the diff back here! --[[User:Bloodykenny|Bloodykenny]] 09:25, 12 Nov 2005 (PST)
chdir $changeToDir;
   
-$cmdToRun = "shadercompile.exe $noMPI $xboxFlag -shaderpath $shaderpath -mpi_workercount 32 -allowdebug $gameFlag";
+$cmdToRun = "shadercompile.exe $noMPI $xboxFlag -shaderpath \"$shaderpath\" -mpi_workercount 32 -allowdebug $gameFlag";
  system $cmdToRun;
   
  # other options..
</pre>


=== build_sample_shaders.bat ===
<pre>
<pre>
--- mod/src/cl_dll/c_baseplayer.cpp    2005/06/30 05:54:09    1.6
--- mod/src/sdkshaders/build_sample_shaders.bat 2005-07-14 09:57:02.000000000 -0500
+++ mod/src/cl_dll/c_baseplayer.cpp    2005/07/16 21:33:33
+++ mod/src/sdkshaders/build_sample_shaders.bat 2005-10-11 23:38:18.000000000 -0500
@@ -1888,3 +1888,7 @@
@@ -9,7 +9,7 @@
    BaseClass::SetGroundEntity(ground);
}
rem **** Call the batch files to build our stuff.
-call ..\materialsystem\stdshaders\buildshaders.bat sdk_shaders -game "%__GameDir%" -source ..
+call ..\materialsystem\stdshaders\buildshaders.bat sdk_shaders -game "%__GameDir%" -source .\..
goto end
</pre>


+
+int C_BasePlayer::GetHealth() const {
+    return g_PR->GetHealth(entindex());
+}




== Getting the SDK to work under -Wall -Werror ==
If you're a professional programmer with any familiarity with GNU then the first thing you probably did was attempt to compile the SDK with -Wall -Werror, and were then disappointed by all the violations in Valve's code out of the box.  Here's a list of fixes to make this work.  (This list is by no means complete - I fixed many problems before I realized this would be something worth wiki-ing.)


--- mod/src/cl_dll/c_baseplayer.h      2005/07/11 03:28:41    1.9
I just noticed Valve uses -fpermissive!  *barf*!  So, if anyone out there had already noticed that, I now have a work in progress to fix all the scary hacks that -fpermissive would normally error on... coming soon. --[[User:Bloodykenny|Bloodykenny]] 20:46, 25 Oct 2005 (PDT)
+++ mod/src/cl_dll/c_baseplayer.h      2005/07/16 21:05:31
@@ -103,7 +103,7 @@


        // Data handlers
=== offsetof errors ===
        virtual bool    IsPlayer( void ) const { return true; };
These are due to [http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16618 a bug in gcc].  It was fixed in 3.4.2, and gcc 3.4.4 is now known to work fine and fixes the issue.
-      virtual int            GetHealth() const { return m_iHealth; };
+      virtual int            GetHealth() const;


        // observer mode
=== Downcast explicitly ===
        virtual int                    GetObserverMode() const;


One should always [http://www.camtp.uni-mb.si/books/Thinking-in-C++/Chapter08.html#Index572 downcast] explicitly.  This squelches useful warnings, and self-documents your intent to downcast.


<pre>
--- mod/src/public/tier0/fasttimer.h    2005/06/11 22:14:36    1.2
+++ mod/src/public/tier0/fasttimer.h    2005/09/14 00:25:19
@@ -253,7 +253,7 @@
inline void CCycleCount::Init( float initTimeMsec )
{
        if ( g_ClockSpeedMillisecondsMultiplier > 0 )
-              m_Int64 = initTimeMsec / g_ClockSpeedMillisecondsMultiplier;
+              m_Int64 = int64(initTimeMsec / g_ClockSpeedMillisecondsMultiplier);
        else
                m_Int64 = 0;
}
</pre>


--- mod/src/dlls/player.cpp    2005/07/12 07:38:04     1.33
=== Poor abused templates ===
+++ mod/src/dlls/player.cpp    2005/07/22 00:45:48
* This code fixes some badly used Memory Templates, and provides compatibility with Unix based systems.
@@ -58,6 +58,8 @@
<pre>
  #include "nav_mesh.h"
--- mod/src/public/tier1/utlmemory.h    2005/02/18 04:45:58     1.1.1.1
#include "env_zoom.h"
+++ mod/src/public/tier1/utlmemory.h    2005/09/14 00:24:15
@@ -293,7 +293,7 @@
  {
        Assert( num > 0 );


+#include "player_resource.h"
-      if (IsExternallyAllocated())
+
+   if (CUtlMemory<T>::IsExternallyAllocated())
#ifdef HL2_DLL
        {
#include "combine_mine.h"
                // Can't grow a buffer whose memory was externally allocated
#include "weapon_physcannon.h"
                Assert(0);
@@ -4295,6 +4297,9 @@
@@ -349,7 +349,7 @@
         m_lastx = m_lasty = 0;
         if (m_nAllocationCount >= num)
                return;


        m_lastNavArea = NULL;
-      if (IsExternallyAllocated())
+
+   if (CUtlMemory<T>::IsExternallyAllocated())
+    // update now so that our new health gets sent with the respawn notice
        {
+   g_pPlayerResource->SetPlayerHealth(entindex(), m_iHealth);
                // Can't grow a buffer whose memory was externally allocated
 
                Assert(0);
         /// @todo Do this once per round instead of once per player
@@ -376,7 +376,7 @@
         if (TheNavMesh)
template< class T >
void CUtlMemory<T>::Purge()
{
-       if (!IsExternallyAllocated())
+    if (!CUtlMemory<T>::IsExternallyAllocated())
         {
                if (m_pMemory)
                {
@@ -495,7 +495,7 @@
{
         Assert( num > 0 );


-      if (IsExternallyAllocated())
+    if (CUtlMemory<T>::IsExternallyAllocated())
        {
                // Can't grow a buffer whose memory was externally allocated
                Assert(0);
@@ -551,7 +551,7 @@
        if (CUtlMemory<T>::m_nAllocationCount >= num)
                return;


-      if (IsExternallyAllocated())
+    if (CUtlMemory<T>::IsExternallyAllocated())
        {
                // Can't grow a buffer whose memory was externally allocated
                Assert(0);
@@ -579,7 +579,7 @@
template< class T, int nAlignment >
void CUtlMemoryAligned<T, nAlignment>::Purge()
{
-      if (!IsExternallyAllocated())
+    if (!CUtlMemory<T>::IsExternallyAllocated())
        {
                if (m_pMemoryBase)
                {
</pre>
=== Missing EOF linefeeds ===
First you'll need to `cvs rm -f mod/src/dlls/worker_scientist.h` since that file is blank, unused, and will make the script below not run. :)


--- mod/src/dlls/player_resource.cpp    2005/06/19 02:54:04    1.5
Then run:
+++ mod/src/dlls/player_resource.cpp    2005/07/22 00:44:35
@@ -85,6 +85,13 @@
}


//-----------------------------------------------------------------------------
<pre>
+// Purpose: Sets health value for a particular client (used to set on spawn so the data will be sent synchronously)
#!/usr/bin/perl -w
+//-----------------------------------------------------------------------------
 
+void CPlayerResource::SetPlayerHealth(int entindex, int health) {
use strict;
+    m_iHealth.Set(entindex, health);
foreach (`find mod -name *.cpp -or -name *.h`) {
+}
    chomp;
+
    open(F, "+<", $_) or die "$! on $_";
+//-----------------------------------------------------------------------------
    seek(F, -1, 2) or die "$! on $_";
// Purpose: The Player resource is always transmitted to clients
    my $c;
//-----------------------------------------------------------------------------
    read(F, $c, 1) or die "$! on $_";
int CPlayerResource::UpdateTransmitState()
    if ($c ne "\n") {
        print "$_\n";
        print(F "\n");
    }
}
</pre>


=== Garbage after #endifs ===


A common mistake in the SDK, obviously trivial to fix, but here for your conveniance:


--- mod/src/dlls/player_resource.h      2005/06/18 21:16:29     1.3
<pre>
+++ mod/src/dlls/player_resource.h      2005/07/22 00:42:57
diff -w -u -r1.3 ai_basenpc.cpp
@@ -26,6 +26,8 @@
--- dlls/ai_basenpc.cpp 2005/06/11 22:14:26     1.3
        virtual void UpdatePlayerData( void );
+++ dlls/ai_basenpc.cpp 2005/09/10 18:16:13
        virtual int  UpdateTransmitState(void);
@@ -8450,7 +8450,7 @@


+    void SetPlayerHealth(int entindex, int health);
        return shotDir;
+
  }
  protected:
-#endif HL2_DLL
        // Data for each player that's propagated to all clients
+#endif // HL2_DLL
        // Stored in individual arrays so they can be sent down via datatables
</pre>


Then you can remove the SendPropInt and RecvPropInt for CBasePlayer::m_iHealth. (However, I don't have a patch for that yet since it's not a backwards-compatible change.  Will post a patch once I've done so, if no on else beats me to it.)
  //-----------------------------------------------------------------------------


== Server: The client's team membership is pointlessly sent across the wire twice. ==


Similar to the above KI, but for another variable.  Also this fixes an SDK crasher, but according to Yahn at Valve, Steam will be fixed soon to not do that.


'''Fix:''' [[Diff And Patch]]
diff -w -u -r1.1.1.1 npc_BaseZombie.cpp
 
--- dlls/hl2_dll/npc_BaseZombie.cpp     2005/02/18 04:45:52     1.1.1.1
<pre>
+++ dlls/hl2_dll/npc_BaseZombie.cpp     2005/09/10 20:57:40
--- mod/src/dlls/team.cpp       2005/06/11 22:14:30     1.2
@@ -1582,7 +1582,7 @@
+++ mod/src/dlls/team.cpp       2006/05/29 18:58:52    1.3
 
@@ -19,6 +19,7 @@
  #ifdef DEBUG_ZOMBIES
  //-----------------------------------------------------------------------------
                        DevMsg("Wandering\n");
void SendProxy_PlayerList( const SendProp *pProp, const void *pStruct, const void *pData, DVariant *pOut, int iElement, int objectID )
-#endif+
{
+#endif
+   Assert(0);
 
        CTeam *pTeam = (CTeam*)pData;
                        // Just lost track of our enemy.
                        // Wander around a bit so we don't look like a dingus.
 


        // If this assertion fails, then SendProxyArrayLength_PlayerArray must have failed.
@@ -31,8 +32,11 @@


int SendProxyArrayLength_PlayerArray( const void *pStruct, int objectID )
diff -w -u -r1.2 memalloc.h
{
--- public/tier0/memalloc.h    2005/02/19 18:24:26    1.2
-       CTeam *pTeam = (CTeam*)pStruct;
+++ public/tier0/memalloc.h    2005/09/10 05:12:39
-       return pTeam->m_aPlayers.Count();
@@ -133,6 +133,6 @@
+    // The RecvPropArray2 in general was seemingly broken in the May 25th-ish core engine update.
#define MEM_ALLOC_CREDIT_CLASS()
+    // The CTeam in particular was certainly broken at that time, however, thankfully it doesn't
  #define MEM_ALLOC_CLASSNAME(type) NULL
+   // serve any important purpose.
+    // For backwards compatibility with old client, we disable it, rather than remove it entirely.
+    return 0;
  }
</pre>


== Server: weapon_citizensuitcase Assert on startup ==
-#endif !STEAM && NO_MALLOC_OVERRIDE
+#endif // !STEAM && NO_MALLOC_OVERRIDE


'''Fix:''' Install copy of the SP SDK, then copy the scripts/ directory over
#endif /* TIER0_MEMALLOC_H */


== Server: Some bullet weapons set to do 0 damage. ==


'''Fix:''' Need to edit their AddAmmoType which are strangely set to 0 for some reason.


== Server: Some projectile weapons set to do 0 damage. ==
</pre>


'''Fix:''' Need to edit their source files and set a damage.


== Client: --- Missing Vgui material vgui/steam/games/icon_cz ==
=== snprintf strangeness ===


'''Fix:''' These files are used in the currently inaccessible Friends IM client. Create 4 vmts in their places of any design to remove the error.
There are several conflicting snprintf defines and other snprintf porting bugs in the SDK, which need to be fixed for Werror compatibility:
 
<pre>
diff -w -u -r1.1.1.1 interface.h
--- public/tier1/interface.h    2005/02/18 04:45:58    1.1.1.1
+++ public/tier1/interface.h    2005/09/10 06:09:25
@@ -33,8 +33,6 @@
 
#define HMODULE void *
#define GetProcAddress dlsym
-
-#define _snprintf snprintf
#endif
 
// TODO: move interface.cpp into tier0 library.


* materials\VGUI\steam\games\icon_cs.vmt
* materials\VGUI\steam\games\icon_dod.vmt
* materials\VGUI\steam\games\icon_hl2mp.vmt
* materials\VGUI\servers\icon_secure_deny.vmt


Here's a patch to create files for the first three. (I don't see the icon_secure_deny.vmt error, so didn't create anything for it.)


<pre>
diff -w -u -r1.1.1.1 interface.cpp
--- materials/VGUI/steam/games/icon_cs.vmt      1969-12-31 18:00:00.000000000 -0600
--- tier1/interface.cpp 2005/02/18 04:45:59    1.1.1.1
+++ materials/VGUI/steam/games/icon_cs.vmt      2005-07-28 01:54:17.000000000 -0500
+++ tier1/interface.cpp 2005/09/10 21:18:20
@@ -0,0 +1 @@
@@ -191,7 +191,7 @@
+"UnlitGeneric" {}
                Q_snprintf( str, sizeof(str), "%s.dll", szAbsoluteModuleName );
--- materials/VGUI/steam/games/icon_dod.vmt    1969-12-31 18:00:00.000000000 -0600
                hDLL = LoadLibrary( str );
+++ materials/VGUI/steam/games/icon_dod.vmt    2005-07-28 01:54:19.000000000 -0500
#elif _LINUX
@@ -0,0 +1 @@
-               _snprintf( str, sizeof(str), "%s_i486.so", szAbsoluteModuleName );
+"UnlitGeneric" {}
+               Q_snprintf( str, sizeof(str), "%s_i486.so", szAbsoluteModuleName );
--- materials/VGUI/steam/games/icon_hl2mp.vmt  1969-12-31 18:00:00.000000000 -0600
                hDLL = dlopen(str, RTLD_NOW);
+++ materials/VGUI/steam/games/icon_hl2mp.vmt  2005-07-28 01:54:15.000000000 -0500
#endif
@@ -0,0 +1 @@
+"UnlitGeneric" {}
</pre>
</pre>


'''Fix2:''' Add clear to your rc file in cfg (extract from gcf if non-existant)
=== Broken comments ===


== Server: The crossbow causes an assertion failure. ==
Ending a // comment with \ is just begging for trouble...


'''Fix:''' Comment out ai_activity.cpp line 53. This doesn't appear to be something that can be fixed in code?
<pre>
 
diff -w -u -r1.1.1.1 collisionutils.cpp
== Server? Client?: RL explosion invisible ==
--- public/collisionutils.cpp  2005/02/18 04:45:56    1.1.1.1
+++ public/collisionutils.cpp  2005/09/10 23:59:09
@@ -2299,7 +2299,7 @@


Per http://www.chatbear.com/board.plm?a=viewthread&t=970,1107153392,30132&id=786504&b=4991&v=flatold
        return true;
}
-
+/*
//--------------------------------------------------------------------------
// Purpose:
//
@@ -2314,7 +2314,7 @@
//    0-----2
//
//--------------------------------------------------------------------------
-
+*/
//-----------------------------------------------------------------------------
// Purpose: find the minima and maxima of the 3 given values
//-----------------------------------------------------------------------------
</pre>


'''Fix:''' in c_te_explosion.cpp
=== First big pass at -Wall and consistent code ===
Convert stricmp, _alloca etc to Q_stricmp, stackalloc versions.  Fix basetype declarations like 0 to 0.0f when appropriate.  Comply with STL min/max.  Comply with POSIX/BSD naming inline (and appropriate #ifdefing) in all cases where a cross-platform compatibility utility function does not yet exist.


<pre>
You'll need to remove the inappropriate -D defines in the Makefile for the str/printf/alloc things.  Those are now fixed by using the correct functions in the code to begin with, however I don't have a patch for the Makefile included in the file below.
--- mod/src/cl_dll/c_te_explosion.cpp Mon Mar 24 00:46:49 2003
 
+++ mod/src/cl_dll/c_te_explosion.cpp Mon Mar 24 00:48:38 2003
I have uploaded this file for BloodKenny at -
@@ -241,15 +241,18 @@
 
const Vector* normal = NULL, unsigned char materialType = 'C' )
http://www.nigredostudios.com/temp/patch_hl2_sdk_wall_sanity.txt
{
 
// Major hack to access singleton object for doing this event (simulate receiving network message)
Right click save as - amckern
+ Assert( pos );
 
+
Second pass - fix unreliable and error/warning prone min/max/clamp macros with STL calls and normal templatization:
+ __g_C_TEExplosion.m_vecOrigin = *pos;
__g_C_TEExplosion.m_nModelIndex = modelindex;
__g_C_TEExplosion.m_fScale = scale;
__g_C_TEExplosion.m_nFrameRate = framerate;
__g_C_TEExplosion.m_nFlags = flags;
- __g_C_TEExplosion.m_vecNormal = *normal;
+ __g_C_TEExplosion.m_vecNormal = normal ? *normal : Vector( 0, 0, 1 );
__g_C_TEExplosion.m_chMaterialType = materialType;
__g_C_TEExplosion.m_nRadius = radius;
__g_C_TEExplosion.m_nMagnitude = magnitude;


__g_C_TEExplosion.PostDataUpdate( DATA_UPDATE_CREATED );
http://aoa.gamemod.net/patch-warning-minmax.txt


}
== Server: Host_Error: SV_PackEntity: SendTable_Encode returned false (ent %d). ==
</pre>
Here %d will be replaced by whatever the entity number is that caused the error.  No single entity is allowed to write more than 2KB to the network stream.  This error happens when an entity overflows that buffer.


== sv_gravity is not associated with physics gravity==
'''Fix:'''  If you need an entity to occasionally transmit more than 2K of data, you will need to split it up into multiple entities, each transmitting part of the data.  You should ensure of course that no entity -consistently- transmits 2K of data, as it would bog down your network.  Some entities might want to send a large amount on map initialization etc, however.  Another possible workaround for some situations (may not always be possible), is to update data a little bit each frame, so that no one frame has a big change.
When gravity is changed, the physics gravity isn't updated


'''Fix:'''  
== Server: The client's health variable is pointlessly sent across the wire twice. ==
In movevars_shared.cpp:
 
inline void UpdatePhysicsGravity(float gravity)
'''Fix:''' [[Diff And Patch]]
{
 
if(physenv)
* There is no line 1888 within c_baseplayer.cpp in the stock MP, or SP SDK's - do i just tack the code onto the end (The BaseClass::SetGroundEntity(ground); is also not there) --[[User:Amckern|Amckern]] 22:46, 5 Nov 2005 (PST)
physenv->SetGravity(Vector(0,0,-gravity));
 
}
Ah, sorry. That patch was against an already-modified file, not a fresh SDK. The SetGroundEntity is part of my mod. :) Yes tack it onto the end. After you do so, post the diff back here! --[[User:Bloodykenny|Bloodykenny]] 09:25, 12 Nov 2005 (PST)
static void GravityChanged_Callback( ConVar *var, const char *pOldString )
 
{
<pre>
#ifndef CLIENT_DLL
--- mod/src/cl_dll/c_baseplayer.cpp    2005/06/30 05:54:09    1.6
UpdatePhysicsGravity(var->GetFloat());
+++ mod/src/cl_dll/c_baseplayer.cpp    2005/07/16 21:33:33
if(gpGlobals->mapname!=NULL_STRING)
@@ -1888,3 +1888,7 @@
{
    BaseClass::SetGroundEntity(ground);
IGameEvent *event = gameeventmanager->CreateEvent( "gravity_change" );
}
if ( event )
{
event->SetFloat( "newgravity", var->GetFloat() );
gameeventmanager->FireEvent( event );
}
}
  #endif
  }
  #ifdef CLIENT_DLL
  class CGravityChange : public IGameEventListener2, public CAutoGameSystem
  {
public:
bool Init()
{
gameeventmanager->AddListener(this,"gravity_change",false);
return true;
}
void FireGameEvent( IGameEvent *event )
{
UpdatePhysicsGravity(event->GetFloat("newgravity"));
}
};
static CGravityChange s_GravityChange;
#endif
ConVar sv_gravity ( "sv_gravity",DEFAULT_GRAVITY_STRING, FCVAR_NOTIFY | FCVAR_REPLICATED, "World gravity.", GravityChanged_Callback );
In your mod's events file (GameEvents.res/ModEvents.res):
"gravity_change"
{
"newgravity" "float"
}
{{TODO|Diff this}}


== Server: util.cpp (531) : Assertion Failed: !"UTIL_GetLocalPlayer" ==
+
Occurs when taking damage to yourself from tossing a table straight up into the air.
+int C_BasePlayer::GetHealth() const {
+    return g_PR->GetHealth(entindex());
+}


'''Fix:'''
The following patch fixes the Assert, and appears to be more functionally correct as well. Validation from Valve that the patch is correct would be appreciated. [[Diff And Patch]]
<pre>
Index: mod/src/dlls/player.h
===================================================================
--- mod/src/dlls/player.h 2005/02/19 22:20:29 1.2
+++ mod/src/dlls/player.h 2005/02/24 00:35:30
@@ -459,6 +459,7 @@
    // mass/size limit set to zero for none
    static bool CanPickupObject( CBaseEntity *pObject, float massLimit, float sizeLimit );
    virtual void PickupObject( CBaseEntity *pObject, bool bLimitMassAndSize = true ) {}
+    virtual bool IsHoldingEntity( CBaseEntity *pEnt );
    virtual void ForceDropOfCarriedPhysObjects( CBaseEntity *pOnlyIfHoldindThis = NULL ) {}
    virtual float GetHeldObjectMass( IPhysicsObject *pHeldObject );


Index: mod/src/dlls/player.cpp
===================================================================
--- mod/src/dlls/player.cpp 2005/02/21 00:05:42 1.3
+++ mod/src/dlls/player.cpp 2005/02/24 00:35:33
@@ -7447,3 +7447,7 @@
    return cmd;
}


+bool CBasePlayer::IsHoldingEntity( CBaseEntity *pEnt )
--- mod/src/cl_dll/c_baseplayer.h      2005/07/11 03:28:41    1.9
+{
+++ mod/src/cl_dll/c_baseplayer.h      2005/07/16 21:05:31
+   return PlayerPickupControllerIsHoldingEntity( m_hUseEntity, pEnt );
@@ -103,7 +103,7 @@
+}
 
        // Data handlers
        virtual bool    IsPlayer( void ) const { return true; };
-      virtual int            GetHealth() const { return m_iHealth; };
+       virtual int            GetHealth() const;
 
        // observer mode
        virtual int                    GetObserverMode() const;
 
 


Index: mod/src/dlls/physics_impact_damage.cpp
--- mod/src/dlls/player.cpp     2005/07/12 07:38:04    1.33
===================================================================
+++ mod/src/dlls/player.cpp     2005/07/22 00:45:48
--- mod/src/dlls/physics_impact_damage.cpp 2005/02/18 04:45:50 1.1.1.1
@@ -58,6 +58,8 @@
+++ mod/src/dlls/physics_impact_damage.cpp 2005/02/24 00:42:24
#include "nav_mesh.h"
@@ -417,12 +417,22 @@
#include "env_zoom.h"
    else if ( pEvent->pObjects[index>GetGameFlags() & FVPHYSICS_PLAYER_HELD )
 
    {
+#include "player_resource.h"
    // if the player is holding the object, use it's real mass (player holding reduced the mass)
+
-    CBasePlayer *pPlayer = UTIL_GetLocalPlayer();
#ifdef HL2_DLL
-    if ( pPlayer )
#include "combine_mine.h"
-    {
#include "weapon_physcannon.h"
+   CBasePlayer* pPlayer = NULL;
@@ -4295,6 +4297,9 @@
+   {for (int i = 1; i <= gpGlobals->maxClients; i++) {
        m_lastx = m_lasty = 0;
+        CBasePlayer *temp_player = UTIL_PlayerByIndex(i);
 
+        if (temp_player
        m_lastNavArea = NULL;
+            && temp_player->edict()
+
+            && temp_player->IsHoldingEntity(pEvent->pEntities[index])
+    // update now so that our new health gets sent with the respawn notice
+       ) {
+    g_pPlayerResource->SetPlayerHealth(entindex(), m_iHealth);
+            pPlayer = temp_player;
+            break;
+       }
+    }}
+    Assert(pPlayer && "object with FVPHYSICS_PLAYER_HELD but no player holding it");
+    if (pPlayer) {
    float mass = pPlayer->GetHeldObjectMass( pEvent->pObjects[index] );
-    if ( mass > 0 )
-    {
+        Assert((mass > 0) && "player was holding object so mass should be non-zero");
+        if (mass > 0) {
            invMass = 1.0f / mass;
        }
    }
</pre>


{{note|Instead of iterating all players, why not consider adding a m_pHolder var and GetHolder and SetHolder functions to CBaseEntity}}
        /// @todo Do this once per round instead of once per player
        if (TheNavMesh)


(You could, though it's unlikely to impact performance much since this is not a frequently called function. [[User:Bloodykenny|Bloodykenny]] 17:55, 19 Jul 2005 (PDT))


== Assert !"UTIL_GetLocalPlayer" when using combine ball ==


'''Fix:''' [[Diff And Patch]]
--- mod/src/dlls/player_resource.cpp   2005/06/19 02:54:04    1.5
<pre>
+++ mod/src/dlls/player_resource.cpp   2005/07/22 00:44:35
diff -u -r1.1.1.1 prop_combine_ball.cpp
@@ -85,6 +85,13 @@
--- mod/src/dlls/hl2_dll/prop_combine_ball.cpp 2005/02/18 04:45:52 1.1.1.1
}
+++ mod/src/dlls/hl2_dll/prop_combine_ball.cpp 2005/02/24 01:34:21
@@ -788,9 +788,9 @@  
    pPhysicsObject->GetPosition( &vecPosition, NULL );
    pPhysicsObject->GetVelocity( &vecVelocity, NULL );


-   CBasePlayer *pPlayer = UTIL_GetLocalPlayer();
//-----------------------------------------------------------------------------
-   if ( pPlayer )
+// Purpose: Sets health value for a particular client (used to set on spawn so the data will be sent synchronously)
+   if (gpGlobals->maxClients == 1)  
+//-----------------------------------------------------------------------------
    {  
+void CPlayerResource::SetPlayerHealth(int entindex, int health) {
+    CBasePlayer *pPlayer = UTIL_GetLocalPlayer();  
+    m_iHealth.Set(entindex, health);
    Vector vecDelta;
+}
    VectorSubtract( pPlayer->GetAbsOrigin(), vecPosition, vecDelta );
+
    VectorNormalize( vecDelta );
+//-----------------------------------------------------------------------------
</pre>
// Purpose: The Player resource is always transmitted to clients
//-----------------------------------------------------------------------------
int CPlayerResource::UpdateTransmitState()


{{Note|This really is a dirty fix because the combine ball always has to face the player because the model was design without a back side}}




--- mod/src/dlls/player_resource.h      2005/06/18 21:16:29    1.3
+++ mod/src/dlls/player_resource.h      2005/07/22 00:42:57
@@ -26,6 +26,8 @@
        virtual void UpdatePlayerData( void );
        virtual int  UpdateTransmitState(void);
+    void SetPlayerHealth(int entindex, int health);
+
protected:
        // Data for each player that's propagated to all clients
        // Stored in individual arrays so they can be sent down via datatables
</pre>


== HL2.exe mysteriously segfaults if you forget to put the client.dll and server.dll in your mod's bin directory ==
Then you can remove the SendPropInt and RecvPropInt for CBasePlayer::m_iHealth...


'''Fix:''' Don't do that.
<pre>
--- src/cl_dll/c_baseplayer.cpp 26 Aug 2006 21:24:21 -0000 1.14
+++ src/cl_dll/c_baseplayer.cpp 4 Sep 2006 18:33:46 -0000
@@ -222,7 +222,7 @@
RecvPropEHandle( RECVINFO(m_hVehicle) ),
RecvPropEHandle( RECVINFO(m_hUseEntity) ),
- RecvPropInt (RECVINFO(m_iHealth)),
+ // RecvPropInt (RECVINFO(m_iHealth)),
RecvPropInt (RECVINFO(m_lifeState)),
RecvPropFloat (RECVINFO(m_flMaxspeed)),
@@ -284,7 +284,7 @@
DEFINE_PRED_FIELD( m_hVehicle, FIELD_EHANDLE, FTYPEDESC_INSENDTABLE ),
DEFINE_PRED_FIELD_TOL( m_flMaxspeed, FIELD_FLOAT, FTYPEDESC_INSENDTABLE, 0.5f ),
- DEFINE_PRED_FIELD( m_iHealth, FIELD_INTEGER, FTYPEDESC_INSENDTABLE ),
+ // DEFINE_PRED_FIELD( m_iHealth, FIELD_INTEGER, FTYPEDESC_INSENDTABLE ),
DEFINE_PRED_FIELD( m_fOnTarget, FIELD_BOOLEAN, FTYPEDESC_INSENDTABLE ),
DEFINE_PRED_FIELD( m_nNextThinkTick, FIELD_INTEGER, FTYPEDESC_INSENDTABLE ),
DEFINE_PRED_FIELD( m_lifeState, FIELD_CHARACTER, FTYPEDESC_INSENDTABLE ),


Update: the behavior here seems to have changed - now HL2 gives an equally mysterious "Server uses different class tables" message.  Can anyone else confirm this?


== Server/Client: Negative entitygroundcontact crash. ==
--- src/cl_dll/c_baseplayer.h 26 Aug 2006 21:24:21 -0000 1.19
+++ src/cl_dll/c_baseplayer.h 4 Sep 2006 18:33:46 -0000
@@ -377,7 +377,7 @@
EHANDLE m_hUseEntity;
float m_flMaxspeed;
- int m_iHealth;
+ void m_iHealth(); // hide the base class m_iHealth to ensure it's not used
CInterpolatedVar< Vector > m_iv_vecViewOffset;


The implications of this SDK bug are not at all clear, but in debug mode you'll get an assert, and in release mode it will presumably segfault.  The patch assumes anything negative or really large is bogus and dumps it.


I'm starting to wonder if maybe this is another symptom of the Physics Mayhem bugs. --[[User:Bloodykenny|Bloodykenny]] 17:24, 4 Nov 2005 (PST)
--- src/dlls/player.cpp 3 Sep 2006 23:29:16 -0000 1.76
+++ src/dlls/player.cpp 4 Sep 2006 18:33:47 -0000
@@ -7298,7 +7298,7 @@
SendPropDataTable(SENDINFO_DT(pl), &REFERENCE_SEND_TABLE(DT_PlayerState), SendProxy_DataTableToDataTable),
SendPropEHandle(SENDINFO(m_hVehicle)),
SendPropEHandle(SENDINFO(m_hUseEntity)),
- SendPropInt (SENDINFO(m_iHealth), 10 ),
+ // SendPropInt (SENDINFO(m_iHealth), 10 ),
SendPropInt (SENDINFO(m_lifeState), 3, SPROP_UNSIGNED ),
SendPropFloat (SENDINFO(m_flMaxspeed), 12, SPROP_ROUNDDOWN, 0.0f, 2048.0f ),  // CL
SendPropInt (SENDINFO(m_fFlags), PLAYER_FLAG_BITS, SPROP_UNSIGNED|SPROP_CHANGES_OFTEN, SendProxy_CropFlagsToPlayerFlagBitsLength ),


'''Fix:''' [[Diff And Patch]]


<pre>
--- src/game_shared/gamemovement.cpp 26 Aug 2006 21:24:36 -0000 1.21
--- mod/src/game_shared/usercmd.cpp 2005/02/18 04:45:54 1.1.1.1
+++ src/game_shared/gamemovement.cpp 4 Sep 2006 18:33:47 -0000
+++ mod/src/game_shared/usercmd.cpp 2005/03/23 02:24:00
@@ -490,7 +490,7 @@
@@ -290,7 +290,12 @@
   
  #if defined( HL2_DLL )
bool CGameMovement::IsDead( void ) const
    if ( buf->ReadOneBit() )
{
    {
- return ( player->m_iHealth <= 0 ) ? true : false;
-       move->entitygroundcontact.SetCount( buf->ReadShort() );
+ return ( player->GetHealth() <= 0 ) ? true : false;
+       int count = buf->ReadShort();
}
+        if ((count < 0) || (count > 140)) {
+            Msg("Ignoring strange entitygroundcontact count: %d\n", count);
//-----------------------------------------------------------------------------
+            return; // why can this be less than 0, Valve? change to ReadWord()???
+        }
+    move->entitygroundcontact.SetCount( count );
 
    int i;
    for (i = 0; i < move->entitygroundcontact.Count(); i++)
</pre>
</pre>


== Client: Spinning around quickly with the Stun Baton as your active weapon causes the screen to flash white ==
== Server: The client's team membership is pointlessly sent across the wire twice. ==


It's worth noting that recent updates to HL2DM have fixed this.  However there has not yet been an SDK code update to show what the fix is.  Basically Valve seems to have made the glow fade out completely in between swings.
Similar to the above KI, but for another variable.  Also this fixes an SDK crasher, but according to Yahn at Valve, Steam will be fixed soon to not do that.


'''Fix:''' Fix unknown
'''Fix:''' [[Diff And Patch]]


== Assert on line 866 of mod/src/game_shared/basecombatweapon_shared.cpp ==
<pre>
--- mod/src/dlls/team.cpp      2005/06/11 22:14:30    1.2
+++ mod/src/dlls/team.cpp       2006/05/29 18:58:52    1.3
@@ -19,6 +19,7 @@
//-----------------------------------------------------------------------------
void SendProxy_PlayerList( const SendProp *pProp, const void *pStruct, const void *pData, DVariant *pOut, int iElement, int objectID )
{
+    Assert(0);
        CTeam *pTeam = (CTeam*)pData;


'''Fix:''' I haven't been able to determine exactly why this is an assert. It's just "Assert(0);" with no accompanying explanation, but commenting it out results in no problems it seems. [[Diff And Patch]]
        // If this assertion fails, then SendProxyArrayLength_PlayerArray must have failed.
@@ -31,8 +32,11 @@


<pre>
int SendProxyArrayLength_PlayerArray( const void *pStruct, int objectID )
--- mod/src/game_shared/basecombatweapon_shared.cpp    2005/02/18 04:45:53    1.1
{
+++ mod/src/game_shared/basecombatweapon_shared.cpp    2005/03/04 03:45:36    1.2
-       CTeam *pTeam = (CTeam*)pStruct;
@@ -863,7 +863,7 @@
-       return pTeam->m_aPlayers.Count();
        CBaseViewModel *vm = pOwner->GetViewModel( m_nViewModelIndex );
+    // The RecvPropArray2 in general was seemingly broken in the May 25th-ish core engine update.
        if ( vm == NULL )
+    // The CTeam in particular was certainly broken at that time, however, thankfully it doesn't
        {
+   // serve any important purpose.
-              Assert( false );
+    // For backwards compatibility with old client, we disable it, rather than remove it entirely.
+               //Assert( false );
+   return 0;
                return false;
}
        }
</pre>
</pre>


== Client: The mod can appear to have frozen on initial startup ==
== Server: weapon_citizensuitcase Assert on startup ==
Originally posted by MattC here: http://www.chatbear.com/board.plm?a=viewthread&b=4991&t=234,1117553034,6915&s=0&id=868372


'''Fix:''' Issue a "progress_enable" command just before "map <mapname>".
'''Fix:''' Install copy of the SP SDK, then copy the scripts/ directory over


<pre>
== Server: Some bullet weapons set to do 0 damage. ==
engine->ClientCmd("progress_enable");


engine->ClientCmd("map test");
'''Fix:''' Need to edit their AddAmmoType which are strangely set to 0 for some reason.
</pre>


This should fix local servers.  For connecting to a remote multiplayer server, the only issue appears to be that you can't switch to another window and then switch back to HL2.  Doing so causes HL2 to never render progress info until load is fully complete.  That seems to be an HL2 core bug unrelated (though very similar in appearance) to the fix above.
== Server: Some projectile weapons set to do 0 damage. ==


== USE_VCR_MODE linker errors ==
'''Fix:''' Need to edit their source files and set a damage.  
This is because Valve wants to be able to somehow replay all of the things that happen in a mod and get back the exact same output.  I'm still confused as to how that would work, or what the value really is, but anyway, if you need things like threading, you'll hit these errors.


My mod needed threading and commenting these out has never caused any issue.  Though apparently it means my mod can't use VCR mode.
== Client: --- Missing Vgui material vgui/steam/games/icon_cz ==


'''Fix:''' Comment out the appropriate lines in protect_things.h, for whatever VCR thing was failing.  Note, don't just block out the whole file - the string part at the top is actually useful.
'''Fix:''' These files are used in the currently inaccessible Friends IM client. Create 4 vmts in their places of any design to remove the error.


* materials\VGUI\steam\games\icon_cs.vmt
* materials\VGUI\steam\games\icon_dod.vmt
* materials\VGUI\steam\games\icon_hl2mp.vmt
* materials\VGUI\servers\icon_secure_deny.vmt


Here's a patch to create files for the first three. (I don't see the icon_secure_deny.vmt error, so didn't create anything for it.)


== Source Crashes when alt+tab during background map loading ==
* When you alt + tab out of the game when the background map is loading, you will end up with a crash. Debug points to a frame count hack that I have no idea how to fix. Someone that knows how to add a curTime event may be able to fix this bug.
Here's a stack trace following a screen change and a crash:
<pre>
<pre>
> engine.dll!0da99893()
--- materials/VGUI/steam/games/icon_cs.vmt      1969-12-31 18:00:00.000000000 -0600
engine.dll!0db000e2()
+++ materials/VGUI/steam/games/icon_cs.vmt      2005-07-28 01:54:17.000000000 -0500
engine.dll!0db0046f()
@@ -0,0 +1 @@
engine.dll!0dafba15()
+"UnlitGeneric" {}
engine.dll!0da9995a()
--- materials/VGUI/steam/games/icon_dod.vmt    1969-12-31 18:00:00.000000000 -0600
engine.dll!0da6247d()
+++ materials/VGUI/steam/games/icon_dod.vmt    2005-07-28 01:54:19.000000000 -0500
engine.dll!0db2e05c()
@@ -0,0 +1 @@
engine.dll!0d9e3907()
+"UnlitGeneric" {}
engine.dll!0da6f816()
--- materials/VGUI/steam/games/icon_hl2mp.vmt  1969-12-31 18:00:00.000000000 -0600
engine.dll!0da7a31c()
+++ materials/VGUI/steam/games/icon_hl2mp.vmt  2005-07-28 01:54:15.000000000 -0500
engine.dll!0da7a9b3()
@@ -0,0 +1 @@
engine.dll!0da853b5()
+"UnlitGeneric" {}
engine.dll!0da854a2()
engine.dll!0da8553f()
engine.dll!0db2309c()
engine.dll!0db22c67()
MaterialSystem.dll!0d58d0c5()
engine.dll!0daa50fb()
engine.dll!0db22eee()
engine.dll!0db22d24()
engine.dll!0db22d2f()
engine.dll!0db22dcc()
launcher.dll!1000369b()
launcher.dll!10007f70()
launcher.dll!10007f70()
launcher.dll!100057f8()
</pre>
</pre>


== Lighting in Compile (RAD) ==
'''Fix2:''' Add clear to your rc file in cfg (extract from gcf if non-existant)
There is currently a rather severe lighting bug during RAD. Visible symptoms include: black models while in shadows cast by light_environment; large, unlit sections in "outdoor" type areas.


'''Fix:''' Pending.
== Server: The crossbow causes an assertion failure. ==


== Using the Sheild Scanner npc_cscanner is not possible unless you name the map with d3_c17 as a prefix ==
'''Fix:''' Comment out ai_activity.cpp line 53. This doesn't appear to be something that can be fixed in code?
I was expecting the flag for strider scout scanner to be the sheild scanner version of the npc_cscanner, but it seems that the flag is there, but currently in the default hl2 code it does nothing.


So I replaced in the Scanner constructor function the code that compares the first 6 letters of a map name to d3_c17 with
== Server? Client?: RL explosion invisible ==


npc_scanner.cpp Line 588
Per http://www.chatbear.com/board.plm?a=viewthread&t=970,1107153392,30132&id=786504&b=4991&v=flatold


<pre>
The patch to c_te_explosion.cpp was rolled into the 2006-08-04 SDK update, however it does not fix the issue. The issue still exists. My current speculation is that this is a bug in core or in the maps, but hard to say which.
DevMsg("CNPC_CScanner::Spawn: Invalid spotlight width %.1f (max %.1f).\n", m_flSpotlightGoalWidth, MAX_BEAM_WIDTH );
m_flSpotlightGoalWidth = MAX_BEAM_WIDTH;
}


+if( IsStriderScout() )
== sv_gravity is not associated with physics gravity==
+ {
When gravity is changed, the physics gravity isn't updated
+ // Streetwar scanners are claw scanners
+ m_bIsClawScanner = true;
+ }
+ else
+ {
+ m_bIsClawScanner = false;
+ }


Precache();
'''Fix:'''
 
In movevars_shared.cpp:
if( m_bIsClawScanner )
inline void UpdatePhysicsGravity(float gravity)
</pre>
{
 
if(physenv)
== Complaints about tv_delaymapchange in NON SRCTV Mods ==
physenv->SetGravity(Vector(0,0,-gravity));
{{Note|This issue is fixed in the August 2006 SDK update}}
}
Issue: Console reports an issue about tv_delaymapchange when loading a mod with no SRCTV Support.
static void GravityChanged_Callback( ConVar *var, const char *pOldString )
 
{
=== mod/game_shared/multiplay_gamerules.cpp ===
#ifndef CLIENT_DLL
Undone! you don't have to remove it, instead, add FCVAR_REPLICATED like all the other cvar's.
UpdatePhysicsGravity(var->GetFloat());
It's doing it because it's a shared ConVar in both dll's and not being replicated. --[[User:Omega|omega]]
if(gpGlobals->mapname!=NULL_STRING)
 
{
Instead, change to this:
IGameEvent *event = gameeventmanager->CreateEvent( "gravity_change" );
<pre>
if ( event )
Line 47
{
ConVar mp_timelimit( "mp_timelimit",
event->SetFloat( "newgravity", var->GetFloat() );
  "0",
gameeventmanager->FireEvent( event );
  FCVAR_NOTIFY|FCVAR_REPLICATED,
}
  "game time per map in minutes" );
}
 
#endif
ConVar tv_delaymapchange( "tv_delaymapchange",
}
  "0",
#ifdef CLIENT_DLL
-   0,
class CGravityChange : public IGameEventListener2, public CAutoGameSystem
+   FCVAR_NOTIFY|FCVAR_REPLICATED,
{
  "Delays map change until broadcast is complete" );
public:
 
bool Init()
</pre>
{
gameeventmanager->AddListener(this,"gravity_change",false);
return true;
}
void FireGameEvent( IGameEvent *event )
{
UpdatePhysicsGravity(event->GetFloat("newgravity"));
}
};
static CGravityChange s_GravityChange;
#endif
ConVar sv_gravity ( "sv_gravity",DEFAULT_GRAVITY_STRING, FCVAR_NOTIFY | FCVAR_REPLICATED, "World gravity.", GravityChanged_Callback );
In your mod's events file (GameEvents.res/ModEvents.res):
"gravity_change"
{
"newgravity" "float"
}
{{TODO|Diff this}}


== Physics models show up darker under switchable lights ==
== Server: util.cpp (531) : Assertion Failed: !"UTIL_GetLocalPlayer" ==
Occurs when taking damage to yourself from tossing a table straight up into the air.


Switchable lights are not taken into account for visibility of physics models when Source starts a map. So whenever a physics model is mostly lit by switchable lights, it will show up much darker when the map starts.
'''Fix:'''
The following patch fixes the Assert, and appears to be more functionally correct as well. Validation from Valve that the patch is correct would be appreciated. [[Diff And Patch]]
<pre>
Index: mod/src/dlls/player.h
===================================================================
--- mod/src/dlls/player.h 2005/02/19 22:20:29 1.2
+++ mod/src/dlls/player.h 2005/02/24 00:35:30
@@ -459,6 +459,7 @@
    // mass/size limit set to zero for none
    static bool CanPickupObject( CBaseEntity *pObject, float massLimit, float sizeLimit );
    virtual void PickupObject( CBaseEntity *pObject, bool bLimitMassAndSize = true ) {}
+    virtual bool IsHoldingEntity( CBaseEntity *pEnt );
    virtual void ForceDropOfCarriedPhysObjects( CBaseEntity *pOnlyIfHoldindThis = NULL ) {}
    virtual float GetHeldObjectMass( IPhysicsObject *pHeldObject );


If the switchable lights are turned off and on again, or if a physics model is moved, then the visibility of this physics model is automatically fixed. But if the map is saved and reloaded, all physics models under switchable lights become darker again.
Index: mod/src/dlls/player.cpp
===================================================================
--- mod/src/dlls/player.cpp 2005/02/21 00:05:42 1.3
+++ mod/src/dlls/player.cpp 2005/02/24 00:35:33
@@ -7447,3 +7447,7 @@
    return cmd;
}


{{note|A switchable light is a light with a targetname, that can be triggered to turn on/off.}}
+bool CBasePlayer::IsHoldingEntity( CBaseEntity *pEnt )
+{
+    return PlayerPickupControllerIsHoldingEntity( m_hUseEntity, pEnt );
+}


'''Fix:''' Fix unknown
Index: mod/src/dlls/physics_impact_damage.cpp
 
===================================================================
 
--- mod/src/dlls/physics_impact_damage.cpp 2005/02/18 04:45:50 1.1.1.1
 
+++ mod/src/dlls/physics_impact_damage.cpp 2005/02/24 00:42:24
== Sticky Player Collisions ==
@@ -417,12 +417,22 @@
I've been chasing a fix for this for months for Dystopia, when two players collide with each other there's massive prediction errors and to the player it looks like they're jerking back and forth. It can mean real trouble when two players attempt to get through a doorway or something, and it sucks if you're trying to do a good melee system.
    else if ( pEvent->pObjects[index>GetGameFlags() & FVPHYSICS_PLAYER_HELD )
 
    {
Anyways, I found out the cause of this problem is on the server, when it runs a players movement code, it first unlags all the other players on the server, presumably to help predict player vs. player collisions. The problem is, because two players have different pings, there's no authoritative point of impact for the collision, so the jerking around you see is caused by this unlagging. Now down to the fix, which is really simple:
    // if the player is holding the object, use it's real mass (player holding reduced the mass)
 
-    CBasePlayer *pPlayer = UTIL_GetLocalPlayer();
player_command.cpp Line 42
-    if ( pPlayer )
<pre>
-    {
// Move other players back to history positions based on local player's lag
+    CBasePlayer* pPlayer = NULL;
- lagcompensation->StartLagCompensation( player, cmd );
+    {for (int i = 1; i <= gpGlobals->maxClients; i++) {
+        CBasePlayer *temp_player = UTIL_PlayerByIndex(i);
+        if (temp_player
+            && temp_player->edict()
+            && temp_player->IsHoldingEntity(pEvent->pEntities[index])
+        ) {
+            pPlayer = temp_player;
+            break;
+        }
+    }}
+    Assert(pPlayer && "object with FVPHYSICS_PLAYER_HELD but no player holding it");
+    if (pPlayer) {
    float mass = pPlayer->GetHeldObjectMass( pEvent->pObjects[index] );
-   if ( mass > 0 )
-    {
+        Assert((mass > 0) && "player was holding object so mass should be non-zero");
+        if (mass > 0) {
            invMass = 1.0f / mass;
        }
    }
</pre>
</pre>


player_command.cpp Line 52
{{note|Instead of iterating all players, why not consider adding a m_pHolder var and GetHolder and SetHolder functions to CBaseEntity}}
<pre>
// Restore other players to current positions
- lagcompensation->FinishLagCompensation( player );
</pre>


player_command.cpp Line 348
(You could, though it's unlikely to impact performance much since this is not a frequently called function. [[User:Bloodykenny|Bloodykenny]] 17:55, 19 Jul 2005 (PDT))
// Let server invoke any needed impact functions
moveHelper->ProcessImpacts();
+ // Only do unlag for post think/post frame, which is mainly weapons stuff! - Teddy
+ lagcompensation->StartLagCompensation( player, '''u'''cmd );
RunPostThink( player );
+ lagcompensation->FinishLagCompensation( player );
FinishCommand( player );


Pretty simple huh? You only need unlag for weapons really, and all the weapon hitscan code is run from the weapon's ItemPostFrame which is what the RunPostThink() runs. Let me know if it works for you! --[[User:Teddy|Teddy]] 20:05, 12 Jun 2006 (PDT)
== Assert !"UTIL_GetLocalPlayer" when using combine ball ==


'''Fix:''' [[Diff And Patch]]
<pre>
diff -u -r1.1.1.1 prop_combine_ball.cpp
--- mod/src/dlls/hl2_dll/prop_combine_ball.cpp 2005/02/18 04:45:52 1.1.1.1
+++ mod/src/dlls/hl2_dll/prop_combine_ball.cpp 2005/02/24 01:34:21
@@ -788,9 +788,9 @@
    pPhysicsObject->GetPosition( &vecPosition, NULL );
    pPhysicsObject->GetVelocity( &vecVelocity, NULL );


== Minor/misc code neatenings/fixings ==
-    CBasePlayer *pPlayer = UTIL_GetLocalPlayer();
 
-    if ( pPlayer )
(This section is for issues in the codebase that you've spotted to be potentially dangerous but aren't actually causing obvious bugs/issues... every little improvement to the quality of the codebase helps, right?)
+    if (gpGlobals->maxClients == 1)
 
    {
/src/cl_dll/game_controls/spectatorgui.cpp(498): The memset is setting twice as much memory as it should be to 0x0 because sizeof(playerName) already accounts for the fact that the elements are wchar_t type. '''Fix:''' Remove the "* sizeof( wchar_t)".  
+    CBasePlayer *pPlayer = UTIL_GetLocalPlayer();
    Vector vecDelta;
    VectorSubtract( pPlayer->GetAbsOrigin(), vecPosition, vecDelta );
    VectorNormalize( vecDelta );
</pre>
 
== Server/Client: Negative entitygroundcontact crash. ==


== Jerky Movement when player is on moving lift/elevator ==
The implications of this SDK bug are not at all clear, but in debug mode you'll get an assert, and in release mode it will presumably segfault.  The patch assumes anything negative or really large is bogus and dumps it.
{{Note|This issue has been fixed in the August 2006 SDK}}
"I'm not sure if it's the issue or not, but I remember a bug like this in episode 1," said Jay on HL Coders  "If it's the same issue, then setting smoothstairs to zero will fix it (but cause other problems).  If that's the case then you need to add some logic to disable stair smoothing when the player is on an elevator."


Here's the code from ep1
I'm starting to wonder if maybe this is another symptom of the Physics Mayhem bugs. --[[User:Bloodykenny|Bloodykenny]] 17:24, 4 Nov 2005 (PST)


<b>baseplayer_shared.cpp:</b>
'''Fix:''' [[Diff And Patch]]


<pre>
<pre>
static ConVar smoothstairs( "smoothstairs", "1", FCVAR_REPLICATED, "Smooth player eye z coordinate when traversing stairs." );
--- mod/src/game_shared/usercmd.cpp 2005/02/18 04:45:54 1.1.1.1
+++ mod/src/game_shared/usercmd.cpp 2005/03/23 02:24:00
@@ -290,7 +290,12 @@
#if defined( HL2_DLL )
    if ( buf->ReadOneBit() )
    {
-        move->entitygroundcontact.SetCount( buf->ReadShort() );
+        int count = buf->ReadShort();
+        if ((count < 0) || (count > 140)) {
+            Msg("Ignoring strange entitygroundcontact count: %d\n", count);
+            return; // why can this be less than 0, Valve? change to ReadWord()???
+        }
+    move->entitygroundcontact.SetCount( count );


//-----------------------------------------------------------------------------
    int i;
// Handle view smoothing when going up or down stairs
    for (i = 0; i < move->entitygroundcontact.Count(); i++)
//-----------------------------------------------------------------------------
</pre>
void CBasePlayer::SmoothViewOnStairs( Vector& eyeOrigin )
{
CBaseEntity *pGroundEntity = GetGroundEntity();
float flCurrentPlayerZ = GetLocalOrigin().z;
float flCurrentPlayerViewOffsetZ = GetViewOffset().z;


// Smooth out stair step ups
== Client: Spinning around quickly with the Stun Baton as your active weapon causes the screen to flash white ==
// NOTE: Don't want to do this when the ground entity is movingthe player
if ( ( pGroundEntity != NULL && pGroundEntity->GetMoveType() ==
MOVETYPE_NONE ) && ( flCurrentPlayerZ != m_flOldPlayerZ ) &&
smoothstairs.GetBool() &&
m_flOldPlayerViewOffsetZ == flCurrentPlayerViewOffsetZ
)
{
int dir = ( flCurrentPlayerZ > m_flOldPlayerZ ) ? 1 :-1;


float steptime = gpGlobals->frametime;
It's worth noting that recent updates to HL2DM have fixed this.  However there has not yet been an SDK code update to show what the fix is.  Basically Valve seems to have made the glow fade out completely in between swings.
if (steptime < 0)
{
steptime = 0;
}


m_flOldPlayerZ += steptime * 150 * dir;
'''Fix:''' Fix unknown


const float stepSize = 18.0f;
== Assert on line 866 of mod/src/game_shared/basecombatweapon_shared.cpp ==


if ( dir > 0 )
'''Fix:''' I haven't been able to determine exactly why this is an assert. It's just "Assert(0);" with no accompanying explanation, but commenting it out results in no problems it seems. [[Diff And Patch]]
{
if (m_flOldPlayerZ > flCurrentPlayerZ)
{
m_flOldPlayerZ = flCurrentPlayerZ;
}
if (flCurrentPlayerZ - m_flOldPlayerZ >stepSize)
{
m_flOldPlayerZ = flCurrentPlayerZ -stepSize;
}
}
else
{
if (m_flOldPlayerZ < flCurrentPlayerZ)
{
m_flOldPlayerZ = flCurrentPlayerZ;
}
if (flCurrentPlayerZ - m_flOldPlayerZ <-stepSize)
{
m_flOldPlayerZ = flCurrentPlayerZ +stepSize;
}
}


eyeOrigin[2] += m_flOldPlayerZ - flCurrentPlayerZ;
<pre>
}
--- mod/src/game_shared/basecombatweapon_shared.cpp    2005/02/18 04:45:53    1.1
else
+++ mod/src/game_shared/basecombatweapon_shared.cpp    2005/03/04 03:45:36    1.2
{
@@ -863,7 +863,7 @@
m_flOldPlayerZ = flCurrentPlayerZ;
        CBaseViewModel *vm = pOwner->GetViewModel( m_nViewModelIndex );
m_flOldPlayerViewOffsetZ = flCurrentPlayerViewOffsetZ;
        if ( vm == NULL )
}
        {
-              Assert( false );
+              //Assert( false );
                return false;
        }
</pre>
</pre>


== filter_damage_type doesn't work ==
== Client: The mod can appear to have frozen on initial startup ==
Open <code>dlls/filters.cpp</code> and replace
Originally posted by MattC here: http://www.chatbear.com/board.plm?a=viewthread&b=4991&t=234,1117553034,6915&s=0&id=868372
 
'''Fix:''' Issue a "progress_enable" command just before "map <mapname>".


<pre>
<pre>
return info.GetDamageType() == m_iDamageType;
engine->ClientCmd("progress_enable");
 
engine->ClientCmd("map test");
</pre>
</pre>


with
This should fix local servers.  For connecting to a remote multiplayer server, the only issue appears to be that you can't switch to another window and then switch back to HL2.  Doing so causes HL2 to never render progress info until load is fully complete.  That seems to be an HL2 core bug unrelated (though very similar in appearance) to the fix above.


<pre>
== USE_VCR_MODE linker errors ==
return ( (info.GetDamageType() & m_iDamageType ) ? true : false );
This is because Valve wants to be able to somehow replay all of the things that happen in a mod and get back the exact same output.  I'm still confused as to how that would work, or what the value really is, but anyway, if you need things like threading, you'll hit these errors.
</pre>
 
My mod needed threading and commenting these out has never caused any issue.  Though apparently it means my mod can't use VCR mode.
 
'''Fix:''' Comment out the appropriate lines in protected_things.h, for whatever VCR thing was failing.  Note, don't just block out the whole file - the string part at the top is actually useful.
 
== Lighting in Compile (RAD) ==
There is currently a rather severe lighting bug during RAD. Visible symptoms include: black models while in shadows cast by light_environment; large, unlit sections in "outdoor" type areas.
 
'''Fix:''' Pending.
 
 
 
== Complaints about tv_delaymapchange in NON SRCTV Mods ==
{{Note|This issue is fixed in the August 2006 SDK update}}
Issue: Console reports an issue about tv_delaymapchange when loading a mod with no SRCTV Support.


== Floating SLAM's ==
=== mod/game_shared/multiplay_gamerules.cpp ===
When attaching a SLAM at a movable object, it doesn't explode when the object moves and so give a "floating SLAM".
Undone! you don't have to remove it, instead, add FCVAR_REPLICATED like all the other cvar's.
It's doing it because it's a shared ConVar in both dll's and not being replicated. --[[User:Omega|omega]]


'''Fix:'''
Instead, change to this:
<pre>
<pre>
--- mod/src/dlls/hl2_dll/grenade_tripmine.h 18 Feb 2005 04:45:51 -0000 1.1.1.1
Line 47
+++ mod/src/dlls/hl2_dll/grenade_tripmine.h 22 Jul 2006 22:32:28 -0000
ConVar mp_timelimit( "mp_timelimit",
@@ -36,6 +36,8 @@
  "0",
void MakeBeam( void );
  FCVAR_NOTIFY|FCVAR_REPLICATED,
void KillBeam( void );
  "game time per map in minutes" );
 
+   void AttachToEntity(const CBaseEntity* const ent);
ConVar tv_delaymapchange( "tv_delaymapchange",
+
  "0",
public:
-   0,
EHANDLE m_hOwner;
+   FCVAR_NOTIFY|FCVAR_REPLICATED,
  "Delays map change until broadcast is complete" );
@@ -49,6 +51,10 @@
 
Vector m_posOwner;
</pre>
Vector m_angleOwner;
 
== Physics models show up darker under switchable lights ==
+    const CBaseEntity* m_pAttachedObject;
 
+    Vector m_vecOldPosAttachedObject;
Switchable lights are not taken into account for visibility of physics models when Source starts a map. So whenever a physics model is mostly lit by switchable lights, it will show up much darker when the map starts.
+    QAngle m_vecOldAngAttachedObject;
 
+
If the switchable lights are turned off and on again, or if a physics model is moved, then the visibility of this physics model is automatically fixed. But if the map is saved and reloaded, all physics models under switchable lights become darker again.
DECLARE_DATADESC();
 
};
{{note|A switchable light is a light with a targetname, that can be triggered to turn on/off.}}
 
--- mod/src/dlls/hl2mp_dll/grenade_tripmine.cpp 18 Feb 2005 04:45:51 -0000 1.1.1.1
'''Fix:''' Fix unknown
+++ mod/src/dlls/hl2mp_dll/grenade_tripmine.cpp 22 Jul 2006 22:32:28 -0000
 
@@ -91,6 +91,8 @@
 
  m_vecEnd = GetAbsOrigin() + m_vecDir * 2048;
 
== Sticky Player Collisions / No lagcompensation ==
{{note|In the SDK-code of August 06, there is no StartLagCompensation() call.}}
I've been chasing a fix for this for months for Dystopia, when two players collide with each other there's massive prediction errors and to the player it looks like they're jerking back and forth. It can mean real trouble when two players attempt to get through a doorway or something, and it sucks if you're trying to do a good melee system.
 
Anyways, I found out the cause of this problem is on the server, when it runs a players movement code, it first unlags all the other players on the server, presumably to help predict player vs. player collisions. The problem is, because two players have different pings, there's no authoritative point of impact for the collision, so the jerking around you see is caused by this unlagging. Now down to the fix, which is really simple:
 
player_command.cpp Line 42
<pre>
// Move other players back to history positions based on local player's lag
- lagcompensation->StartLagCompensation( player, cmd );
</pre>
 
player_command.cpp Line 52
<pre>
// Restore other players to current positions
- lagcompensation->FinishLagCompensation( player );
</pre>
 
player_command.cpp Line 348
// Let server invoke any needed impact functions
  moveHelper->ProcessImpacts();
   
   
  AddEffects( EF_NOSHADOW );
+ // Only do unlag for post think/post frame, which is mainly weapons stuff! - Teddy
+
+ lagcompensation->StartLagCompensation( player, '''u'''cmd );
+    m_pAttachedObject = NULL;
  RunPostThink( player );
}
+ lagcompensation->FinishLagCompensation( player );
   
   
  FinishCommand( player );
@@ -224,7 +226,27 @@
 
return;
Pretty simple huh? You only need unlag for weapons really, and all the weapon hitscan code is run from the weapon's ItemPostFrame which is what the RunPostThink() runs. Let me know if it works for you! --[[User:Teddy|Teddy]] 20:05, 12 Jun 2006 (PDT)
  }
 
I added this fix to the latest version of the SDK (as of January, 2007) and I did not notice any difference. I believe this issue may have already been addressed in the latest SDK so this fix is uneccessary if you are running the latest SDK code. [User: Minh]
- SetNextThink( gpGlobals->curtime + 0.05f );
 
+    // Detonate if the parent object moves
== Minor/misc code neatenings/fixings ==
+    if (
 
+        m_pAttachedObject
(This section is for issues in the codebase that you've spotted to be potentially dangerous but aren't actually causing obvious bugs/issues... every little improvement to the quality of the codebase helps, right?)
+        && (
 
+              !VectorsAreEqual(m_vecOldPosAttachedObject, m_pAttachedObject->GetAbsOrigin(), 1.0f)
/src/cl_dll/game_controls/spectatorgui.cpp(508): The memset is setting twice as much memory as it should be to 0x0 because sizeof(playerName) already accounts for the fact that the elements are wchar_t type. '''Fix:''' Remove the "* sizeof( wchar_t)".
+            || !QAnglesAreEqual(m_vecOldAngAttachedObject, m_pAttachedObject->GetAbsAngles(), 1.0f)
 
+        )
== filter_damage_type doesn't work ==
+    ) {
Open <code>dlls/filters.cpp</code> and replace
+        m_iHealth = 0;
 
+        Event_Killed(CTakeDamageInfo((CBaseEntity*)m_hOwner, this, 100, GIB_NORMAL));
<pre>
+        return;
return info.GetDamageType() == m_iDamageType;
+    }
</pre>
+
 
+ SetNextThink(gpGlobals->curtime + 0.05f);
with
+}
 
+
<pre>
+void CTripmineGrenade::AttachToEntity(const CBaseEntity* const ent) {
return ( (info.GetDamageType() & m_iDamageType ) ? true : false );
+    Assert(m_pAttachedObject == NULL);
</pre>
+    m_pAttachedObject = ent;
 
+    m_vecOldPosAttachedObject = ent->GetAbsOrigin();
== Floating SLAM's ==
+    m_vecOldAngAttachedObject = ent->GetAbsAngles();
When attaching a SLAM at a movable object, it doesn't explode when the object moves and so give a "floating SLAM".
}
 
'''Fix:'''
int CTripmineGrenade::OnTakeDamage_Alive( const CTakeDamageInfo &info )
<pre>
--- mod/src/dlls/hl2mp_dll/grenade_tripmine.h 18 Feb 2005 04:45:51 -0000 1.1.1.1
--- mod/src/dlls/hl2_dll/grenade_tripmine.h 18 Feb 2005 04:45:51 -0000 1.1.1.1
+++ mod/src/dlls/hl2mp_dll/grenade_tripmine.h 22 Jul 2006 22:32:28 -0000
+++ mod/src/dlls/hl2_dll/grenade_tripmine.h 22 Jul 2006 22:32:28 -0000
@@ -36,6 +36,8 @@
@@ -36,6 +36,8 @@
  void MakeBeam( void );
  void MakeBeam( void );
Line 1,644: Line 1,680:
+    void AttachToEntity(const CBaseEntity* const ent);
+    void AttachToEntity(const CBaseEntity* const ent);
+
+
  public:
public:
  EHANDLE m_hOwner;
EHANDLE m_hOwner;
   
@@ -49,6 +51,10 @@
@@ -49,6 +51,10 @@
  Vector m_posOwner;
Vector m_posOwner;
  Vector m_angleOwner;
Vector m_angleOwner;
   
+    const CBaseEntity* m_pAttachedObject;
+    const CBaseEntity* m_pAttachedObject;
+    Vector m_vecOldPosAttachedObject;
+    Vector m_vecOldPosAttachedObject;
+    QAngle m_vecOldAngAttachedObject;
+    QAngle m_vecOldAngAttachedObject;
+
+
  DECLARE_DATADESC();
DECLARE_DATADESC();
  };
};
   
--- mod/src/game_shared/hl2mp/weapon_slam.cpp 17 Jun 2006 17:51:06 -0000 1.6
--- mod/src/dlls/hl2mp_dll/grenade_tripmine.cpp 18 Feb 2005 04:45:51 -0000 1.1.1.1
+++ mod/src/game_shared/hl2mp/weapon_slam.cpp 22 Jul 2006 22:32:28 -0000
+++ mod/src/dlls/hl2mp_dll/grenade_tripmine.cpp 22 Jul 2006 22:32:28 -0000
@@ -371,6 +371,7 @@
@@ -91,6 +91,8 @@
  CBaseEntity *pEnt = CBaseEntity::Create( "npc_tripmine", tr.endpos + tr.plane.normal * 3, angles, NULL );
m_vecEnd = GetAbsOrigin() + m_vecDir * 2048;
   
  CTripmineGrenade *pMine = (CTripmineGrenade *)pEnt;
AddEffects( EF_NOSHADOW );
+            pMine->AttachToEntity(pEntity);
+
  pMine->m_hOwner = GetOwner();
+    m_pAttachedObject = NULL;
             pMine->SetDamage(pOwner->get_damage(AOA_SLAM));
}
  #endif
</pre>
@@ -224,7 +226,27 @@
return;
}
- SetNextThink( gpGlobals->curtime + 0.05f );
+    // Detonate if the parent object moves
+    if (
+        m_pAttachedObject
+        && (
+              !VectorsAreEqual(m_vecOldPosAttachedObject, m_pAttachedObject->GetAbsOrigin(), 1.0f)
+            || !QAnglesAreEqual(m_vecOldAngAttachedObject, m_pAttachedObject->GetAbsAngles(), 1.0f)
+        )
+    ) {
+        m_iHealth = 0;
+        Event_Killed(CTakeDamageInfo((CBaseEntity*)m_hOwner, this, 100, GIB_NORMAL));
+        return;
+    }
+
+ SetNextThink(gpGlobals->curtime + 0.05f);
+}
+
+void CTripmineGrenade::AttachToEntity(const CBaseEntity* const ent) {
+    Assert(m_pAttachedObject == NULL);
+    m_pAttachedObject = ent;
+    m_vecOldPosAttachedObject = ent->GetAbsOrigin();
+    m_vecOldAngAttachedObject = ent->GetAbsAngles();
}
int CTripmineGrenade::OnTakeDamage_Alive( const CTakeDamageInfo &info )
--- mod/src/dlls/hl2mp_dll/grenade_tripmine.h 18 Feb 2005 04:45:51 -0000 1.1.1.1
+++ mod/src/dlls/hl2mp_dll/grenade_tripmine.h 22 Jul 2006 22:32:28 -0000
@@ -36,6 +36,8 @@
void MakeBeam( void );
void KillBeam( void );
+    void AttachToEntity(const CBaseEntity* const ent);
+
  public:
  EHANDLE m_hOwner;
   
@@ -49,6 +51,10 @@
  Vector m_posOwner;
  Vector m_angleOwner;
   
+    const CBaseEntity* m_pAttachedObject;
+    Vector m_vecOldPosAttachedObject;
+    QAngle m_vecOldAngAttachedObject;
+
  DECLARE_DATADESC();
  };
   
--- mod/src/game_shared/hl2mp/weapon_slam.cpp 17 Jun 2006 17:51:06 -0000 1.6
+++ mod/src/game_shared/hl2mp/weapon_slam.cpp 22 Jul 2006 22:32:28 -0000
@@ -371,6 +371,7 @@
  CBaseEntity *pEnt = CBaseEntity::Create( "npc_tripmine", tr.endpos + tr.plane.normal * 3, angles, NULL );
   
  CTripmineGrenade *pMine = (CTripmineGrenade *)pEnt;
+            pMine->AttachToEntity(pEntity);
  pMine->m_hOwner = GetOwner();
             pMine->SetDamage(pOwner->get_damage(AOA_SLAM));
  #endif
</pre>
 
== Assertion Failed in utlbuffer.cpp ==
'''[ISSUE]''' An assertion is thrown from the following location in <code>utlbuffer.cpp</code>:
<source lang=cpp highlight=4>
CUtlBuffer::CUtlBuffer( const void *pBuffer, int nSize, int nFlags ) :
m_Memory( (unsigned char*)pBuffer, nSize ), m_Error(0)
{
        Assert( nSize != 0 );
 
...
}
</source>
 
 
'''[FIX]''' Change the source to:
<source lang=cpp highlight=4>
CUtlBuffer::CUtlBuffer( const void *pBuffer, int nSize, int nFlags ) :
m_Memory( (unsigned char*)pBuffer, nSize ), m_Error(0)
{
        Assert( nSize >= 0 );
 
...
}
</source>
 
 
However, there appears to be a separate issue with dependencies in the VS project. For example, selecting <code>Build Solution</code> may not reflect the above changes when running the project. For a temporary workaround, select <code>Rebuild Solution</code> and then <code>Build Solution</code>. The expected behavior is that rebuilding will produce a linker error about <code>tier1.lib</code>, but building afterwards will succeed.
 
 
'''[TODO]''' Investigate VS project dependencies to come up with a fix that avoids having to rebuild the solution.
 
== Constant physprops->GetSurfaceData( ) on Linux ==
The physprops->GetSurfaceData( ) for a trace returns always CHAR_TEX_CONCRETE on Linux with SDK 2007. The surface type is correctly detected on Windows though.
This should be fixed in 2009 according to: [http://store.steampowered.com/news/4015/].
 
== Cannot re-ignite entities ==
There's a glich in SDK that does not call Extinguish() on entity once fire goes out, because it always returns NULL pointer, this causes inability to ignite same entity again. To fix this without changing header go to EntityFlame.cpp line 286.
{{Warning|Not only can you re-ignite entities in latest SDK version, but the game will crash if this edit is applied.}}
Replace this
 
<pre>
if ( m_hEntAttached )
{
CBaseCombatCharacter *pAttachedCC = m_hEntAttached->MyCombatCharacterPointer();
 
if( pAttachedCC )
{
// Notify the NPC that it's no longer burning!
pAttachedCC->Extinguish();
}
}
</pre>
 
with this
 
<pre>
if ( m_hEntAttached )
{
//Cannot directly cast networked variables
CBaseEntity *temp = m_hEntAttached;
CBaseCombatCharacter *pAttachedCC = (CBaseCombatCharacter *)temp;
 
if( pAttachedCC )
{
// Notify the NPC that it's no longer burning!
pAttachedCC->Extinguish();
}
}
</pre>
 
== Other info and links ==
 
See also [[Core Known Issues List]] for the list of issues in the closed-source HL2 Core engine.


== Other info and links ==
See also [[SDK Known Issues List Fixed]] for the list of SDK Known Issues fixed in new SDK revisions.


See also this nice general [http://forums.steampowered.com/forums/showthread.php?threadid=248425 HL2 bug list] on the steam forums.  Many of the issues seem imbedded down inside the closed-source side of things, so they are outside the scope of this SDK Known Issues list.  
See also this nice general [http://forums.steampowered.com/forums/showthread.php?threadid=248425 HL2 bug list] on the steam forums.  Many of the issues seem imbedded down inside the closed-source side of things, so they are outside the scope of this SDK Known Issues list.  
Line 1,679: Line 1,850:


[[Category:Debugging]] [[Category:Feedback]] [[Category:Programming]] [[Category:Source SDK FAQ]]
[[Category:Debugging]] [[Category:Feedback]] [[Category:Programming]] [[Category:Source SDK FAQ]]
[[Category:Lists]]

Latest revision as of 12:08, 20 May 2023

Note.pngNote:This page is for the SDK code. For the SDK tools, see Source SDK Known Issues. For the HL2 core, see the Core Known Issues List or the HL2 Bugzilla.

The patches listed here are in unidiff format.

First pass at compiling server_hl2mp-2005.vcproj under Linux

Preconditions

Setup the SDK as desribed in http://developer.valvesoftware.com/wiki/Compiling_under_Linux but obtained with "Modify Half-Life 2 Multiplayer" instead of "Source code only (advanced users only)". Obtained and compiled as of Sunday, February the 15th, 2009. Using Debian Lenny.

Issues

../dlls/lightglow.cpp:57: error: 'SendProxy_Angles' was not declared in this scope

Ambiguous function pointer. One probable fix could be to add '0, ' before the inclined call and add an 'extern ' declaration of the inclined function.

/usr/include/c++/3.4/limits:292:22: macro "max" requires 2 arguments, but only 1 given

In file included from /usr/include/c++/3.4/memory:61, from /usr/include/c++/3.4/string:48, from ../dlls/../public/stdstring.h:26, from ../dlls/ai_playerally.h:18, from ../dlls/npc_talker.h:34, from ../dlls/npc_talker.cpp:10 Maybe fixed by commenting out #include <set> in ../dlls/npc_talker.h

../game_shared/gamestats/ep1_gamestats.h:14:27: tier1/UtlDict.h: No such file or directory

In file included from ../dlls/../game_shared/gamestats/ep1_gamestats.cpp:7. Probably because public is not part of the path. Probably also because of case sensitivity. Fix: 

ln -s ../public/tier1 tier1
ln ../public/tier1/utlbuffer.h tier1/UtlBuffer.h
ln ../public/tier1/utldict.h tier1/UtlDict.h

../dlls/episodic/grenade_hopwire.h:14:20: sprite.h: No such file or directory

In file included from ../dlls/episodic/grenade_hopwire.cpp:8 Fix: 

ln ../game_shared/Sprite.h ../game_shared/sprite.h

The compile completed after these issues in the first pass.

Issues only with SDK 2006-08-04

Assert whenever Gravity Gun is holding a crate/barrel that explodes

See bugzilla [1].

Assert: no supported muzzle flash for the type specified

This is apparently a bug in the HL2 model so looks like there's nothing to be done but comment out the assert. 

--- src/cl_dll/c_te_legacytempents.cpp      26 Aug 2006 21:24:22 -0000      1.5
+++ src/cl_dll/c_te_legacytempents.cpp      27 Aug 2006 19:31:35 -0000
@@ -1676,7 +1676,7 @@

        default:
                // There's no supported muzzle flash for the type specified!
-               Assert(0);
+               // Assert(0);
                break;
        }

Assert( i >= 0 && i < GetNumSeq() )

Once again this is apparently a bug in the HL2 model so looks like there's nothing to be done but comment out the assert. 

--- src/public/studio.cpp 26 Aug 2006 21:24:47 -0000      1.3
+++ src/public/studio.cpp 27 Aug 2006 19:44:53 -0000
@@ -783,7 +783,7 @@

 mstudioseqdesc_t &CStudioHdr::pSeqdesc( int i ) const
 {
-       Assert( i >= 0 && i < GetNumSeq() );
+       // Assert( i >= 0 && i < GetNumSeq() );

        if (m_pVModel == NULL)
        {


dm_powerhouse lamps lay on the ground

This was first reported on the Steam Forums HL2 bug list, including this screenshot.

Since updating the SDK the bug now occurs in my mod.

It's been obvious for a long time that the dm_powerhouse map was broken (see #dm_powerhouse_lights_never_slow_down). Looks like Valve was attempting to out-think broken maps, but only made things worse. See the #dm_powerhouse_lights_never_slow_down KI for the real dm_powerhouse bug fix. Meanwhile here's the bugfix to undo the latest SDK breakage: 

--- src/dlls/physconstraint.cpp 26 Aug 2006 21:24:31 -0000      1.4
+++ src/dlls/physconstraint.cpp 2 Sep 2006 22:50:09 -0000
@@ -437,8 +437,6 @@
                if ( Q_strlen(STRING(m_nameAttach1)) )
                {
                        Warning("Bogus constraint %s (attaches %s to %s)\n", GetDebugName(), STRING(m_nameAttach1), STRING(m_nameAttach2));
-                       info.pObjects[0] = info.pObjects[1] = NULL;
-                       return;
                }
                info.pObjects[0] = g_PhysWorldObject;
                info.massScale[0] = info.massScale[1] = 1.0f; // no mass scale on world constraint
@@ -448,8 +446,6 @@
                if ( Q_strlen(STRING(m_nameAttach2)) )
                {
                        Warning("Bogus constraint %s (attaches %s to %s)\n", GetDebugName(), STRING(m_nameAttach1), STRING(m_nameAttach2));
-                       info.pObjects[0] = info.pObjects[1] = NULL;
-                       return;
                }
                info.pObjects[1] = info.pObjects[0];
                info.pObjects[0] = g_PhysWorldObject;           // Try to make the world object consistently object0 for ease of implementation

IsFrameLocking assert

If you commented out the AssertOnce( pModelCache->IsFrameLocking() ); asserts, uncommented them. According to Jay at Valve the core is allowed to delete a GetModelPtr() pointer at any time unless you're inside the lock, therefore all of these fixes below are potential crashers. 

--- mod/src/cl_dll/prediction.cpp       3 Sep 2006 01:31:56 -0000       1.5
+++ mod/src/cl_dll/prediction.cpp       16 Sep 2006 18:56:39 -0000
@@ -212,6 +212,8 @@
 void CPrediction::ShutdownPredictables( void )
 {
 #if !defined( NO_ENTITY_PREDICTION )
+    MDLCACHE_CRITICAL_SECTION();
+
        // Transfer intermediate data from other predictables
        int c = predictables->GetPredictableCount();
        int i;

and... 

--- src/game_shared/baseplayer_shared.cpp       26 Aug 2006 21:24:36 -0000      1.28
+++ src/game_shared/baseplayer_shared.cpp       4 Sep 2006 18:53:21 -0000
@@ -749,6 +749,8 @@
 //-----------------------------------------------------------------------------
 bool CBasePlayer::Weapon_Switch( CBaseCombatWeapon *pWeapon, int viewmodelindex /*=0*/ )
 {
+    MDLCACHE_CRITICAL_SECTION();
+ 
        CBaseCombatWeapon *pLastWeapon = GetActiveWeapon();
 
        if ( BaseClass::Weapon_Switch( pWeapon, viewmodelindex ))
 
 

--- src/cl_dll/c_baseanimating.cpp	2 Sep 2006 23:11:26 -0000	1.9
+++ src/cl_dll/c_baseanimating.cpp	3 Sep 2006 01:00:52 -0000
@@ -3919,6 +3919,8 @@
 {
 	VPROF( "C_BaseAnimating::TestCollision" );
 
+    MDLCACHE_CRITICAL_SECTION();
+
 	CStudioHdr *pStudioHdr = GetModelPtr();
 	if (!pStudioHdr)
 		return false;


--- src/cl_dll/prediction.cpp	26 Aug 2006 21:24:24 -0000	1.4
+++ src/cl_dll/prediction.cpp	3 Sep 2006 01:00:52 -0000
@@ -19,6 +19,7 @@
 #include "in_buttons.h"
 #include "con_nprint.h"
 #include "hud_pdump.h"
+#include "datacache/imdlcache.h"
 
 #ifdef HL2_CLIENT_DLL
 #include "c_basehlplayer.h"
@@ -1484,6 +1484,9 @@
 	//}
 
 	Assert( i >= 1 );
+
+    MDLCACHE_CRITICAL_SECTION();
+
 	while ( true )
 	{
 		// Incoming_acknowledged is the last usercmd the server acknowledged having acted upon


--- src/dlls/player_command.cpp	26 Aug 2006 21:24:31 -0000	1.5
+++ src/dlls/player_command.cpp	3 Sep 2006 01:00:54 -0000
@@ -14,6 +14,7 @@
 #include "movehelper_server.h"
 #include "iservervehicle.h"
 #include "tier0/vprof.h"
+#include "datacache/imdlcache.h"
 
 // memdbgon must be the last include file in a .cpp file!!!
 #include "tier0/memdbgon.h"
@@ -306,6 +307,8 @@
 //-----------------------------------------------------------------------------
 void CPlayerMove::RunCommand ( CBasePlayer *player, CUserCmd *ucmd, IMoveHelper *moveHelper )
 {
+    MDLCACHE_CRITICAL_SECTION();
+
 	StartCommand( player, ucmd );
 
 	// Set globals appropriately


--- src/dlls/hl2mp_dll/hl2mp_player.cpp	26 Aug 2006 21:24:35 -0000	1.43
+++ src/dlls/hl2mp_dll/hl2mp_player.cpp	3 Sep 2006 01:00:54 -0000
@@ -18,6 +18,7 @@
 #include "weapon_hl2mpbase.h"
 #include "grenade_satchel.h"
 #include "eventqueue.h"
+#include "datacache/imdlcache.h"
 
 #include "engine/IEngineSound.h"
 #include "SoundEmitterSystem/isoundemittersystembase.h"
@@ -504,6 +505,8 @@
 {
 	if ( IsAlive() )
 	{
+        MDLCACHE_CRITICAL_SECTION();
+
 		SetSequence ( -1 );
 		SetActivity( ACT_INVALID );
 


--- src/game_shared/basecombatweapon_shared.cpp	26 Aug 2006 21:24:35 -0000	1.9
+++ src/game_shared/basecombatweapon_shared.cpp	3 Sep 2006 01:00:54 -0000
@@ -1287,6 +1287,7 @@
 	float flSequenceDuration = 0;
 	if ( GetActivity() == ACT_VM_HOLSTER )
 	{
+        MDLCACHE_CRITICAL_SECTION();
 		flSequenceDuration = SequenceDuration();
 	}

AI_Activity.cpp assert on startup

Just before the "// Multiplayer" line, add the following: 

	ADD_ACTIVITY_TO_SR( ACT_MP_STAND_IDLE_PORTALGUN );
	ADD_ACTIVITY_TO_SR( ACT_MP_RUN_IDLE_PORTALGUN );
	ADD_ACTIVITY_TO_SR( ACT_MP_CROUCH_IDLE_PORTALGUN );
	ADD_ACTIVITY_TO_SR( ACT_MP_WALK_CROUCH_PORTALGUN );
	ADD_ACTIVITY_TO_SR( ACT_MP_GESTURE_RANGE_ATTACK_PORTALGUN );
	ADD_ACTIVITY_TO_SR( ACT_MP_GESTURE_RELOAD_PORTALGUN );
	ADD_ACTIVITY_TO_SR( ACT_MP_JUMP_PORTALGUN );

Will not compile on Linux

This was partially moved to Source SDK Known Issues#Linux_Support

Here's a better fix for the Linux build breaking without -O. Apparently using always_inline without -O intentionally breaks on GCC. There's no real need for this though - you're better off letting the compiler optimize at will anyway. 

--- src/public/tier0/platform.h  26 Aug 2006 21:24:48 -0000      1.5
+++ src/public/tier0/platform.h  28 Aug 2006 03:20:52 -0000
@@ -310,7 +310,7 @@
 #else
        #define  STDCALL
        #define  FASTCALL
-       #define  FORCEINLINE                    __attribute__ ((always_inline))
+       #define  FORCEINLINE                    inline
        // GCC 3.4.1 has a bug in supporting forced inline of templated functions
        // this macro lets us not force inlining in that case
        #define  FORCEINLINE_TEMPLATE

And some other issues... 

--- src/dlls/episodic/grenade_hopwire.h 2006-08-05 10:58:48.278875000 -0500
+++ src/dlls/episodic/grenade_hopwire.h 2006-08-13 23:09:41.000000000 -0500
@@ -11,7 +11,7 @@
 #endif

 #include "basegrenade_shared.h"
-#include "sprite.h"
+#include "Sprite.h"

 extern ConVar hopwire_trap;

--- src/game_shared/gamestats/ep1_gamestats.cpp  2006-08-05 10:59:06.075750000 -0500
+++ src/game_shared/gamestats/ep1_gamestats.cpp  2006-08-13 16:10:42.000000000 -0500
@@ -5,7 +5,7 @@
 //=============================================================================

 #include "gamestats/ep1_gamestats.h"
-#include "tier1/UtlBuffer.h"
+#include "tier1/utlbuffer.h"

 static int g_nParseVersion = -1;

@@ -194,4 +194,4 @@
                m_nDXLevel = (int)buf.GetShort();
        }
        return bret;
-}
\ No newline at end of file
+}

--- src/game_shared/gamestats/ep1_gamestats.h    2006-08-05 10:59:06.091375000 -0500
+++ src/game_shared/gamestats/ep1_gamestats.h    2006-08-13 16:10:52.000000000 -0500
@@ -11,7 +11,7 @@
 #endif

 class CUtlBuffer;
-#include "tier1/UtlDict.h"
+#include "tier1/utldict.h"

 #define GAMESTATS_FILE_VERSION_OLD             001
 #define GAMESTATS_FILE_VERSION_OLD2            002

That's all the compile bugs I encountered. Granted I was using my mod as a basis, so there might be other compile bugs I didn't see thanks to other fixes in my mod. If anyone else can confirm that's the complete list of fixes for a fresh SDK checkout, please do so.

Will not link fully on Linux

The lack of mathlib results in "undefined symbol: _Z9AngleDiffff" at runtime. There used to be a file called public/mathlib.cpp that exported that symbol, however that file is now complete gone and seemingly has no replacement. (There is a mathlib.lib which is of course useless for non-MSVC.)

Update: this was apparently an oversight - Valve intended to switch everything to libs...

Fix: Download these linuxlibs that Mike Durand provided (careful not to overwrite your existing Makefile), and apply this patch.

GameInfo.txt issues

This was moved to Source SDK Known Issues#SDK_Launcher_Issues

Animations are jittery

Open cl_dll/c_baseentity.cpp and remove the following code: 

if ( !IsSelfAnimating() ) 
{ 
        m_flAnimTime = engine->GetLastTimeStamp();       
}

HL2Gamerules()

When you are running a multiplayer mod, a call to HL2Gamerules(), without checking if the object valid, will probably crash. This happens because the function tries to static_cast g_pGamerules to the class CHalfLife2. However the gamerules of multiplay_gamerules.cpp or hl2dm_gamerules.cpp is used. As a result the casting fails and any calls to it crash. To fix this, you need to add a check to every call to this function.

Bullet impact sounds do not play to clients

In the PlayImpactSound function in cl_dll/fx_impact.cpp, replace: 

C_BaseEntity::EmitSound( filter, NULL, pbulletImpactSoundName, pdata->soundhandles.bulletImpact, &vecOrigin );

with: 

C_BaseEntity::EmitSound( filter, NULL, pbulletImpactSoundName, &vecOrigin );

This can also be observed as hearing the WateryDeath.Warn soundscript entry played while shooting at models with the "Weapon" surfaceprop when hosting a listen server in a map using level-specific soundscripts.

use of non-standard _stricmp in portable code block

Can someone confirm whether this patch works with a fresh SDK? I've removed Valve's inappropriate Makefile defines (see -Wall section) which may be what revealed this, or it might just be another Linux compilation DOA.

This stuffs up vc2003 again, and chucks up 1000's of warnings if you #ifdef WIN32 or #ifdef LINUX - only use this fix if you are in need of it! --Amckern 23:22, 2 Oct 2006 (PDT)
--- public/tier1/strtools.h     26 Aug 2006 21:30:57 -0000      1.1
+++ public/tier1/strtools.h     27 Aug 2006 03:33:54 -0000
@@ -98,7 +98,7 @@
 inline char*   V_strrchr  ( const char *s,     char c             ) { return strrchr( s, c );      }
 inline int     V_strcmp   ( const char *s1,    const char *s2     ) { return strcmp( s1, s2 );     }
 inline int     V_wcscmp   ( const wchar_t *s1, const wchar_t *s2  ) { return wcscmp( s1, s2 );     }
-inline int     V_stricmp  ( const char *s1,    const char *s2     ) { return _stricmp( s1, s2 );   }
+inline int     V_stricmp  ( const char *s1,    const char *s2     ) { return strcasecmp( s1, s2 ); }
 inline char*   V_strstr   ( const char *s1,    const char *search ) { return strstr( s1, search ); }
 inline char*   V_strupr   ( char *start )                           { return strupr( start );      }
 inline char*   V_strlower ( char *start )                           { return strlwr( start );      }

Missing activity ACT_HL2MP_GESTURE_RELOAD_CROSSBOW

This error happens because Valve never made crossbow reload animations for the playermodels, but told it to use ACT_HL2MP_GESTURE_RELOAD_CROSSBOW in the acttable anyway. 

--- sourcecode/trunk/game_shared/hl2mp/weapon_crossbow.cpp (revision 336)
+++ sourcecode/trunk/game_shared/hl2mp/weapon_crossbow.cpp (revision 357)
@@ -485,5 +485,5 @@
 	{ ACT_HL2MP_WALK_CROUCH,          ACT_HL2MP_WALK_CROUCH_CROSSBOW,          false },
 	{ ACT_HL2MP_GESTURE_RANGE_ATTACK, ACT_HL2MP_GESTURE_RANGE_ATTACK_CROSSBOW, false },
-	{ ACT_HL2MP_GESTURE_RELOAD,       ACT_HL2MP_GESTURE_RELOAD_CROSSBOW,       false },
+	{ ACT_HL2MP_GESTURE_RELOAD,       ACT_HL2MP_GESTURE_RELOAD_AR2,            false },
 	{ ACT_HL2MP_JUMP,                 ACT_HL2MP_JUMP_CROSSBOW,                 false },
 };

"Extra App ID set to 211, but no SteamAppID" while debugging

This issue happens when mounting multiple GCFs. The fix is to mount appid's in the negative. ie: -320 instead of 320.

Bot physics/hitbox not accurate

--- src/dlls/sdk/sdk_bot_temp.cpp       3 Sep 2006 02:18:03 -0000       1.3
+++ src/dlls/sdk/sdk_bot_temp.cpp       3 Sep 2006 02:36:29 -0000
@@ -52,6 +52,13 @@

        QAngle                  m_ForwardAngle;
        QAngle                  m_LastAngles;
+
+    virtual void PhysicsSimulate() {
+        BaseClass::PhysicsSimulate();
+
+        // Since this isn't called for bots.. call it here
+        UpdateVPhysicsPosition(m_vNewVPhysicsPosition, m_vNewVPhysicsVelocity, gpGlobals->frametime);
+    }
 };

 LINK_ENTITY_TO_CLASS( sdk_bot, CSDKBot );

Bot physics/hitbox not accurate: happens also on HL2MP mod with bots. Any fix for this?

Invalid Combine Ball vphysics

This is an old bug, but still exists in the new SDK. This might be the last of the vphysics bugs? 

--- dlls/hl2_dll/prop_combine_ball.h    2006-08-27 18:22:56.255500000 -0500
+++ dlls/hl2_dll/prop_combine_ball.h    2006-08-27 18:22:56.255500000 -0500
@@ -119,6 +119,8 @@

        // Pow!
        void DoExplosion( );
+       void DoExplosion_internal();
+    int OnTakeDamage(const CTakeDamageInfo &info);

        void StartAnimating( void );
        void StopAnimating( void );



--- dlls/hl2_dll/prop_combine_ball.cpp  2006-08-27 18:24:17.364875000 -0500
+++ dlls/hl2_dll/prop_combine_ball.cpp  2006-08-27 18:24:17.364875000 -0500
@@ -974,7 +974,18 @@
 //------------------------------------------------------------------------------
 // Pow!
 //------------------------------------------------------------------------------
-void CPropCombineBall::DoExplosion( )
+void CPropCombineBall::DoExplosion() {
+    // don't call DoExplosion() directly since we might be in a vphysics callback
+    TakeDamage(CTakeDamageInfo(this, this, 1, DMG_PREVENT_PHYSICS_FORCE));
+}
+
+int CPropCombineBall::OnTakeDamage(const CTakeDamageInfo &info) {
+    // now we're safely no longer in a vphysics callback
+    DoExplosion_internal();
+    return 0;
+}
+
+void CPropCombineBall::DoExplosion_internal()
 {
        // Tell the respawner to make a new one
        if ( GetSpawner() )

Wasted entitygroundcontact

It also seems that the code lets every client on the server calculate the minimum and maximum height of each animating entity and sends it to the server, while the server doesn't really need it. Each client calculates the same so it's waste of bandwidth.

It's better to test these changes very good because it's possible it may break something.

Note: Why not instead of compleatly removing it, having only 1 player to calculate it ? (if its a listen server then its the local player, if its a dedicated one what about the player who has been on the most :P/any random player ?) --Filip 06:43, 6 December 2012 (PST)

game_shared/usercmd.cpp

Remove: 

#if defined( HL2_CLIENT_DLL )
	if ( to->entitygroundcontact.Count() != 0 )
	{
		buf->WriteOneBit( 1 );
		buf->WriteShort( to->entitygroundcontact.Count() );
		int i;
		for (i = 0; i < to->entitygroundcontact.Count(); i++)
		{
			buf->WriteUBitLong( to->entitygroundcontact[i].entindex, MAX_EDICT_BITS );
			buf->WriteBitCoord( to->entitygroundcontact[i].minheight );
			buf->WriteBitCoord( to->entitygroundcontact[i].maxheight );
		}
		to->entitygroundcontact.RemoveAll();
	}
	else
	{
		buf->WriteOneBit( 0 );
	}
#endif
#if defined( HL2_DLL )
	if ( buf->ReadOneBit() )
	{
		// DM: Fix negative entitygroundcontact crash, from the VDC
		int count = buf->ReadShort();
        if ( count < 0 || count > 140 ) {
            Msg( "Ignoring strange entitygroundcontact count: %d\n", count );
            return; // why can this be less than 0, Valve? change to ReadWord()???
        }
		move->entitygroundcontact.SetCount( count );

		int i;
		for (i = 0; i < move->entitygroundcontact.Count(); i++)
		{
			move->entitygroundcontact[i].entindex = buf->ReadUBitLong( MAX_EDICT_BITS );
			move->entitygroundcontact[i].minheight = buf->ReadBitCoord( );
			move->entitygroundcontact[i].maxheight = buf->ReadBitCoord( );
		}
	}
#endif

game_shared/usercmd.h

Remove: 

class CEntityGroundContact
{
public:
	int					entindex;
	float				minheight;
	float				maxheight;
};
#if defined( HL2_DLL ) || defined( HL2_CLIENT_DLL )
		entitygroundcontact.RemoveAll();
#endif
#if defined( HL2_DLL ) || defined( HL2_CLIENT_DLL )
		entitygroundcontact			= src.entitygroundcontact;
#endif
#if defined( HL2_DLL ) || defined( HL2_CLIENT_DLL )
	CUtlVector< CEntityGroundContact > entitygroundcontact;
#endif

dlls/player_command.cpp

Remove: 

#if defined (HL2_DLL)
	// pull out backchannel data and move this out

	int i;
	for (i = 0; i < cmd->entitygroundcontact.Count(); i++)
	{
		int entindex =  cmd->entitygroundcontact[i].entindex;
		CBaseEntity *pEntity = CBaseEntity::Instance( engine->PEntityOfEntIndex( entindex) );
		if (pEntity)
		{
			CBaseAnimating *pAnimating = pEntity->GetBaseAnimating();
			if (pAnimating)
			{
				pAnimating->SetIKGroundContactInfo( cmd->entitygroundcontact[i].minheight, cmd->entitygroundcontact[i].maxheight );
			}
		}
	}

#endif

cl_dll/input.h

Remove:

#if defined( HL2_CLIENT_DLL ) 
        CUtlVector< CEntityGroundContact > m_EntityGroundContact; 
#endif

cl_dll/in_main.cpp

Comment out the entire function CInput::AddIKGroundContactInfo

Resizing game window glitches HUD elements

Fix: 

--- mod/src/cl_dll/game_controls/vgui_TeamFortressViewport.cpp  21 Feb 2006 01:58:36 -0000      1.6
+++ mod/src/cl_dll/game_controls/vgui_TeamFortressViewport.cpp  16 Jul 2006 20:52:44 -0000
@@ -152,6 +152,9 @@
        m_pBackGround->SetZPos( -20 ); // send it to the back
        m_pBackGround->SetVisible( false );
        CreateDefaultPanels();
+
+       // reload again... this fixes the ammo display etc
+       ReloadScheme( NULL );
 }

Mod fails to compile with gcc 4.x

Note.pngNote:Even if you apply these fixes, gcc 4 still won't work. However both of these fixes seem reasonable on 3.x as well.

Fix: First pass problem is a code bug - not sure if this would've shown up in gcc 3.x if Valve didn't use the horribly evil -w option, but it certainly looks like invalid code to reference a friend function without a declaration. 

--- mod/src/dlls/baseentity.h   2005/08/29 00:14:40     1.3
+++ mod/src/dlls/baseentity.h   2006/06/07 02:17:03
@@ -325,6 +325,9 @@
 #define CREATE_PREDICTED_ENTITY( className )   \
        CBaseEntity::CreatePredictedEntityByName( className, __FUNCTION__, __LINE__ );

+void SendProxy_Origin( const SendProp *pProp, const void *pStruct, const void *pData, DVariant *pOut, int iElement, int objectID );
+void SendProxy_Angles( const SendProp *pProp, const void *pStruct, const void *pData, DVariant *pOut, int iElement, int objectID );
+
 //
 // Base Entity.  All entity types derive from this
 //

Looks like the only other issue was this asm change. Apparently gcc did something slightly backwards incompatible in 4.x. 

--- src/public/mathlib.cpp      18 Feb 2005 04:45:56 -0000      1.1.1.1
+++ src/public/mathlib.cpp      11 Jun 2006 19:45:34 -0000
@@ -436,7 +436,6 @@
                "movss %%xmm0, %0 \n\t"
                : "=m" (x)
                : "m" (rroot)
-               : "%xmm0"
        );
 #else
 #error

Case changes in player names cause chat truncation

--- mod/src/cl_dll/hl2mp/hl2mp_hud_chat.cpp     2006/02/21 01:58:38     1.3
+++ mod/src/cl_dll/hl2mp/hl2mp_hud_chat.cpp     2006/03/28 03:11:13
@@ -422,8 +422,9 @@
        else
                line->InsertColorChange( Color( g_ColorYellow[0], g_ColorYellow[1], g_ColorYellow[2], 255 ) );

-       char *buf = static_cast<char *>( stackalloc( strlen( pmsg ) + 1  ) );
-       wchar_t *wbuf = static_cast<wchar_t *>( stackalloc( (strlen( pmsg ) + 1 ) * sizeof(wchar_t) ) );
+       char buf[4096];
+       wchar_t wbuf[4096];
+       Assert(strlen(pmsg) < sizeof(buf)); // otherwise message truncation will occur
        if ( buf )
        {
                float *flColor = GetClientColor( iPlayerIndex );
@@ -435,10 +436,10 @@
                buf[ min( iNameLength, MAX_PLAYER_NAME_LENGTH+31) ] = 0;
                line->InsertColorChange( Color( flColor[0], flColor[1], flColor[2], 255 ) );
                line->InsertString( buf );
-               Q_strncpy( buf, pmsg + iNameLength, strlen( pmsg ));
+               Q_strncpy(buf, pmsg + iNameLength, sizeof(buf));
                buf[ strlen( pmsg + iNameLength ) ] = '\0';
                line->InsertColorChange( Color( g_ColorYellow[0], g_ColorYellow[1], g_ColorYellow[2], 255 ) );
-               vgui::localize()->ConvertANSIToUnicode( buf, wbuf, strlen(pmsg)*sizeof(wchar_t));
+               vgui::localize()->ConvertANSIToUnicode( buf, wbuf, sizeof(wbuf));
                line->InsertString( wbuf );
                line->SetVisible( true );
                line->SetNameLength( iNameLength );

--- mod/src/tier1/stringpool.cpp        2005/02/18 04:45:59     1.1.1.1
+++ mod/src/tier1/stringpool.cpp        2006/03/28 03:25:05
@@ -22,7 +22,7 @@

 bool StrLess( const char * const &pszLeft, const char * const &pszRight )
 {
-       return ( Q_stricmp( pszLeft, pszRight) < 0 );
+       return ( Q_strcmp( pszLeft, pszRight) < 0 );
 }

 //-----------------------------------------------------------------------------
--- mod/src/cl_dll/sdk/sdk_hud_chat.cpp	2006/02/21 01:58:38	1.3
+++ mod/src/cl_dll/sdk/sdk_hud_chat.cpp	2006/03/28 03:34:35
@@ -422,8 +422,9 @@
 	else
 		line->InsertColorChange( Color( g_ColorYellow[0], g_ColorYellow[1], g_ColorYellow[2], 255 ) );
 
-	char *buf = static_cast<char *>( stackalloc( strlen( pmsg ) + 1  ) );
-	wchar_t *wbuf = static_cast<wchar_t *>( stackalloc( (strlen( pmsg ) + 1 ) * sizeof(wchar_t) ) );
+	char buf[4096];
+	wchar_t wbuf[4096];
+    assert(strlen(pmsg) < sizeof(buf)); // otherwise message truncation will occur
 	if ( buf )
 	{
 		float *flColor = GetClientColor( iPlayerIndex );
@@ -435,10 +436,10 @@
 		buf[ min( iNameLength, MAX_PLAYER_NAME_LENGTH+31) ] = 0;
 		line->InsertColorChange( Color( flColor[0], flColor[1], flColor[2], 255 ) );
 		line->InsertString( buf );
-		Q_strncpy( buf, pmsg + iNameLength, strlen( pmsg ));
+		Q_strncpy(buf, pmsg + iNameLength, sizeof(buf));
 		buf[ strlen( pmsg + iNameLength ) ] = '\0';
 		line->InsertColorChange( Color( g_ColorYellow[0], g_ColorYellow[1], g_ColorYellow[2], 255 ) );
-		vgui::localize()->ConvertANSIToUnicode( buf, wbuf, strlen(pmsg)*sizeof(wchar_t));
+		vgui::localize()->ConvertANSIToUnicode( buf, wbuf, sizeof(wbuf));
 		line->InsertString( wbuf );
 		line->SetVisible( true );
 		line->SetNameLength( iNameLength );
Note.pngNote:I've never actually tested the patch to sdk_hud_chat.cpp, but the code is identical to hl2mp_hud_chat.cpp so it should work.

dm_powerhouse lights never slow down

Workaround: Really this should be fixed in the map, but good luck waiting on that to happen. In the mean time here's a code patch for any such mapping errors: 

--- mod/src/dlls/physconstraint.cpp     2005/03/26 17:44:28     1.2
+++ mod/src/dlls/physconstraint.cpp     2006/03/06 02:45:47
@@ -727,6 +727,16 @@
                for ( int i = 0; i < 2; i++ )
                {
                        info.pObjects[i]->WorldToLocal( &ballsocket.constraintPosition[i], GetAbsOrigin() );
+            // HACKHACK - the mapper forgot to put in some sane physics damping (dm_powerhouse)
+            float damping, adamping;
+            info.pObjects[i]->GetDamping(&damping, &adamping);
+            if (damping < .2f) {
+                damping = .2f;
+            }
+            if (adamping < .2f) {
+                adamping = .2f;
+            }
+            info.pObjects[i]->SetDamping(&damping, &damping);
                }
                GetBreakParams( ballsocket.constraint, info );
                ballsocket.constraint.torqueLimit = 0;

Wall Boosting Exploit

Hi, everyone would of no doubt noticed that running against a wall(strafing and moving forward works best) makes you run really fast. If anyone has played kreedz climbing yet(I used to code for it) you might of noticed moving against walls is jerky. I think when I was adding some things to the movement I made the server and client disagree on what speed the player is moving at. Has anyone sound why players in source do this? where the boost might be clamped to normal levels? If so I'd love to know, and it would be good to know for bg2 as well, people who play it complain a lot of it as well(just the boost, not client prediction jerks).

Fix Provided by Tony "omega" Sergi

mod/game_shared/gamemovement.cpp Line 1374 

void CGameMovement::Accelerate( Vector& wishdir, float wishspeed, float
accel )
{
	int i;
	float addspeed, accelspeed, currentspeed;

	// This gets overridden because some games (CSPort) want to allow dead (observer) players
	// to be able to move around.
	if ( !CanAccelerate() )
		return;

	//omega; WALLSTRAFE FIX

	// See if we are changing direction a bit
	//	currentspeed = mv->m_vecVelocity.Dot(wishdir);

	currentspeed = sqrt( DotProduct(mv->m_vecVelocity, mv->m_vecVelocity) );
	//omega; END WALLSTRAFE FIX

	// Reduce wishspeed by the amount of veer.


GNU crasher for maps with broken ladders

Fix: Valve's code is invalid but compiles on MSVC due to its D.W.I.M. philosophy. The following patch is required: 

--- mod/src/game_shared/func_ladder.cpp 2005/06/11 22:14:32     1.2
+++ mod/src/game_shared/func_ladder.cpp 2006/02/12 19:43:25
@@ -87,7 +87,7 @@
                                m_vecPlayerMountPositionBottom.GetZ(),
                                bottomtrace.m_pEnt
                                        ?
-                                       UTIL_VarArgs( "%s/%s", bottomtrace.m_pEnt->GetClassname(), bottomtrace.m_pEnt->GetEntityName() )
+                                       UTIL_VarArgs( "%s/%s", bottomtrace.m_pEnt->GetClassname(), STRING(bottomtrace.m_pEnt->GetEntityName()) )
                                        :
                                        "NULL" );
                }
@@ -99,7 +99,7 @@
                                m_vecPlayerMountPositionTop.GetZ(),
                                toptrace.m_pEnt
                                        ?
-                                       UTIL_VarArgs( "%s/%s", toptrace.m_pEnt->GetClassname(), toptrace.m_pEnt->GetEntityName() )
+                                       UTIL_VarArgs( "%s/%s", toptrace.m_pEnt->GetClassname(), STRING(toptrace.m_pEnt->GetEntityName()) )
                                        :
                                        "NULL" );
                }

sdkshaders: fix for spaces in path

Issue: Any attempt to compile the SDK shaders for a mod with spaces in the path name results in failure:

(ie: "C:\Program Files\Steam\SteamApps\SourceMods\MODNAME\src\src\sdkshaders")

This is due to the fact that the perl scripts and bat files have not been properly modified to handle spaces in the path.


Fix: Ray "VisualPhoenix" Barbiero has provided the following patches:

Note.pngNote:These patches have been tested on paths with and without spaces.

updateshaders.pl

--- mod/src/devtools/bin/updateshaders.pl	2005-07-14 09:58:54.000000000 -0500
+++ mod/src/devtools/bin/updateshaders.pl	2005-10-11 23:42:36.000000000 -0500
@@ -105,7 +105,7 @@
 	{
 		$xboxswitch = "-xbox ";
 	}
-	print MAKEFILE "\t$g_SourceDir\\devtools\\bin\\perl.exe $g_SourceDir\\devtools\\bin\\" . $shadertype . "_prep.pl $xboxswitch -shaderoutputdir $shaderoutputdir -source \"$g_SourceDir\" $shadername\n";
+	print MAKEFILE "\t\"$g_SourceDir\\devtools\\bin\\perl.exe\" \"$g_SourceDir\\devtools\\bin\\" . $shadertype . "_prep.pl\" $xboxswitch -shaderoutputdir $shaderoutputdir -source \"$g_SourceDir\" $shadername\n";
 	my $filename;
 	if( $shadertype eq "fxc" )
 	{
@@ -199,14 +199,14 @@
 		# We only generate inc files for fxc and vsh files.
 		if( $g_xbox )
 		{
-			print MAKEFILE " $shadertype" . "tmp_xbox\\" . $shaderbase . "\.inc";
+			print MAKEFILE " \"$shadertype" . "tmp_xbox\\" . $shaderbase . "\.inc\"";
 		}
 		else
 		{
-			print MAKEFILE " $shadertype" . "tmp9\\" . $shaderbase . "\.inc";
+			print MAKEFILE " \"$shadertype" . "tmp9\\" . $shaderbase . "\.inc\"";
 		}
 	}
-	print MAKEFILE " $shaderoutputdir\\$shadertype\\$shaderbase\.vcs";
+	print MAKEFILE " \"$shaderoutputdir\\$shadertype\\$shaderbase\.vcs\"";
 }
 print MAKEFILE "\n\n";
 
@@ -221,11 +221,11 @@
 		# We only generate inc files for fxc and vsh files.
 		if( $g_xbox )
 		{
-			print MAKEFILE "\tdel /f /q $shadertype" . "tmp_xbox\\" . $shaderbase . "\.inc\n";
+			print MAKEFILE "\tdel /f /q \"$shadertype" . "tmp_xbox\\" . $shaderbase . "\.inc\"\n";
 		}
 		else
 		{
-			print MAKEFILE "\tdel /f /q $shadertype" . "tmp9\\" . $shaderbase . "\.inc\n";
+			print MAKEFILE "\tdel /f /q \"$shadertype" . "tmp9\\" . $shaderbase . "\.inc\"\n";
 		}
 	}
 	print MAKEFILE "\tdel /f /q \"$shaderoutputdir\\$shadertype\\$shaderbase\.vcs\"\n";

buildshaders.bat

--- mod/src/materialsystem/stdshaders/buildshaders.bat	2005-07-14 10:00:36.000000000 -0500
+++ mod/src/materialsystem/stdshaders/buildshaders.bat	2005-10-11 23:01:08.000000000 -0500
@@ -36,7 +36,7 @@
 REM ****************
 :set_xbox_args
 set xbox_args=-xbox
-set targetdir=%vproject%\shaders_xbox
+set targetdir="%vproject%\shaders_xbox"
 goto build_shaders
 
 
@@ -45,8 +45,8 @@
 REM ****************
 :set_mod_args
 
-if not exist %sourcesdk%\bin\shadercompile.exe goto NoShaderCompile
-set ChangeToDir=%sourcesdk%\bin
+if not exist "%sourcesdk%\bin\shadercompile.exe" goto NoShaderCompile
+set ChangeToDir="%sourcesdk%\bin"
 
 if /i "%4" NEQ "-source" goto NoSourceDirSpecified
 set SrcDirBase=%~5
@@ -75,7 +75,7 @@
 
 :NoShaderCompile
 echo -
-echo - ERROR: shadercompile.exe doesn't exist in %sourcesdk%\bin
+echo - ERROR: shadercompile.exe doesn't exist in "%sourcesdk%\bin"
 echo -
 goto end
 
@@ -129,7 +129,7 @@
 REM ****************
 REM Execute distributed process on work/build list
 REM ****************
-"%SrcDirBase%\devtools\bin\perl" "%SrcDirBase%\materialsystem\stdshaders\runvmpi.pl" %xbox_args% -changetodir "%ChangeToDir%" %SDKArgs%
+"%SrcDirBase%\devtools\bin\perl" "%SrcDirBase%\materialsystem\stdshaders\runvmpi.pl" %xbox_args% -changetodir %ChangeToDir% %SDKArgs%
 
 REM ****************
 REM Copy the generated files to the output dir.

runvmpi.pl

--- mod/src/materialsystem/stdshaders/runvmpi.pl	2005-07-14 10:00:34.000000000 -0500
+++ mod/src/materialsystem/stdshaders/runvmpi.pl	2005-10-11 22:34:02.000000000 -0500
@@ -41,7 +41,7 @@
 $shaderpath =~ s,/,\\,g;
 chdir $changeToDir;
 
-$cmdToRun = "shadercompile.exe $noMPI $xboxFlag -shaderpath $shaderpath -mpi_workercount 32 -allowdebug $gameFlag";
+$cmdToRun = "shadercompile.exe $noMPI $xboxFlag -shaderpath \"$shaderpath\" -mpi_workercount 32 -allowdebug $gameFlag";
 system $cmdToRun;
 
 # other options..

build_sample_shaders.bat

--- mod/src/sdkshaders/build_sample_shaders.bat	2005-07-14 09:57:02.000000000 -0500
+++ mod/src/sdkshaders/build_sample_shaders.bat	2005-10-11 23:38:18.000000000 -0500
@@ -9,7 +9,7 @@
 
 
 rem **** Call the batch files to build our stuff.
-call ..\materialsystem\stdshaders\buildshaders.bat sdk_shaders -game "%__GameDir%" -source ..
+call ..\materialsystem\stdshaders\buildshaders.bat sdk_shaders -game "%__GameDir%" -source .\..
 goto end


Getting the SDK to work under -Wall -Werror

If you're a professional programmer with any familiarity with GNU then the first thing you probably did was attempt to compile the SDK with -Wall -Werror, and were then disappointed by all the violations in Valve's code out of the box. Here's a list of fixes to make this work. (This list is by no means complete - I fixed many problems before I realized this would be something worth wiki-ing.)

I just noticed Valve uses -fpermissive! *barf*! So, if anyone out there had already noticed that, I now have a work in progress to fix all the scary hacks that -fpermissive would normally error on... coming soon. --Bloodykenny 20:46, 25 Oct 2005 (PDT)

offsetof errors

These are due to a bug in gcc. It was fixed in 3.4.2, and gcc 3.4.4 is now known to work fine and fixes the issue.

Downcast explicitly

One should always downcast explicitly. This squelches useful warnings, and self-documents your intent to downcast. 

--- mod/src/public/tier0/fasttimer.h    2005/06/11 22:14:36     1.2
+++ mod/src/public/tier0/fasttimer.h    2005/09/14 00:25:19
@@ -253,7 +253,7 @@
 inline void CCycleCount::Init( float initTimeMsec )
 {
        if ( g_ClockSpeedMillisecondsMultiplier > 0 )
-               m_Int64 = initTimeMsec / g_ClockSpeedMillisecondsMultiplier;
+               m_Int64 = int64(initTimeMsec / g_ClockSpeedMillisecondsMultiplier);
        else
                m_Int64 = 0;
 }

Poor abused templates

  • This code fixes some badly used Memory Templates, and provides compatibility with Unix based systems.
--- mod/src/public/tier1/utlmemory.h    2005/02/18 04:45:58     1.1.1.1
+++ mod/src/public/tier1/utlmemory.h    2005/09/14 00:24:15
@@ -293,7 +293,7 @@
 {
        Assert( num > 0 );

-       if (IsExternallyAllocated())
+    if (CUtlMemory<T>::IsExternallyAllocated())
        {
                // Can't grow a buffer whose memory was externally allocated
                Assert(0);
@@ -349,7 +349,7 @@
        if (m_nAllocationCount >= num)
                return;

-       if (IsExternallyAllocated())
+    if (CUtlMemory<T>::IsExternallyAllocated())
        {
                // Can't grow a buffer whose memory was externally allocated
                Assert(0);
@@ -376,7 +376,7 @@
 template< class T >
 void CUtlMemory<T>::Purge()
 {
-       if (!IsExternallyAllocated())
+    if (!CUtlMemory<T>::IsExternallyAllocated())
        {
                if (m_pMemory)
                {
@@ -495,7 +495,7 @@
 {
        Assert( num > 0 );

-       if (IsExternallyAllocated())
+    if (CUtlMemory<T>::IsExternallyAllocated())
        {
                // Can't grow a buffer whose memory was externally allocated
                Assert(0);
@@ -551,7 +551,7 @@
        if (CUtlMemory<T>::m_nAllocationCount >= num)
                return;

-       if (IsExternallyAllocated())
+    if (CUtlMemory<T>::IsExternallyAllocated())
        {
                // Can't grow a buffer whose memory was externally allocated
                Assert(0);
@@ -579,7 +579,7 @@
 template< class T, int nAlignment >
 void CUtlMemoryAligned<T, nAlignment>::Purge()
 {
-       if (!IsExternallyAllocated())
+    if (!CUtlMemory<T>::IsExternallyAllocated())
        {
                if (m_pMemoryBase)
                {

Missing EOF linefeeds

First you'll need to `cvs rm -f mod/src/dlls/worker_scientist.h` since that file is blank, unused, and will make the script below not run. :)

Then run: 

#!/usr/bin/perl -w

use strict;
foreach (`find mod -name *.cpp -or -name *.h`) {
    chomp;
    open(F, "+<", $_) or die "$! on $_";
    seek(F, -1, 2) or die "$! on $_";
    my $c;
    read(F, $c, 1) or die "$! on $_";
    if ($c ne "\n") {
        print "$_\n";
        print(F "\n");
    }
}

Garbage after #endifs

A common mistake in the SDK, obviously trivial to fix, but here for your conveniance: 

diff -w -u -r1.3 ai_basenpc.cpp
--- dlls/ai_basenpc.cpp 2005/06/11 22:14:26     1.3
+++ dlls/ai_basenpc.cpp 2005/09/10 18:16:13
@@ -8450,7 +8450,7 @@

        return shotDir;
 }
-#endif HL2_DLL
+#endif // HL2_DLL

 //-----------------------------------------------------------------------------



diff -w -u -r1.1.1.1 npc_BaseZombie.cpp
--- dlls/hl2_dll/npc_BaseZombie.cpp     2005/02/18 04:45:52     1.1.1.1
+++ dlls/hl2_dll/npc_BaseZombie.cpp     2005/09/10 20:57:40
@@ -1582,7 +1582,7 @@

 #ifdef DEBUG_ZOMBIES
                        DevMsg("Wandering\n");
-#endif+
+#endif

                        // Just lost track of our enemy.
                        // Wander around a bit so we don't look like a dingus.



diff -w -u -r1.2 memalloc.h
--- public/tier0/memalloc.h     2005/02/19 18:24:26     1.2
+++ public/tier0/memalloc.h     2005/09/10 05:12:39
@@ -133,6 +133,6 @@
 #define MEM_ALLOC_CREDIT_CLASS()
 #define MEM_ALLOC_CLASSNAME(type) NULL

-#endif !STEAM && NO_MALLOC_OVERRIDE
+#endif // !STEAM && NO_MALLOC_OVERRIDE

 #endif /* TIER0_MEMALLOC_H */


snprintf strangeness

There are several conflicting snprintf defines and other snprintf porting bugs in the SDK, which need to be fixed for Werror compatibility: 

diff -w -u -r1.1.1.1 interface.h
--- public/tier1/interface.h    2005/02/18 04:45:58     1.1.1.1
+++ public/tier1/interface.h    2005/09/10 06:09:25
@@ -33,8 +33,6 @@

 #define HMODULE void *
 #define GetProcAddress dlsym
-
-#define _snprintf snprintf
 #endif

 // TODO: move interface.cpp into tier0 library.



diff -w -u -r1.1.1.1 interface.cpp
--- tier1/interface.cpp 2005/02/18 04:45:59     1.1.1.1
+++ tier1/interface.cpp 2005/09/10 21:18:20
@@ -191,7 +191,7 @@
                Q_snprintf( str, sizeof(str), "%s.dll", szAbsoluteModuleName );
                hDLL = LoadLibrary( str );
 #elif _LINUX
-               _snprintf( str, sizeof(str), "%s_i486.so", szAbsoluteModuleName );
+               Q_snprintf( str, sizeof(str), "%s_i486.so", szAbsoluteModuleName );
                 hDLL = dlopen(str, RTLD_NOW);
 #endif

Broken comments

Ending a // comment with \ is just begging for trouble... 

diff -w -u -r1.1.1.1 collisionutils.cpp
--- public/collisionutils.cpp   2005/02/18 04:45:56     1.1.1.1
+++ public/collisionutils.cpp   2005/09/10 23:59:09
@@ -2299,7 +2299,7 @@

        return true;
 }
-
+/*
 //--------------------------------------------------------------------------
 // Purpose:
 //
@@ -2314,7 +2314,7 @@
 //    0-----2
 //
 //--------------------------------------------------------------------------
-
+*/
 //-----------------------------------------------------------------------------
 // Purpose: find the minima and maxima of the 3 given values
 //-----------------------------------------------------------------------------

First big pass at -Wall and consistent code

Convert stricmp, _alloca etc to Q_stricmp, stackalloc versions. Fix basetype declarations like 0 to 0.0f when appropriate. Comply with STL min/max. Comply with POSIX/BSD naming inline (and appropriate #ifdefing) in all cases where a cross-platform compatibility utility function does not yet exist.

You'll need to remove the inappropriate -D defines in the Makefile for the str/printf/alloc things. Those are now fixed by using the correct functions in the code to begin with, however I don't have a patch for the Makefile included in the file below.

I have uploaded this file for BloodKenny at -

http://www.nigredostudios.com/temp/patch_hl2_sdk_wall_sanity.txt

Right click save as - amckern

Second pass - fix unreliable and error/warning prone min/max/clamp macros with STL calls and normal templatization:

http://aoa.gamemod.net/patch-warning-minmax.txt

Server: Host_Error: SV_PackEntity: SendTable_Encode returned false (ent %d).

Here %d will be replaced by whatever the entity number is that caused the error. No single entity is allowed to write more than 2KB to the network stream. This error happens when an entity overflows that buffer.

Fix: If you need an entity to occasionally transmit more than 2K of data, you will need to split it up into multiple entities, each transmitting part of the data. You should ensure of course that no entity -consistently- transmits 2K of data, as it would bog down your network. Some entities might want to send a large amount on map initialization etc, however. Another possible workaround for some situations (may not always be possible), is to update data a little bit each frame, so that no one frame has a big change.

Server: The client's health variable is pointlessly sent across the wire twice.

Fix: Diff And Patch

  • There is no line 1888 within c_baseplayer.cpp in the stock MP, or SP SDK's - do i just tack the code onto the end (The BaseClass::SetGroundEntity(ground); is also not there) --Amckern 22:46, 5 Nov 2005 (PST)

Ah, sorry. That patch was against an already-modified file, not a fresh SDK. The SetGroundEntity is part of my mod. :) Yes tack it onto the end. After you do so, post the diff back here! --Bloodykenny 09:25, 12 Nov 2005 (PST) 

--- mod/src/cl_dll/c_baseplayer.cpp     2005/06/30 05:54:09     1.6
+++ mod/src/cl_dll/c_baseplayer.cpp     2005/07/16 21:33:33
@@ -1888,3 +1888,7 @@
    BaseClass::SetGroundEntity(ground);
}

+
+int C_BasePlayer::GetHealth() const {
+    return g_PR->GetHealth(entindex());
+}



--- mod/src/cl_dll/c_baseplayer.h       2005/07/11 03:28:41     1.9
+++ mod/src/cl_dll/c_baseplayer.h       2005/07/16 21:05:31
@@ -103,7 +103,7 @@

        // Data handlers
        virtual bool    IsPlayer( void ) const { return true; };
-       virtual int             GetHealth() const { return m_iHealth; };
+       virtual int             GetHealth() const;

        // observer mode
        virtual int                     GetObserverMode() const;



--- mod/src/dlls/player.cpp     2005/07/12 07:38:04     1.33
+++ mod/src/dlls/player.cpp     2005/07/22 00:45:48
@@ -58,6 +58,8 @@
 #include "nav_mesh.h"
 #include "env_zoom.h"

+#include "player_resource.h"
+
 #ifdef HL2_DLL
 #include "combine_mine.h"
 #include "weapon_physcannon.h"
@@ -4295,6 +4297,9 @@
        m_lastx = m_lasty = 0;

        m_lastNavArea = NULL;
+
+    // update now so that our new health gets sent with the respawn notice
+    g_pPlayerResource->SetPlayerHealth(entindex(), m_iHealth);

        /// @todo Do this once per round instead of once per player
        if (TheNavMesh)



--- mod/src/dlls/player_resource.cpp    2005/06/19 02:54:04     1.5
+++ mod/src/dlls/player_resource.cpp    2005/07/22 00:44:35
@@ -85,6 +85,13 @@
 }

 //-----------------------------------------------------------------------------
+// Purpose: Sets health value for a particular client (used to set on spawn so the data will be sent synchronously)
+//-----------------------------------------------------------------------------
+void CPlayerResource::SetPlayerHealth(int entindex, int health) {
+    m_iHealth.Set(entindex, health);
+}
+
+//-----------------------------------------------------------------------------
 // Purpose: The Player resource is always transmitted to clients
 //-----------------------------------------------------------------------------
 int CPlayerResource::UpdateTransmitState()



--- mod/src/dlls/player_resource.h      2005/06/18 21:16:29     1.3
+++ mod/src/dlls/player_resource.h      2005/07/22 00:42:57
@@ -26,6 +26,8 @@
        virtual void UpdatePlayerData( void );
        virtual int  UpdateTransmitState(void);

+    void SetPlayerHealth(int entindex, int health);
+
 protected:
        // Data for each player that's propagated to all clients
        // Stored in individual arrays so they can be sent down via datatables

Then you can remove the SendPropInt and RecvPropInt for CBasePlayer::m_iHealth... 

--- src/cl_dll/c_baseplayer.cpp	26 Aug 2006 21:24:21 -0000	1.14
+++ src/cl_dll/c_baseplayer.cpp	4 Sep 2006 18:33:46 -0000
@@ -222,7 +222,7 @@
 		RecvPropEHandle( RECVINFO(m_hVehicle) ),
 		RecvPropEHandle( RECVINFO(m_hUseEntity) ),
 
-		RecvPropInt		(RECVINFO(m_iHealth)),
+		// RecvPropInt		(RECVINFO(m_iHealth)),
 		RecvPropInt		(RECVINFO(m_lifeState)),
 
 		RecvPropFloat	(RECVINFO(m_flMaxspeed)),
@@ -284,7 +284,7 @@
 
 	DEFINE_PRED_FIELD( m_hVehicle, FIELD_EHANDLE, FTYPEDESC_INSENDTABLE ),
 	DEFINE_PRED_FIELD_TOL( m_flMaxspeed, FIELD_FLOAT, FTYPEDESC_INSENDTABLE, 0.5f ),
-	DEFINE_PRED_FIELD( m_iHealth, FIELD_INTEGER, FTYPEDESC_INSENDTABLE ),
+	// DEFINE_PRED_FIELD( m_iHealth, FIELD_INTEGER, FTYPEDESC_INSENDTABLE ),
 	DEFINE_PRED_FIELD( m_fOnTarget, FIELD_BOOLEAN, FTYPEDESC_INSENDTABLE ),
 	DEFINE_PRED_FIELD( m_nNextThinkTick, FIELD_INTEGER, FTYPEDESC_INSENDTABLE ),
 	DEFINE_PRED_FIELD( m_lifeState, FIELD_CHARACTER, FTYPEDESC_INSENDTABLE ),


--- src/cl_dll/c_baseplayer.h	26 Aug 2006 21:24:21 -0000	1.19
+++ src/cl_dll/c_baseplayer.h	4 Sep 2006 18:33:46 -0000
@@ -377,7 +377,7 @@
 	EHANDLE			m_hUseEntity;
 	
 	float			m_flMaxspeed;
-	int				m_iHealth;
+	void			m_iHealth(); // hide the base class m_iHealth to ensure it's not used
 
 	CInterpolatedVar< Vector >	m_iv_vecViewOffset;
 


--- src/dlls/player.cpp	3 Sep 2006 23:29:16 -0000	1.76
+++ src/dlls/player.cpp	4 Sep 2006 18:33:47 -0000
@@ -7298,7 +7298,7 @@
 		SendPropDataTable(SENDINFO_DT(pl), &REFERENCE_SEND_TABLE(DT_PlayerState), SendProxy_DataTableToDataTable),
 		SendPropEHandle(SENDINFO(m_hVehicle)),
 		SendPropEHandle(SENDINFO(m_hUseEntity)),
-		SendPropInt		(SENDINFO(m_iHealth), 10 ),
+		// SendPropInt		(SENDINFO(m_iHealth), 10 ),
 		SendPropInt		(SENDINFO(m_lifeState), 3, SPROP_UNSIGNED ),
 		SendPropFloat	(SENDINFO(m_flMaxspeed), 12, SPROP_ROUNDDOWN, 0.0f, 2048.0f ),  // CL
 		SendPropInt		(SENDINFO(m_fFlags), PLAYER_FLAG_BITS, SPROP_UNSIGNED|SPROP_CHANGES_OFTEN, SendProxy_CropFlagsToPlayerFlagBitsLength ),


--- src/game_shared/gamemovement.cpp	26 Aug 2006 21:24:36 -0000	1.21
+++ src/game_shared/gamemovement.cpp	4 Sep 2006 18:33:47 -0000
@@ -490,7 +490,7 @@
 
 bool CGameMovement::IsDead( void ) const
 {
-	return ( player->m_iHealth <= 0 ) ? true : false;
+	return ( player->GetHealth() <= 0 ) ? true : false;
 }
 
 //-----------------------------------------------------------------------------

Server: The client's team membership is pointlessly sent across the wire twice.

Similar to the above KI, but for another variable. Also this fixes an SDK crasher, but according to Yahn at Valve, Steam will be fixed soon to not do that.

Fix: Diff And Patch 

--- mod/src/dlls/team.cpp       2005/06/11 22:14:30     1.2
+++ mod/src/dlls/team.cpp       2006/05/29 18:58:52     1.3
@@ -19,6 +19,7 @@
 //-----------------------------------------------------------------------------
 void SendProxy_PlayerList( const SendProp *pProp, const void *pStruct, const void *pData, DVariant *pOut, int iElement, int objectID )
 {
+    Assert(0);
        CTeam *pTeam = (CTeam*)pData;

        // If this assertion fails, then SendProxyArrayLength_PlayerArray must have failed.
@@ -31,8 +32,11 @@

 int SendProxyArrayLength_PlayerArray( const void *pStruct, int objectID )
 {
-       CTeam *pTeam = (CTeam*)pStruct;
-       return pTeam->m_aPlayers.Count();
+    // The RecvPropArray2 in general was seemingly broken in the May 25th-ish core engine update.
+    // The CTeam in particular was certainly broken at that time, however, thankfully it doesn't
+    // serve any important purpose.
+    // For backwards compatibility with old client, we disable it, rather than remove it entirely.
+    return 0;
 }

Server: weapon_citizensuitcase Assert on startup

Fix: Install copy of the SP SDK, then copy the scripts/ directory over

Server: Some bullet weapons set to do 0 damage.

Fix: Need to edit their AddAmmoType which are strangely set to 0 for some reason.

Server: Some projectile weapons set to do 0 damage.

Fix: Need to edit their source files and set a damage.

Client: --- Missing Vgui material vgui/steam/games/icon_cz

Fix: These files are used in the currently inaccessible Friends IM client. Create 4 vmts in their places of any design to remove the error.

  • materials\VGUI\steam\games\icon_cs.vmt
  • materials\VGUI\steam\games\icon_dod.vmt
  • materials\VGUI\steam\games\icon_hl2mp.vmt
  • materials\VGUI\servers\icon_secure_deny.vmt

Here's a patch to create files for the first three. (I don't see the icon_secure_deny.vmt error, so didn't create anything for it.) 

--- materials/VGUI/steam/games/icon_cs.vmt      1969-12-31 18:00:00.000000000 -0600
+++ materials/VGUI/steam/games/icon_cs.vmt      2005-07-28 01:54:17.000000000 -0500
@@ -0,0 +1 @@
+"UnlitGeneric" {}
--- materials/VGUI/steam/games/icon_dod.vmt     1969-12-31 18:00:00.000000000 -0600
+++ materials/VGUI/steam/games/icon_dod.vmt     2005-07-28 01:54:19.000000000 -0500
@@ -0,0 +1 @@
+"UnlitGeneric" {}
--- materials/VGUI/steam/games/icon_hl2mp.vmt   1969-12-31 18:00:00.000000000 -0600
+++ materials/VGUI/steam/games/icon_hl2mp.vmt   2005-07-28 01:54:15.000000000 -0500
@@ -0,0 +1 @@
+"UnlitGeneric" {}

Fix2: Add clear to your rc file in cfg (extract from gcf if non-existant)

Server: The crossbow causes an assertion failure.

Fix: Comment out ai_activity.cpp line 53. This doesn't appear to be something that can be fixed in code?

Server? Client?: RL explosion invisible

Per http://www.chatbear.com/board.plm?a=viewthread&t=970,1107153392,30132&id=786504&b=4991&v=flatold

The patch to c_te_explosion.cpp was rolled into the 2006-08-04 SDK update, however it does not fix the issue. The issue still exists. My current speculation is that this is a bug in core or in the maps, but hard to say which.

sv_gravity is not associated with physics gravity

When gravity is changed, the physics gravity isn't updated

Fix: In movevars_shared.cpp: 

inline void UpdatePhysicsGravity(float gravity)
{
	if(physenv)
		physenv->SetGravity(Vector(0,0,-gravity));
}
static void GravityChanged_Callback( ConVar *var, const char *pOldString )
{
#ifndef CLIENT_DLL
	UpdatePhysicsGravity(var->GetFloat());
	if(gpGlobals->mapname!=NULL_STRING)
	{
		IGameEvent *event = gameeventmanager->CreateEvent( "gravity_change" );
		if ( event )
		{
			event->SetFloat( "newgravity", var->GetFloat() );
			gameeventmanager->FireEvent( event );
		}
	}
#endif
}
#ifdef CLIENT_DLL
class CGravityChange : public IGameEventListener2, public CAutoGameSystem
{
public:
	bool Init()
	{
		gameeventmanager->AddListener(this,"gravity_change",false);
		return true;
	}
	void FireGameEvent( IGameEvent *event )
	{
		UpdatePhysicsGravity(event->GetFloat("newgravity"));
	}
};
static CGravityChange s_GravityChange;
#endif
ConVar	sv_gravity		( "sv_gravity",DEFAULT_GRAVITY_STRING, FCVAR_NOTIFY | FCVAR_REPLICATED, "World gravity.", GravityChanged_Callback );

In your mod's events file (GameEvents.res/ModEvents.res): 

	"gravity_change"
	{
		"newgravity"	"float"
	}
Todo: Diff this

Server: util.cpp (531) : Assertion Failed: !"UTIL_GetLocalPlayer"

Occurs when taking damage to yourself from tossing a table straight up into the air.

Fix: The following patch fixes the Assert, and appears to be more functionally correct as well. Validation from Valve that the patch is correct would be appreciated. Diff And Patch 

Index: mod/src/dlls/player.h
===================================================================
--- mod/src/dlls/player.h 2005/02/19 22:20:29 1.2
+++ mod/src/dlls/player.h 2005/02/24 00:35:30
@@ -459,6 +459,7 @@
     // mass/size limit set to zero for none
     static bool CanPickupObject( CBaseEntity *pObject, float massLimit, float sizeLimit );
     virtual void PickupObject( CBaseEntity *pObject, bool bLimitMassAndSize = true ) {}
+    virtual bool IsHoldingEntity( CBaseEntity *pEnt );
     virtual void ForceDropOfCarriedPhysObjects( CBaseEntity *pOnlyIfHoldindThis = NULL ) {}
     virtual float GetHeldObjectMass( IPhysicsObject *pHeldObject );

Index: mod/src/dlls/player.cpp
===================================================================
--- mod/src/dlls/player.cpp 2005/02/21 00:05:42 1.3
+++ mod/src/dlls/player.cpp 2005/02/24 00:35:33
@@ -7447,3 +7447,7 @@
     return cmd;
 }

+bool CBasePlayer::IsHoldingEntity( CBaseEntity *pEnt )
+{
+    return PlayerPickupControllerIsHoldingEntity( m_hUseEntity, pEnt );
+}

Index: mod/src/dlls/physics_impact_damage.cpp
===================================================================
--- mod/src/dlls/physics_impact_damage.cpp 2005/02/18 04:45:50 1.1.1.1
+++ mod/src/dlls/physics_impact_damage.cpp 2005/02/24 00:42:24
@@ -417,12 +417,22 @@
     else if ( pEvent->pObjects[index>GetGameFlags() & FVPHYSICS_PLAYER_HELD )
     {
     // if the player is holding the object, use it's real mass (player holding reduced the mass)
-    CBasePlayer *pPlayer = UTIL_GetLocalPlayer();
-    if ( pPlayer )
-    {
+    CBasePlayer* pPlayer = NULL;
+    {for (int i = 1; i <= gpGlobals->maxClients; i++) {
+        CBasePlayer *temp_player = UTIL_PlayerByIndex(i);
+        if (temp_player
+            && temp_player->edict()
+            && temp_player->IsHoldingEntity(pEvent->pEntities[index])
+        ) {
+            pPlayer = temp_player;
+            break;
+        }
+    }}
+    Assert(pPlayer && "object with FVPHYSICS_PLAYER_HELD but no player holding it");
+    if (pPlayer) {
     float mass = pPlayer->GetHeldObjectMass( pEvent->pObjects[index] );
-    if ( mass > 0 )
-    {
+        Assert((mass > 0) && "player was holding object so mass should be non-zero");
+        if (mass > 0) {
             invMass = 1.0f / mass;
         }
     }
Note.pngNote:Instead of iterating all players, why not consider adding a m_pHolder var and GetHolder and SetHolder functions to CBaseEntity

(You could, though it's unlikely to impact performance much since this is not a frequently called function. Bloodykenny 17:55, 19 Jul 2005 (PDT))

Assert !"UTIL_GetLocalPlayer" when using combine ball

Fix: Diff And Patch 

diff -u -r1.1.1.1 prop_combine_ball.cpp 
--- mod/src/dlls/hl2_dll/prop_combine_ball.cpp 2005/02/18 04:45:52 1.1.1.1 
+++ mod/src/dlls/hl2_dll/prop_combine_ball.cpp 2005/02/24 01:34:21 
@@ -788,9 +788,9 @@ 
     pPhysicsObject->GetPosition( &vecPosition, NULL ); 
     pPhysicsObject->GetVelocity( &vecVelocity, NULL ); 

-    CBasePlayer *pPlayer = UTIL_GetLocalPlayer(); 
-    if ( pPlayer ) 
+    if (gpGlobals->maxClients == 1) 
     { 
+    CBasePlayer *pPlayer = UTIL_GetLocalPlayer(); 
     Vector vecDelta; 
     VectorSubtract( pPlayer->GetAbsOrigin(), vecPosition, vecDelta ); 
     VectorNormalize( vecDelta );

Server/Client: Negative entitygroundcontact crash.

The implications of this SDK bug are not at all clear, but in debug mode you'll get an assert, and in release mode it will presumably segfault. The patch assumes anything negative or really large is bogus and dumps it.

I'm starting to wonder if maybe this is another symptom of the Physics Mayhem bugs. --Bloodykenny 17:24, 4 Nov 2005 (PST)

Fix: Diff And Patch 

--- mod/src/game_shared/usercmd.cpp 2005/02/18 04:45:54 1.1.1.1
+++ mod/src/game_shared/usercmd.cpp 2005/03/23 02:24:00
@@ -290,7 +290,12 @@
 #if defined( HL2_DLL )
     if ( buf->ReadOneBit() )
     {
-        move->entitygroundcontact.SetCount( buf->ReadShort() );
+        int count = buf->ReadShort();
+        if ((count < 0) || (count > 140)) {
+            Msg("Ignoring strange entitygroundcontact count: %d\n", count);
+            return; // why can this be less than 0, Valve? change to ReadWord()???
+        }
+    move->entitygroundcontact.SetCount( count );

     int i;
     for (i = 0; i < move->entitygroundcontact.Count(); i++)

Client: Spinning around quickly with the Stun Baton as your active weapon causes the screen to flash white

It's worth noting that recent updates to HL2DM have fixed this. However there has not yet been an SDK code update to show what the fix is. Basically Valve seems to have made the glow fade out completely in between swings.

Fix: Fix unknown

Assert on line 866 of mod/src/game_shared/basecombatweapon_shared.cpp

Fix: I haven't been able to determine exactly why this is an assert. It's just "Assert(0);" with no accompanying explanation, but commenting it out results in no problems it seems. Diff And Patch 

--- mod/src/game_shared/basecombatweapon_shared.cpp     2005/02/18 04:45:53     1.1
+++ mod/src/game_shared/basecombatweapon_shared.cpp     2005/03/04 03:45:36     1.2
@@ -863,7 +863,7 @@
        CBaseViewModel *vm = pOwner->GetViewModel( m_nViewModelIndex );
        if ( vm == NULL )
        {
-               Assert( false );
+               //Assert( false );
                return false;
        }

Client: The mod can appear to have frozen on initial startup

Originally posted by MattC here: http://www.chatbear.com/board.plm?a=viewthread&b=4991&t=234,1117553034,6915&s=0&id=868372

Fix: Issue a "progress_enable" command just before "map <mapname>". 

engine->ClientCmd("progress_enable");

engine->ClientCmd("map test");

This should fix local servers. For connecting to a remote multiplayer server, the only issue appears to be that you can't switch to another window and then switch back to HL2. Doing so causes HL2 to never render progress info until load is fully complete. That seems to be an HL2 core bug unrelated (though very similar in appearance) to the fix above.

USE_VCR_MODE linker errors

This is because Valve wants to be able to somehow replay all of the things that happen in a mod and get back the exact same output. I'm still confused as to how that would work, or what the value really is, but anyway, if you need things like threading, you'll hit these errors.

My mod needed threading and commenting these out has never caused any issue. Though apparently it means my mod can't use VCR mode.

Fix: Comment out the appropriate lines in protected_things.h, for whatever VCR thing was failing. Note, don't just block out the whole file - the string part at the top is actually useful.

Lighting in Compile (RAD)

There is currently a rather severe lighting bug during RAD. Visible symptoms include: black models while in shadows cast by light_environment; large, unlit sections in "outdoor" type areas.

Fix: Pending.


Complaints about tv_delaymapchange in NON SRCTV Mods

Note.pngNote:This issue is fixed in the August 2006 SDK update

Issue: Console reports an issue about tv_delaymapchange when loading a mod with no SRCTV Support.

mod/game_shared/multiplay_gamerules.cpp

Undone! you don't have to remove it, instead, add FCVAR_REPLICATED like all the other cvar's. It's doing it because it's a shared ConVar in both dll's and not being replicated. --omega

Instead, change to this: 

Line 47
ConVar	mp_timelimit( "mp_timelimit",
					  "0",
					  FCVAR_NOTIFY|FCVAR_REPLICATED,
					  "game time per map in minutes" );

ConVar	tv_delaymapchange( "tv_delaymapchange",
					  "0",
-					  0,
+					  FCVAR_NOTIFY|FCVAR_REPLICATED,
					  "Delays map change until broadcast is complete" );

Physics models show up darker under switchable lights

Switchable lights are not taken into account for visibility of physics models when Source starts a map. So whenever a physics model is mostly lit by switchable lights, it will show up much darker when the map starts.

If the switchable lights are turned off and on again, or if a physics model is moved, then the visibility of this physics model is automatically fixed. But if the map is saved and reloaded, all physics models under switchable lights become darker again.

Note.pngNote:A switchable light is a light with a targetname, that can be triggered to turn on/off.

Fix: Fix unknown


Sticky Player Collisions / No lagcompensation

Note.pngNote:In the SDK-code of August 06, there is no StartLagCompensation() call.

I've been chasing a fix for this for months for Dystopia, when two players collide with each other there's massive prediction errors and to the player it looks like they're jerking back and forth. It can mean real trouble when two players attempt to get through a doorway or something, and it sucks if you're trying to do a good melee system.

Anyways, I found out the cause of this problem is on the server, when it runs a players movement code, it first unlags all the other players on the server, presumably to help predict player vs. player collisions. The problem is, because two players have different pings, there's no authoritative point of impact for the collision, so the jerking around you see is caused by this unlagging. Now down to the fix, which is really simple:

player_command.cpp Line 42 

	// Move other players back to history positions based on local player's lag
-	lagcompensation->StartLagCompensation( player, cmd );

player_command.cpp Line 52 

	// Restore other players to current positions
-	lagcompensation->FinishLagCompensation( player );

player_command.cpp Line 348 

	// Let server invoke any needed impact functions
	moveHelper->ProcessImpacts();

+	// Only do unlag for post think/post frame, which is mainly weapons stuff! - Teddy
+	lagcompensation->StartLagCompensation( player, ucmd );
	RunPostThink( player );
+	lagcompensation->FinishLagCompensation( player );

	FinishCommand( player );

Pretty simple huh? You only need unlag for weapons really, and all the weapon hitscan code is run from the weapon's ItemPostFrame which is what the RunPostThink() runs. Let me know if it works for you! --Teddy 20:05, 12 Jun 2006 (PDT)

I added this fix to the latest version of the SDK (as of January, 2007) and I did not notice any difference. I believe this issue may have already been addressed in the latest SDK so this fix is uneccessary if you are running the latest SDK code. [User: Minh]

Minor/misc code neatenings/fixings

(This section is for issues in the codebase that you've spotted to be potentially dangerous but aren't actually causing obvious bugs/issues... every little improvement to the quality of the codebase helps, right?)

/src/cl_dll/game_controls/spectatorgui.cpp(508): The memset is setting twice as much memory as it should be to 0x0 because sizeof(playerName) already accounts for the fact that the elements are wchar_t type. Fix: Remove the "* sizeof( wchar_t)".

filter_damage_type doesn't work

Open dlls/filters.cpp and replace 

return info.GetDamageType() == m_iDamageType;

with 

return ( (info.GetDamageType() & m_iDamageType ) ? true : false );

Floating SLAM's

When attaching a SLAM at a movable object, it doesn't explode when the object moves and so give a "floating SLAM".

Fix: 

--- mod/src/dlls/hl2_dll/grenade_tripmine.h	18 Feb 2005 04:45:51 -0000	1.1.1.1
+++ mod/src/dlls/hl2_dll/grenade_tripmine.h	22 Jul 2006 22:32:28 -0000
@@ -36,6 +36,8 @@
 	void MakeBeam( void );
 	void KillBeam( void );
 
+    void AttachToEntity(const CBaseEntity* const ent);
+
 public:
 	EHANDLE		m_hOwner;
 
@@ -49,6 +51,10 @@
 	Vector		m_posOwner;
 	Vector		m_angleOwner;
 
+    const CBaseEntity* m_pAttachedObject;
+    Vector m_vecOldPosAttachedObject;
+    QAngle m_vecOldAngAttachedObject;
+
 	DECLARE_DATADESC();
 };
 
--- mod/src/dlls/hl2mp_dll/grenade_tripmine.cpp	18 Feb 2005 04:45:51 -0000	1.1.1.1
+++ mod/src/dlls/hl2mp_dll/grenade_tripmine.cpp	22 Jul 2006 22:32:28 -0000
@@ -91,6 +91,8 @@
 	m_vecEnd = GetAbsOrigin() + m_vecDir * 2048;
 
 	AddEffects( EF_NOSHADOW );
+
+    m_pAttachedObject = NULL;
 }
 
 
@@ -224,7 +226,27 @@
 		return;
 	}
 
-	SetNextThink( gpGlobals->curtime + 0.05f );
+    // Detonate if the parent object moves
+    if (
+        m_pAttachedObject
+        && (
+               !VectorsAreEqual(m_vecOldPosAttachedObject, m_pAttachedObject->GetAbsOrigin(), 1.0f)
+            || !QAnglesAreEqual(m_vecOldAngAttachedObject, m_pAttachedObject->GetAbsAngles(), 1.0f)
+        )
+    ) {
+        m_iHealth = 0;
+        Event_Killed(CTakeDamageInfo((CBaseEntity*)m_hOwner, this, 100, GIB_NORMAL));
+        return;
+    }
+
+	SetNextThink(gpGlobals->curtime + 0.05f);
+}
+
+void CTripmineGrenade::AttachToEntity(const CBaseEntity* const ent) {
+    Assert(m_pAttachedObject == NULL);
+    m_pAttachedObject = ent;
+    m_vecOldPosAttachedObject = ent->GetAbsOrigin();
+    m_vecOldAngAttachedObject = ent->GetAbsAngles();
 }
 
 int CTripmineGrenade::OnTakeDamage_Alive( const CTakeDamageInfo &info )
--- mod/src/dlls/hl2mp_dll/grenade_tripmine.h	18 Feb 2005 04:45:51 -0000	1.1.1.1
+++ mod/src/dlls/hl2mp_dll/grenade_tripmine.h	22 Jul 2006 22:32:28 -0000
@@ -36,6 +36,8 @@
 	void MakeBeam( void );
 	void KillBeam( void );
 
+    void AttachToEntity(const CBaseEntity* const ent);
+
 public:
 	EHANDLE		m_hOwner;
 
@@ -49,6 +51,10 @@
 	Vector		m_posOwner;
 	Vector		m_angleOwner;
 
+    const CBaseEntity* m_pAttachedObject;
+    Vector m_vecOldPosAttachedObject;
+    QAngle m_vecOldAngAttachedObject;
+
 	DECLARE_DATADESC();
 };
 
--- mod/src/game_shared/hl2mp/weapon_slam.cpp	17 Jun 2006 17:51:06 -0000	1.6
+++ mod/src/game_shared/hl2mp/weapon_slam.cpp	22 Jul 2006 22:32:28 -0000
@@ -371,6 +371,7 @@
 			CBaseEntity *pEnt = CBaseEntity::Create( "npc_tripmine", tr.endpos + tr.plane.normal * 3, angles, NULL );
 
 			CTripmineGrenade *pMine = (CTripmineGrenade *)pEnt;
+            pMine->AttachToEntity(pEntity);
 			pMine->m_hOwner = GetOwner();
             pMine->SetDamage(pOwner->get_damage(AOA_SLAM));
 #endif

Assertion Failed in utlbuffer.cpp

[ISSUE] An assertion is thrown from the following location in utlbuffer.cpp: 

CUtlBuffer::CUtlBuffer( const void *pBuffer, int nSize, int nFlags ) :
	m_Memory( (unsigned char*)pBuffer, nSize ), m_Error(0)
{
        Assert( nSize != 0 );

	...
}


[FIX] Change the source to: 

CUtlBuffer::CUtlBuffer( const void *pBuffer, int nSize, int nFlags ) :
	m_Memory( (unsigned char*)pBuffer, nSize ), m_Error(0)
{
        Assert( nSize >= 0 );

	...
}


However, there appears to be a separate issue with dependencies in the VS project. For example, selecting Build Solution may not reflect the above changes when running the project. For a temporary workaround, select Rebuild Solution and then Build Solution. The expected behavior is that rebuilding will produce a linker error about tier1.lib, but building afterwards will succeed.


[TODO] Investigate VS project dependencies to come up with a fix that avoids having to rebuild the solution.

Constant physprops->GetSurfaceData( ) on Linux

The physprops->GetSurfaceData( ) for a trace returns always CHAR_TEX_CONCRETE on Linux with SDK 2007. The surface type is correctly detected on Windows though. This should be fixed in 2009 according to: [2].

Cannot re-ignite entities

There's a glich in SDK that does not call Extinguish() on entity once fire goes out, because it always returns NULL pointer, this causes inability to ignite same entity again. To fix this without changing header go to EntityFlame.cpp line 286.

Warning.pngWarning:Not only can you re-ignite entities in latest SDK version, but the game will crash if this edit is applied.

Replace this 

if ( m_hEntAttached )
		{
			CBaseCombatCharacter *pAttachedCC = m_hEntAttached->MyCombatCharacterPointer();

			if( pAttachedCC )
			{
				// Notify the NPC that it's no longer burning!
				pAttachedCC->Extinguish();
			}
		}

with this 

		if ( m_hEntAttached )
		{
			//Cannot directly cast networked variables
			CBaseEntity *temp = m_hEntAttached;
			CBaseCombatCharacter *pAttachedCC = (CBaseCombatCharacter *)temp;

			if( pAttachedCC )
			{
				// Notify the NPC that it's no longer burning!
				pAttachedCC->Extinguish();
			}
		}

Other info and links

See also Core Known Issues List for the list of issues in the closed-source HL2 Core engine.

See also SDK Known Issues List Fixed for the list of SDK Known Issues fixed in new SDK revisions.

See also this nice general HL2 bug list on the steam forums. Many of the issues seem imbedded down inside the closed-source side of things, so they are outside the scope of this SDK Known Issues list.

There's also this Patch HL2 petition where users sign their name to beg Valve to fix the aforementioned bugs.

SDK Known Issues specific to memory leaks are on the Memory Leak Fixes page.

Retrieved from "https://developer.valvesoftware.com/w/index.php?title=SDK_Known_Issues_List&oldid=308564"